[HOLD for payment 2023-11-02] [$500] The attachment's close icon is not entirely clickable on the desktop app

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.3.84-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @adeel0202
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1697105723301089

Action Performed:

1. Open any chat with an attachment
2. Click on the attachment
3. Hover over the left side of the close icon

Expected Result:

The close icon is entirely clickable

Actual Result:

The left side of the close icon is not clickable

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

safari.mov

chrome.mov

MacOS: Desktop

desktop.mov

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0167de4cc8d1415484
• Upwork Job ID: 1712974320766828544
• Last Price Increase: 2023-10-13
• Automatic offers:
• Krishna2323 | Contributor | 27337905
• adeel0202 | Reporter | 27337908

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0167de4cc8d1415484

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

[abdel-h66]

Can't reproduce this one on the latest main.

[zukilover]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The attachment's close icon is not entirely clickable on the desktop app, precisely some left portion of the button.

What is the root cause of that problem?

The right padding rule of the buttons wrapper creates the unclickable area for every last element inside it:

App/src/components/HeaderWithBackButton/index.js

Lines 93 to 94 in 3e5f300

	<View style={[styles.reportOptions, styles.flexRow, styles.pr5, styles.alignItemsCenter]}>
	{children}

What changes do you think we should make in order to solve the problem?

Replace the right padding rule with transform.

1. Remove the padding rule:

<View style={[styles.reportOptions, styles.flexRow, styles.alignItemsCenter]}>

2. Add the transform rule to compensate the right padding:

Modify this style:

App/src/styles/styles.ts

Lines 871 to 873 in 3e5f300

	reportOptions: {
	marginLeft: 8,
	},

to:

reportOptions: {
    marginLeft: 8,
    transform: [{translateX: -20}]
},

Before:

before_comp.mp4

After:

after_comp.mp4

What alternative solutions did you explore? (Optional)

N/A

[Krishna2323]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The attachment's close icon is not entirely clickable on the desktop app

What is the root cause of that problem?

This is a known issue in electron apps where elements doesn't react to any hovers/clicks.

What changes do you think we should make in order to solve the problem?

In our case we can solve this by passing dataSet={{dragArea: false}} to HeaderWithBackButton which will apply -webkit-app-region: no-drag;, we are already using this in many places in our app.

Result

Screen.Recording.2023-10-14.at.6.57.30.AM.mov

[Victor-Nyagudi]

It seems there's a slim vertical strip in which the x is unclickable.

However, everywhere else works fine. The user only has to move literal millimeters for the cursor to change to a pointer and the x becomes clickable again.

There's an extremely high chance their cursor lands on the 85% of the x that's clickable and they accomplish their goal of closing the attachment on the first try with ease, which is what we're going for.

It's for this reason I propose to do nothing here.

Valid bug.

[Krishna2323]

Just to note, in my video demo, it is evident that the unclickable portion is not merely a thin line; it covering about 50% of the icon area.

[Victor-Nyagudi]

I stand corrected, then.

[mollfpr]

Thanks for the issue upstream attachment @Krishna2323

I see that the issue still exists now, and the solution from @Krishna2323 proposal seems not to harm (we don't have any draggable component near the modal header). @Krishna2323 Could you update your proposed changed part to specify which component or line the changes apply? I assume it's in the HeaderWithBackButton component.

🎀 👀 🎀 C+ reviewed!

@johncschuster Could you help add the Engineering label? Thank you!

[johncschuster]

Sure thing!

[melvin-bot]

Triggered auto assignment to @joelbettner (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[joelbettner]

@mollfpr I think the proposal from @Krishna2323 looks good. I'll assign to this issue.

[melvin-bot]

📣 @Krishna2323 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

📣 @adeel0202 🎉 An offer has been automatically sent to your Upwork account for the Reporter role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[Krishna2323]

@mollfpr, PR ready for review.

[melvin-bot]

🎯 ⚡️ Woah @Krishna2323, great job pushing this forwards! ⚡️

The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉

• when @Krishna2323 got assigned: 2023-10-23 21:13:48 Z
• when the PR got merged: 2023-10-24 15:09:59 UTC

On to the next one 🚀

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.91-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: Attachment's close icon is not entirely clickable on the desktop app. #30225

If no regressions arise, payment will be issued on 2023-11-02. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @mollfpr requires payment
• @Krishna2323 requires payment offer (Contributor)
• @adeel0202 requires payment offer (Reporter)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mollfpr] The PR that introduced the bug has been identified. Link to the PR:
• [@mollfpr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@mollfpr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@mollfpr] Determine if we should create a regression test for this bug.
• [@mollfpr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@johncschuster] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[Krishna2323]

@johncschuster, bump for payments here.

[melvin-bot]

@johncschuster, @joelbettner, @mollfpr, @Krishna2323 Whoops! This issue is 2 days overdue. Let's get this updated quick!

[johncschuster]

Payment Summary:

The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉(Comment)

@mollfpr requires payment via Manual Request - $750
@Krishna2323 requires payment offer (Contributor) - PAID
@adeel0202 requires payment offer (Reporter) - PAID

[mollfpr]

[@mollfpr] The PR that introduced the bug has been identified. Link to the PR:
[@mollfpr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

I don't see any offending PR.

[@mollfpr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

The regression step should be enough.

[@mollfpr] Determine if we should create a regression test for this bug.
[@mollfpr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

1. Open any chat with an attachment
2. Click on the attachment
3. Hover over the of the close icon
4. Verify icon is clickable and the cursor is changed
5. 👍 or 👎

[johncschuster]

Leaving this open for me to get regression test issue going

[JmillsExpensify]

$750 payment approved for @mollfpr based on BZ summary above.