[HOLD on #30438] [$500] Logging in with the workspace currency page shows "hmm its not found"

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.3.84-1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @abzokhattab
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1697311201107929

Action Performed:

1. Go to settings > Workspaces
2. Select a workspace from the list or create a new one
3. Go Settings
4. Click on default currency and copy the current url.
5. Sign in again with the copied URL

Expected Result:

Not found page shouldn't display briefly.

Actual Result:

Not found page display briefly until the app loads

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Android: Native

Android: mWeb Chrome

Screen.Recording.2023-10-16.at.2.35.49.AM.mov

iOS: Native

iOS: mWeb Safari

RPReplay_Final1697412172.MP4

MacOS: Chrome / Safari

Screen.Recording.2023-10-14.at.10.18.50.PM.mov

Recording.85.mp4

MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01a9f19acaa134409a
• Upwork Job ID: 1713710726656147456
• Last Price Increase: 2023-10-23

Issue Owner

Current Issue Owner: @mkhutornyi

[melvin-bot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01a9f19acaa134409a

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan (External)

[m-natarajan]

Proposal by @abzokhattab

Please re-state the problem that we are trying to solve in this issue.

Not found page display briefly when we access the WorkspaceSettingsCurrencyPage via deep link

What is the root cause of that problem?

The not found page is shown whenever the policy is empty

App/src/pages/workspace/WorkspaceSettingsCurrencyPage.js

Line 82 in c559c5c

shouldShow={_.isEmpty(policy) || !PolicyUtils.isPolicyAdmin(policy) || PolicyUtils.isPendingDeletePolicy(policy)}

In our case When we access it via deep link, the report needs to load from openApp API. So the not found page displays briefly before the openApp API is complete

What changes do you think we should make in order to solve the problem?

we should use the withPolicyAndFullscreenLoading instead of the withPolicy hoc, as it will show the loader indicator till the data is ready

withPolicyAndFullscreenLoading,

POC

Screen.Recording.2023-10-14.at.10.37.20.PM.mov

[yh-0218]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Logging in with the workspace currency page shows "hmm its not found"

What is the root cause of that problem?

App/src/pages/workspace/WorkspaceSettingsCurrencyPage.js

Line 82 in 279ce1b

shouldShow={_.isEmpty(policy) || !PolicyUtils.isPolicyAdmin(policy) || PolicyUtils.isPendingDeletePolicy(policy)}

We didn't check isLoadingReportData value.
So during loading data(isLoadingReportData = true), we will see Not Found

What changes do you think we should make in order to solve the problem?

1. Need to get isLoadingReportData value from withOnyx

isLoadingReportData: {
            key: ONYXKEYS.IS_LOADING_REPORT_DATA,
},

Add to here isLoadingReportData with currencyList

App/src/pages/workspace/WorkspaceSettingsCurrencyPage.js

Line 112 in 279ce1b

currencyList: {key: ONYXKEYS.CURRENCY_LIST},

2. set propTypes and defaultProps for isLoadingReportData

const defaultProps = {
    personalDetails: {},
    betas: [],
+   isLoadingReportData: true,
    ...policyDefaultProps,
};

const propTypes = {
...
 +  isLoadingReportData: PropTypes.bool,
    ...policyPropTypes,
};

3. add isLoadingReportData as props value

function WorkspaceSettingsCurrencyPage({currencyList, policy, isLoadingReportData}) {

4. add isLoadingReportData to show FullPageNotFoundView

shouldShow={((_.isEmpty(policy) || !PolicyUtils.isPolicyAdmin(policy)) && !isLoadingReportData) || PolicyUtils.isPendingDeletePolicy(policy)}

App/src/pages/workspace/WorkspaceSettingsCurrencyPage.js

Line 82 in 279ce1b

shouldShow={_.isEmpty(policy) || !PolicyUtils.isPolicyAdmin(policy) || PolicyUtils.isPendingDeletePolicy(policy)}

What alternative solutions did you explore? (Optional)

[melvin-bot]

@twisterdotcom, @situchan Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[twisterdotcom]

@situchan any thoughts on these?

[melvin-bot]

@twisterdotcom, @situchan Whoops! This issue is 2 days overdue. Let's get this updated quick!

[situchan]

reviewing today

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[situchan]

"Not found" issue was fixed in #29842 but this page still has issue.
So it's not automatically scrolled and highlighted on selected currency.
@twisterdotcom can this be fixed here? I think no one will create separate bug report for this.

Screen.Recording.2023-10-24.at.5.57.43.PM.mov

[abzokhattab]

Hey @situchan

the accepted proposal was updated to cover the currency page after this issue was open

The referenced issue was related to the invite page, not the currency page

Please re-state the problem that we are trying to solve in this issue.
Accessing invite members link of a deleted workspace shows the invite page briefly before showing not found page

is that allowed?

[situchan]

@abzokhattab any reason for not allowing that?

[abzokhattab]

• I mean the proposal was updated after the current issue was added. so the contributor was not aware of the currency page till my issue/proposal was added. you can notice the difference between the last edits is 3 weeks
• and the mentioned problem/root cause is related to the invitation page Accessing invite members link of a deleted workspace shows the invite page briefly before showing not found page its not related to the currency page, they are two diff issues,

[twisterdotcom]

@situchan yes, I still think we can bend it and fix it here. @abzokhattab I don't think there was anything malicious in updating the solution to later include other pages this would resolve for. It's extra detail.

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[abzokhattab]

@twisterdotcom Okay, i just wanted to defend my point of view, but no problem :D lets move forward.

[mkhutornyi]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Not scrolled and highlighted to selected currency when first open workspace currency page while currencyList is loading

What is the root cause of that problem?

initiallyFocusedOptionKey is undefined so focusedIndex is set to -1 first time.
After initiallyFocusedOptionKey value is set, there's no logic of updating focusedIndex to the correct value in BaseSelectionList.

Also, SectionList is rendered before loading data and scrollToFocusedIndexOnFirstRender is called on onLayout callback.
So even after updating focusedIndex, no way to call scroll function.

What changes do you think we should make in order to solve the problem?

• add useEffect to set focusedIndex when initiallyFocusedOptionKey is changed

useEffect(() => {
    if (firstLayoutRef.current) setFocusedIndex(...)
}, [initiallyFocusedOptionKey])

• pass showLoadingPlaceholder={true} to SelectionList so that SectionList is rendered only after currencyList is loaded

What alternative solutions did you explore? (Optional)

Show skeleton instead of full screen loading even before loading report data.
For this, we can introduce new isLoading prop in BaseSelectionList similar to BaseOptionsList and pass it true when isLoadingReportData = true and policy is empty
And remove withPolicyAndFullscreenLoading HOC

[melvin-bot]

@twisterdotcom @situchan this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

@twisterdotcom, @situchan Whoops! This issue is 2 days overdue. Let's get this updated quick!

[situchan]

@mkhutornyi's proposal looks good to me.
I think it's better to show skeleton before fetching report and it's consistent with Report screen.
🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @flodnv, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

❌ There was an error making the offer to @situchan for the Reviewer role. The BZ member will need to manually hire the contributor.

[melvin-bot]

❌ There was an error making the offer to @mkhutornyi for the Contributor role. The BZ member will need to manually hire the contributor.

[melvin-bot]

❌ There was an error making the offer to @abzokhattab for the Reporter role. The BZ member will need to manually hire the contributor.

[mkhutornyi]

There's bug on latest main. I commented on offending PR - #30438 (comment).
I think we should hold until they fix that regression as it blocks testing our fix.

[mvtglobally]

Issue not reproducible during KI retests. (Second week)

[melvin-bot]

@flodnv, @twisterdotcom, @mkhutornyi, @situchan Huh... This is 4 days overdue. Who can take care of this?

[situchan]

Still holding for #29080

[flodnv]

Issue not reproducible during KI retests. (Second week)

I missed this... we can't repro this anymore?

[situchan]

@flodnv Here's context
And confirmation: #29646 (comment)

[twisterdotcom]

Let's downgrade this given it's held.

[flodnv]

Please reopen if it's still reproducible.

[mkhutornyi]

Can this be reopened similar to #23658 (comment)?
This bug is still reproducible but we're just waiting for #29080 to fix regression.