[HOLD for payment 2023-12-08] [$500] Distance - Prevent deleting receipt

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.3.84-6

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Expensify/Expensify Issue URL: Applause - Internal Team

Issue reported by: Applause - Internal Team

Slack conversation:

Action Performed:

1. Go to staging.new.expensify.com
2. Go to + > Request money > Distance
3. Create a distance request to the workspace chat
4. Click on the distance request preview twice
5. Click on the receipt > Three-dot menu > Delete receipt > Delete
6. Click on Distance
7. Add a more stop and Save it

Expected Result:

The new distance is saved

New: You should not be able to remove the distance receipt in the first place

Actual Result:

The new distance is not saved. Clicking on Save does not save it and close the edit page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Bug6239133_1697466370603.20231016_205452.mp4

MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~019e0aeb0e907b54cf
• Upwork Job ID: 1715165699664687104
• Last Price Increase: 2023-11-22
• Automatic offers:
• dukenv0307 | Contributor | 27853396

[melvin-bot]

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[alitoshmatov]

Looks like receipt is required to edit distance request.

Backend is sending error saying that receipt is not found

I think expected result should be sorted out before proceeding: Should distance request be allowed to be edited if its receipt is deleted?

[dummy-1111]

This looks like a backend issue
The backend returns 404 as below

[honnamkuan]

Seems like a backend issue, I think ideally when receipt is not available during distance request update, backend should generate a new receipt based on newly selected waypoints.

[stephanieelliott]

Ok, thanks! Adding labels to assign an internal engineer for BE changes.

[melvin-bot]

Triggered auto assignment to @danieldoglas (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~019e0aeb0e907b54cf

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @Santhosh-Sellavel (Internal)

[melvin-bot]

@danieldoglas, @stephanieelliott, @Santhosh-Sellavel Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[danieldoglas]

adding @thienlnam since he was part of the core team for this!

[thienlnam]

After an internal discussion, https://expensify.slack.com/archives/C05DWUDHVK7/p1698085763744569

The expected functionality is that you should not be able to remove the distance map receipt. That part will also require FE updates and BE updates

[alitoshmatov]

I can apply frontend changes if external contributor needed

I would apply additional !TransactionUtils.isDistanceRequest(props.transaction) check here, so that only non-distance receipts could be deleted:

App/src/components/AttachmentModal.js

Line 379 in 5ad3372

if (TransactionUtils.hasReceipt(props.transaction) && !TransactionUtils.isReceiptBeingScanned(props.transaction) && !isSettled) {

[melvin-bot]

📣 @dukenv0307 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[dukenv0307]

@thienlnam @Santhosh-Sellavel A bit curious about the replace receipt option

The user can still replace the receipt with the uploaded image. In this case, do you guys want to display delete option ?

[dukenv0307]

@Santhosh-Sellavel The PR is ready for review.

[thienlnam]

The user can still replace the receipt with the uploaded image. In this case, do you guys want to display delete option ?

Yeah we don't want to allow replacing the receipt either - We'll also need to make BE changes for this but for now can you hide the option in the FE (both delete and replace)?

[dukenv0307]

@thienlnam Already hides both options in the PR.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.6-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Prevent deleting and replacing receipt in distance request #32092

If no regressions arise, payment will be issued on 2023-12-08. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @Santhosh-Sellavel does not require payment (Eligible for Manual Requests)
• @dukenv0307 requires payment offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@Santhosh-Sellavel] The PR that introduced the bug has been identified. Link to the PR:
• [@Santhosh-Sellavel] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@Santhosh-Sellavel] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@Santhosh-Sellavel] Determine if we should create a regression test for this bug.
• [@Santhosh-Sellavel] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@stephanieelliott] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[stephanieelliott]

Summarizing payment on this issue:

• Issue reporter: N/A
• Contributor: $500 @dukenv0307 PAID via Upwork
• Contributor+: $500, @Santhosh-Sellavel please request via NewDot!
  Upwork job is here

[Santhosh-Sellavel]

Regression Steps should be enough here because the behavior was intentional earlier when it was added. Let me know your thoughts @thienlnam

Steps

1. Create a distance request
2. After the request is created, go to the transaction thread report
3. Click on the receipt image
4. Click on the three-dot in the attachment modal
5. Verify that only the download option appears

[stephanieelliott]

Issue for QA test here: https://github.com/Expensify/Expensify/issues/349090

All clear here, @Santhosh-Sellavel please request your payment via newdot!

[Santhosh-Sellavel]

Requested on ND

[JmillsExpensify]

$500 payment approved for @Santhosh-Sellavel based on this comment.