[HOLD for payment 2024-01-03] Comment doesn't update to the Merchant name in the split preview component after the receipt scan completes

[trjExpensify]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v1.3.84-4
Reproducible in staging?: Yes
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @trjExpensify
Slack conversation: (internal ref) https://expensify.slack.com/archives/C02NZ2HGJAZ/p1697490579346919?thread_ts=1697488517.137999&cid=C02NZ2HGJAZ

Action Performed:

1. Global create > Request money > scan a receipt
2. Select 2 participants to split > add a description on the confirmation page > confirm
3. Wait for receipt scanning to complete
4. Observe the split preview component in the groupDM contains the comment
5. Observe the iouReport preview component in each of the DM's between payer:participant contains the merchant

Expected Result:

When the receipt scanning completes, the split preview component should update with the merchant name

Actual Result:

When the receipt scanning completes, the split preview component remains as the description

Workaround:

N/A

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01c51bbff62b3a32f7
• Upwork Job ID: 1714065110591516672
• Last Price Increase: 2023-10-16

[melvin-bot]

Current assignee @youssef-lr is eligible for the Engineering assigner, not assigning anyone new.

[melvin-bot]

Current assignee @trjExpensify is eligible for the Bug assigner, not assigning anyone new.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01c51bbff62b3a32f7

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @robertKozik (Internal)

[trjExpensify]

👋 @youssef-lr keeping this one internal and assigned to us for the time being. Maybe the work with the empty merchant has caught this one, but logging it so we have it if not.

[youssef-lr]

Working on this tomorrow.

[melvin-bot]

@youssef-lr, @trjExpensify, @robertKozik Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[trjExpensify]

Same, same.. did we get a PR for this one?

[melvin-bot]

@youssef-lr, @trjExpensify, @robertKozik Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[trjExpensify]

👋 same question, Melv. @youssef-lr is there a PR to link to for this one yet?

[melvin-bot]

@youssef-lr @trjExpensify @robertKozik this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[youssef-lr]

PR is ready but on HOLD until Web-E deploys!

[trjExpensify]

Putting this back on weekly for Youssef's return.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[youssef-lr]

False alarm Melvin

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.17-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Allow setting merchant for split bill #30721

If no regressions arise, payment will be issued on 2024-01-03. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @robertKozik does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@youssef-lr] The PR that introduced the bug has been identified. Link to the PR:
• [@youssef-lr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@youssef-lr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@robertKozik] Determine if we should create a regression test for this bug.
• [@robertKozik] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[trjExpensify]

I think we're good to close this as @robertKozik payment will be handled elsewhere. Regression test for this should be covered in https://github.com/Expensify/Expensify/issues/356417 holistically.

[aimane-chnaif]

@trjExpensify I was C+ reviewer in PR

[trjExpensify]

Oh! Sorry, I thought that was the other one!

[trjExpensify]

So @aimane-chnaif you're due $500 for the C+ review?

[aimane-chnaif]

So @aimane-chnaif you're due $500 for the C+ review?

yes

[trjExpensify]

Cool, offer sent.

[trjExpensify]

Paid!