[HOLD for payment 2023-10-25] [HOLD for payment 2023-10-24] Login - User is not automatically logged in with magic link in different tab

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.3.85-0

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

Action Performed:

1. Go to https://staging.new.expensify.com./
2. Enter any email you have access to
3. Go to email inbox and look for the magic link
4. Go to different tab, change the link to staging and go to it
5. Abracadabra page should be displayed
6. Go to original tab

Expected Result:

User should be automatically logged in and able to use the app on the original tab

Actual Result:

User must refresh the page to appear logged in and use the app

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Bug6240754_1697559597054.bandicam_2023-10-16_23-47-40-706.mp4

MacOS: Desktop

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @thienlnam (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[francoisl]

This pull request just made it to staging and modified some sign-in logic. Not sure yet if it's the culprit but sounds like a possibility.
cc @NikkiWines @MonilBhavsar if you're around and have an idea.

[francoisl]

I reverted 28372 on dev and can still reproduce the issue, so I don't think it's that.

[thienlnam]

:hmm: If it's not that, it probably is related to some subscriber on the login page that is no longer prompting a refresh. I am looking at changes on that page but not seeing anything obvious

[alitoshmatov]

This issue is originating from this line:

App/src/libs/Navigation/AppNavigator/AuthScreens.js

Lines 370 to 372 in 0a3ce76

	demoInfo: {
	key: ONYXKEYS.DEMO_INFO,
	},

If we remove retrieving demoInfo the issue won't happen. But I couldn't find why this is happening, I thought it was because we are accessing onyx data which is not present, but changing key here to any random string did not produce this issue. So the issue is only happening for demoInfo

Hope it helps

[francoisl]

Yeah thanks. Just finished a git bisect and found that the issue comes from this PR, specifically this commit, which matches what you found.

cc @Beamanator

[francoisl]

@s77rt do you have any idea off the top of your head? This appears to be coming from #29288.

[s77rt]

Hmm, we used same patterns for similar temporary flows. Could it be related to this https://github.com/Expensify/App/pull/29288/files#r1358416934? Can you try use Navigation.isNavigationReady promise and see if that fixes it?

cc @alitoshmatov if you are available to test

[alitoshmatov]

Doing this didn't work

cc: @s77rt

[francoisl]

I feel like it's some sort of race condition with updating a key in Onyx? Commenting this line out solves the issue.

[alitoshmatov]

Removing that line looks reasonable and is not effecting expected behavior, and it tests well.

[francoisl]

Alternatively changing it to Onyx.set(ONYXKEYS.DEMO_INFO, {}); seems to work, but I can't 100% confirm at the moment as my dev environment is in a weird half-broken state. Might be better than removing the line entirely, if we can confirm it works.

[alitoshmatov]

It is working.
https://github.com/Expensify/App/assets/59907218/069cc554-c963-4b43-9ba5-5985735f863c

[francoisl]

Nice. @thienlnam let's roll with that?

[francoisl]

I fixed my dev environment, sending a PR shortly.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.85-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Fix signin in via Abracadabra tab #29831

If no regressions arise, payment will be issued on 2023-10-24. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@francoisl / @thienlnam] The PR that introduced the bug has been identified. Link to the PR:
• [@francoisl / @thienlnam] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@francoisl / @thienlnam] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@francoisl / @thienlnam] Determine if we should create a regression test for this bug.
• [@francoisl / @thienlnam] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@zanyrenney] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[Beamanator]

Oof thanks for fixing, y'all 🙈

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.86-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Fix signin in via Abracadabra tab #29831

If no regressions arise, payment will be issued on 2023-10-25. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@francoisl / @thienlnam] The PR that introduced the bug has been identified. Link to the PR:
• [@francoisl / @thienlnam] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@francoisl / @thienlnam] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@francoisl / @thienlnam] Determine if we should create a regression test for this bug.
• [@francoisl / @thienlnam] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@zanyrenney] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[zanyrenney]

Should be all good here as the payment is being handled here, all other assignees here are internal - #29577 !