Deploy Checklist: New Expensify 2023-10-17

[OSBotify]

Release Version: 1.3.86-5
Compare Changes: production...staging

This release contains changes from the following pull requests:

• Some initial fixes and code style updates #1
• Search throttle for emoji picker web #23846
• Refactor DatePicker component for ios #24528
• Feature/add assigned card tile and display expensify cards #26862
• [No QA][TS migration] Migrate 'Timing.js' lib to TypeScript #27705
• [No QA] [TS migration] Migrate 'localFileDownload' lib to TypeScript  #27857
• [No QA][TS migration] Migrate 'API.js' & 'Middleware' & 'Authentication.js' & 'Network' lib to TypeScript #28031
• [No QA] [TS migration] Migrate 'Performance.js' lib to TypeScript #28271
• [TS migration] Migrate 'BankAccounts.js' lib to TypeScript #28316
• [Deleted message] in LHN subtitle #28364
• [SAML NewDot] Add SAML flow for web, mweb, desktop #28372
• [No QA] [TS migration] Migrate 'SignInRedirect.js' lib to TypeScript #28388
• Fix: Chat - Pasted text reflects Full Display name  #28561
• Fix splash screen logo size jump on Samsung OneUI v4 #28644
• fix: auto focus and scroll to bottom on large-text in composer #28790
• Fix/28324 : App keeps both right click LHN popup and delete message popup open together #28846
• Fix/28347 Navaigate back when reloading in scan receipt  #28893
• Bump Onyx to 1.0.100 #28894
• Make Bun compatible #28900
• The "Copy URL to clipboard" tooltip does not appear when hovering over a task description link #28951
• fix: fix transitioning issue from old dot #28984
• Create Set-Up-the-Card-for-Your-Company.md #28990
• Refactor Hoverable component into functional #29052
• Feat: Remove moment from datepicker #29062
• Rename Send message to Start chat #29065
• [No QA][TS migration] Migrate useWindowDimensions #29094
• exclude reports in LHN that has no report type #29155
• [TS migration] Migrate 'useNetwork.js' hook to TypeScript (with createOnyxContext, OnyxProvider, ComposeProviders) #29209
• fix: Chat - App closes mention suggestions when cursor is between double @ #29239
• Create Hosting repository for help.expensify.com support files #29242
• [NO QA] Add comment clarifying "Chats" translation #29249
• [#16935] Workspace creation with Policy Draft info #29256
• prevent optimisticID creation for a user already existing in personal details #29279
• [Money2020] Adding in activation flow for money20/20 #29288
• Fix unread marker showing double lines on task comment #29314
• fix: 28841 keyboard opens for a second when user switches to password protected PDF #29331
• optionslist-to-selectionslist #29337
• Rename Xero to Xero.md #29385
• Update Third-Party-Payments.md #29396
• webfix/27090 In Header Workspace, members are not shown. #29420
• Workspace admin checkbox #29422
• fix: reduce rerendering of EmojiPickerMenu when hovering #29423
• fix: Cursor freeze on paste emoji in edit message #29448
• Remove 'withNavigationFallback.js' HOC #29449
• Go to to invite page when draft invite message is empty #29463
• [Wave 8 - ECard Transactions] Show EReceipts in ReportPreviews and Attachment View #29474
• [NoQA] Feature: IOUTests for submitReport #29476
• Update Pay-Per-Use-Subscription.md #29482
• Update Google-Apps-SSO.md #29487
• Delete docs/articles/expensify-classic/integrations/travel-integratio… #29519
• fix: Emojis, emoji picker icon, and edit icon are disappeared when hovering over notification from completed task #29530
• [HelpDot] article styling improvements #29539
• [NoQA] refactor(28585): perf test for GooglePlacesUtils.getAddressComponents #29545
• Only show Split Bill option in the user's own workspace chat #29551
• [Wave 8 - ECard Transactions] Update Expense Report Total Breakdown  #29566
• Cleanup completing a split bill #29568
• update: expensify-common #29575
• [CP Staging] [No QA] Revert "Add DateTimeFormat polyfill" #29576
• Page is skewed when dragging Scan content to the right #29578
• [No QA]Comment out bot messages since e2e are too flaky #29579
• Selected workspace members unselect on switch from offline to online #29587
• Update Sage-Intacct.md #29588
• fix: 404 authenticate pusher api call #29590
• [No QA]Add a check for the new OS Botify App in the deploy process #29592
• fix click room avatar footer #29599
• Fix duplicate offline indicator enable payment  #29600
• Fix no Paste option menu shows when long pressing a text input #29601
• remove console error #29603
• Added location button in address search #29609
• add bottom safe area padding on the EditRequestReceiptPage. #29617
• [CP Staging] Fix for Android crash and not visible labels in Request money  #29629
• [CP Staging] - Only show Pending Banner for ECard Transactions #29659
• fix hovering header menu #29662
• Revert "fix: remove unnecessary dependency" #29663
• [CP Staging] Fix error when keeping default date when splitting #29664
• [CP Staging] fixes max width and pay button for report preview #29666
• Fix shouldUseFullTitle in ReportDetailsPage #29669
• Update Expense-Rules.md #29671
• [CP Staging] Add padding left back to cardMenuItem #29677
• [CP Staging] Redefine useLocalize in SplitDetailsPage #29682
• Format line breaks in split bill description #29693
• [No QA]Upload iOS and Android releases to GitHub artifacts #29698
• Fix - Rate - When Rate is changed in offline mode red dot appear back online #28942 #29700
• [CP Staging] Revert PR 28278 #29706
• Hide suggestions only if we inserted an emoji #29711
• Display company cards #29718
• [NoQA] Add content_rights_has_rights to Fastlane's submission information #29721
• fix: Map initially starts from 'San Francisco' even if waypoints are available. #29724
• Revert "[NoQA] Temporarily update the getPreviousVeriosn to skip over missing tag" #29728
• auto submit magic code during first submit only #29731
• fix underscore not working in emoji suggestions #29794
• Update Business-Bank-Accounts-AUD.md #29800
• Update and rename Deposit-Accounts-AUS.md to Deposit-Accounts-AUD.md #29804
• Delete docs/articles/expensify-classic/bank-accounts-and-credit-cards… #29805
• Revert "webfix/27090 In Header Workspace, members are not shown." #29833
• [CP Staging] Revert "Remove withNavigationFallback.js HOC" #29844
• fix: 29850 IOU-Tapping on distance receipt, the receipt thumbnail is missing in the receipt page #29863
• get image from IOU when there is no source in transaction #29873
• Revert "Feat: Remove moment from datepicker" #29889

Internal QA:

• Allow platinum wallets to transact #29395 - @coleaeason
• feat 22876 allow users to update the card address via update address link #28907 - @MrMuzyk

Deploy Blockers:

• [HOLD for payment 2023-10-25] [HOLD for payment 2023-10-24] [$500] LHN-App crashes on long pressing any report in the LHN #29746
• [HOLD for payment 2023-10-25] [$500] IOU-In distance request, after selecting start waypoint finish section disappears #29748
• [HOLD for payment 2023-10-25] [HOLD for payment 2023-10-24] Login - User is not automatically logged in with magic link in different tab #29807
• [HOLD for payment 2023-10-27] [HOLD for payment 2023-10-25] [$250] Chat - Deleting message in chat causes black screen #29839
• [$500] Web - Login - Error page is displayed after changing the long URL to staging and go to it #29849
• [HOLD for payment 2023-10-27] [HOLD for payment 2023-10-25] [$500] IOU-Tapping on distance receipt, the receipt thumbnail is missing in the receipt page #29850
• [$500] WS - Track distance rate is updated on device B even if device A was offline. No error message. #29853
• [HOLD for payment 2023-10-27][$500] Manual - Attachment placeholder is shown in preview instead of receipt after adding a receipt #29855
• Chat - Selected receipt date is changed to priviuse date #29862
• The receipt image is not displaying on the confirmation modal #29864
• [$500] IOU - When we change category of manual request, a small shake can be seen #29877
• The highlighted mention does not change with the cursor movement #29884
• Chat - Can't delete a message using the right click menu with Delete CTA unresponsive #29918

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
• I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

[francoisl]

Going to clean up the dupes again 😒

Details

https://github.com/Expensify/App/pull/24528
https://github.com/Expensify/App/pull/26862
https://github.com/Expensify/App/pull/27705
https://github.com/Expensify/App/pull/27857
https://github.com/Expensify/App/pull/28271
https://github.com/Expensify/App/pull/28316
https://github.com/Expensify/App/pull/28372
https://github.com/Expensify/App/pull/28644
https://github.com/Expensify/App/pull/28846
https://github.com/Expensify/App/pull/28894
https://github.com/Expensify/App/pull/28900
https://github.com/Expensify/App/pull/28990
https://github.com/Expensify/App/pull/29065
https://github.com/Expensify/App/pull/29242
https://github.com/Expensify/App/pull/29256
https://github.com/Expensify/App/pull/29279
https://github.com/Expensify/App/pull/29288
https://github.com/Expensify/App/pull/29331
https://github.com/Expensify/App/pull/29337
https://github.com/Expensify/App/pull/29385
https://github.com/Expensify/App/pull/29396
https://github.com/Expensify/App/pull/29422
https://github.com/Expensify/App/pull/29423
https://github.com/Expensify/App/pull/29448
https://github.com/Expensify/App/pull/29482
https://github.com/Expensify/App/pull/29530
https://github.com/Expensify/App/pull/29545
https://github.com/Expensify/App/pull/29551
https://github.com/Expensify/App/pull/29568
https://github.com/Expensify/App/pull/29575
https://github.com/Expensify/App/pull/29578
https://github.com/Expensify/App/pull/29579
https://github.com/Expensify/App/pull/29588
https://github.com/Expensify/App/pull/29590
https://github.com/Expensify/App/pull/29592
https://github.com/Expensify/App/pull/29599
https://github.com/Expensify/App/pull/29600
https://github.com/Expensify/App/pull/29603
https://github.com/Expensify/App/pull/29617
https://github.com/Expensify/App/pull/29662
https://github.com/Expensify/App/pull/29671

[kavimuru]

Checkigng off #29629, #29659, #29677, #29682 from past build

[OSBotify]

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.3.86-0 🚀

[kavimuru]

@francoisl Regression is 67% progress. We are still validating couple PRs.
#28364 failing with #29839
#29420 failing with #27090 in Android and iOS
#28984 failing with #29849

[kavimuru]

Regression is only 9% left.
#28364 failing with #29839
#29420 failing with #27090 in Android and iOS (Not fixed)
#28984 failing with #29849

[francoisl]

Thanks for the update. We're working on the remaining blockers.

---

• 29877: checking off, blocker label removed
• 29395 QA'ed internally, checking
• 29849: checking off, blocker label removed
• 29850: tested internally, checking
• 29855: tested internally, checking
• 29884: explained as not an issue, removing blocker label
• 29853: edge case not worth blocking for
• 29839: fix tested on staging, checking off
• 29889: fix tested on staging, checking 29062

[francoisl]

We're down to 1 blocker, a fix is being CP'ed right now. I'll test it when it's finished and close this if everything is good.

[kavimuru]

#29844 is failing with blocker #29918

[francoisl]

Going to remove the blocker label #29918 as explained here, reverting the PR that caused it would reintroduce another crash. It's also seemingly fixed on main already, and it's also still possible to delete messages by clicking the trash icon.

[francoisl]