fix: fix transitioning issue from old dot #28984

koko57 · 2023-10-06T08:07:25Z

Details

Fixed Issues

$ #27418
PROPOSAL: #27418 (comment)

Tests

Log in to expensify.com with one of your accounts (account A).
Log in to the new app with another account (account B).
On expensify.com go to Support and choose Concierge.
A new tab will open, when a long URL with transition and token appear, quickly copy it. *
Open a new tab (or in a tab with the app running) paste the address and change 'https://new.expensify.com' for 'http://localhost:8082' [or any port your app is running] *
Verify that user is properly logged in to the account A and the sidebar with chat and main screen are not empty.

steps required for testing locally

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Log in to expensify.com with one of your accounts (account A).
Log in to the new app with another account (account B).
On expensify.com go to Support and choose Concierge.
A new tab will open, when a long URL with transition and token appear, quickly copy it. *
Open a new tab (or in a tab with the app running) paste the address and change 'https://new.expensify.com' for 'http://localhost:8082' [or any port your app is running] *
Verify that user is properly logged in to the account A and the sidebar with chat and main screen are not empty.

steps required for testing locally

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-10-06.at.15.48.45.mp4

Mobile Web - Chrome

N/A

Mobile Web - Safari

N/A

Desktop

N/A

iOS

N/A

Android

N/A

src/pages/LogOutPreviousUserPage.js

src/libs/Navigation/AppNavigator/AuthScreens.js

melvin-bot · 2023-10-09T08:29:57Z

@allroundexperts Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

allroundexperts · 2023-10-09T08:31:11Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

allroundexperts · 2023-10-09T20:37:09Z

Bug
Having multiple tabs opened causes one tab to crash.

Screen.Recording.2023-10-10.at.1.34.01.AM.mov

koko57 · 2023-10-10T07:20:54Z

@allroundexperts it didn't happen before the changes?

koko57 · 2023-10-10T07:37:06Z

@allroundexperts I've checked it - it also happened before on main. So my changes didn't introduce the issue.
https://github.com/Expensify/App/assets/28020445/1f9eb244-e506-4e24-bf09-96e83881d87a

@mountiny @allroundexperts I'm not sure if this should be fixed here or should be done as a follow-up issue?

allroundexperts · 2023-10-10T11:24:30Z

@koko57 Sounds good. I'll ignore this!

koko57 · 2023-10-10T11:26:11Z

@allroundexperts but I think we have to wait for this one #26530

allroundexperts · 2023-10-10T11:46:05Z

Ah. Sorry, I'm confused @koko57. Why should we wait on that? Can you please explain briefly? Thanks!

koko57 · 2023-10-10T12:09:53Z

@allroundexperts The issue and the solution proposed in this issue are pretty similar to the one that I proposed. I just found this issue accidentally after I made a PR here. But the PR from this other issue was made earlier. My approach is slightly different though, and we also need to check if it solves this other problem, although I think it does and testing locally it works fine for me.

mountiny · 2023-10-10T13:32:55Z

I think the tab crashing is on main yeah

burczu · 2023-10-16T10:58:51Z

@vit @allroundexperts I came from #26530 - In my opinion the solution implemented by this PR fixes both issues, the only concern that @sourcecodedeveloper (author of the other solution) has, is that it breaks deeplinking, but I'm not sure it's the case here. In fact, with the solution from this PR, if we paste the /transition&... link in the chat and then click it the app stuck showing spinner, but I can't believe it's a real life scenario and I'm not sure if we want to handle such cases. What do you think?

cc: @koko57

mountiny · 2023-10-16T13:11:59Z

@allroundexperts could we resume the checklist on this one please

koko57 · 2023-10-16T13:21:51Z

@allroundexperts @mountiny I'll merge with the newest main

MonilBhavsar · 2023-10-16T15:45:45Z

@koko57 coming from this PR/issue #28372 where transition from oldDot endpoint shows infinite spinner. We believe the issue will fixed by this PR. Are we expecting some more additions to this PR? Looks like current state is not fixing the issue cc @NikkiWines

koko57 · 2023-10-16T17:29:34Z

@MonilBhavsar could you please tell me a little bit more what's happening there? What are the exact steps to reproduce to get a loading spinner?

I've found the fix for the spinner issue that @sourcecodedeveloper mentioned but as it didn't happen on main I guess that it's a different scenario.

NikkiWines · 2023-10-17T01:23:56Z

@MonilBhavsar could you please tell me a little bit more what's happening there? What are the exact steps to reproduce to get a loading spinner?

Not @MonilBhavsar, but the issue is reproducible by logging into expensify.com and clicking the green chat bubble icon on the Inbox page, which redirects you to New Expensify.

koko57 · 2023-10-17T06:28:17Z

@NikkiWines Thanks for the response! Yeah, looks fixed now

Screen.Recording.2023-10-17.at.08.23.24.mp4

koko57 · 2023-10-17T12:09:17Z

@allroundexperts I think it's ready for re-review 🙂

mountiny

One NAB @koko57

mountiny · 2023-10-17T12:34:33Z

src/libs/Navigation/AppNavigator/AuthScreens.js

+ const currentUrl = getCurrentUrl();
+
+ const isLoggingInAsNewUser = SessionUtils.isLoggingInAsNewUser(currentUrl, this.props.session.email);


Suggested change

const currentUrl = getCurrentUrl();

const isLoggingInAsNewUser = SessionUtils.isLoggingInAsNewUser(currentUrl, this.props.session.email);

const currentUrl = getCurrentUrl();

const isLoggingInAsNewUser = SessionUtils.isLoggingInAsNewUser(currentUrl, this.props.session.email);

@mountiny done 😃

mountiny

THis works for me locally with my VM but also noticed that it crashes in the other tab. I dont think that is a blocker but I swear we had fix for this in place
https://github.com/Expensify/App/assets/36083550/05210e1e-042d-4385-8e4e-35c114c3a231

mountiny · 2023-10-17T19:01:44Z

Updated the checklist from @allroundexperts and moving this ahead

OSBotify · 2023-10-17T19:08:42Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-10-17T23:56:36Z

🚀 Deployed to staging by https://github.com/mountiny in version: 1.3.86-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

koko57 · 2023-10-18T12:52:58Z

@mountiny on these crashes - Ana was working on a quite similar issue #15321 I think that her PR may solve this issue #15321

mountiny · 2023-10-18T12:54:26Z

This PR right? Expensify/react-native-onyx#382 anyone able to take it over?

koko57 · 2023-10-18T12:55:53Z

I can take it over, or someone from our team can 🙂

OSBotify · 2023-10-18T23:54:06Z

🚀 Deployed to production by https://github.com/francoisl in version: 1.3.86-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

fix: fix transitioning issue from old dot

bfba944

BeeMargarida reviewed Oct 6, 2023

View reviewed changes

src/pages/LogOutPreviousUserPage.js Outdated Show resolved Hide resolved

koko57 added 2 commits October 6, 2023 10:19

fix: apply requested changes

e8deb03

fix: fix failing tests

4e2d243

BeeMargarida reviewed Oct 6, 2023

View reviewed changes

src/libs/Navigation/AppNavigator/AuthScreens.js Outdated Show resolved Hide resolved

koko57 added 3 commits October 6, 2023 12:24

fix: minor fix

b230ba1

fix: minor fix

05fd6fa

fix: run prettier

e06a7ba

BeeMargarida approved these changes Oct 6, 2023

View reviewed changes

Merge branch 'main' into fix/27418-transition-from-olddot-to-newdot

6286e0c

mountiny assigned koko57 Oct 6, 2023

adhorodyski approved these changes Oct 9, 2023

View reviewed changes

chore: merge main

3d1b55c

koko57 marked this pull request as ready for review October 9, 2023 08:29

koko57 requested a review from a team as a code owner October 9, 2023 08:29

melvin-bot bot requested review from allroundexperts and removed request for a team October 9, 2023 08:29

koko57 mentioned this pull request Oct 9, 2023

[HOLD for payment 2023-10-20] [$250] OldDot Transition - Opening free policy from OD with another user logged to ND opens blank page #26530

Closed

6 tasks

koko57 added 2 commits October 12, 2023 10:14

Merge branch 'main' into fix/27418-transition-from-olddot-to-newdot

8c8cef0

Merge branch 'main' into fix/27418-transition-from-olddot-to-newdot

fd327e2

koko57 mentioned this pull request Oct 16, 2023

[$250] Desktop - App Redirection - Blank page is displayed when opening a deep link for Account B profile #28717

Closed

6 tasks

Merge branch 'main' into fix/27418-transition-from-olddot-to-newdot

eba5f0b

MonilBhavsar mentioned this pull request Oct 16, 2023

[SAML NewDot] Add SAML flow for web, mweb, desktop #28372

Merged

58 tasks

fix: restore logging out logic to fix a spinner issue

12ecca0

mountiny previously approved these changes Oct 17, 2023

View reviewed changes

fix: apply requested changes

483eb68

koko57 dismissed mountiny’s stale review via 483eb68 October 17, 2023 13:05

mountiny approved these changes Oct 17, 2023

View reviewed changes

mountiny merged commit 3fdc062 into Expensify:main Oct 17, 2023
13 of 15 checks passed

OSBotify mentioned this pull request Oct 17, 2023

Deploy Checklist: New Expensify 2023-10-17 #29837

Closed

hungvu193 mentioned this pull request Oct 18, 2023

[$500] Web - Login - Error page is displayed after changing the long URL to staging and go to it #29849

Closed

6 tasks

melvin-bot bot mentioned this pull request Oct 18, 2023

[HOLD for payment 2023-10-25] Transition from OldDot to NewDot is slow and shows blank screen for long time #27418

Closed

koko57 mentioned this pull request Nov 20, 2023

[CP Staging] Prevent infinite spinner in transition page #31522

Merged

47 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: fix transitioning issue from old dot #28984

fix: fix transitioning issue from old dot #28984

koko57 commented Oct 6, 2023 •

edited

Loading

melvin-bot bot commented Oct 9, 2023

allroundexperts commented Oct 9, 2023 •

edited by mountiny

Loading

allroundexperts commented Oct 9, 2023

koko57 commented Oct 10, 2023

koko57 commented Oct 10, 2023

allroundexperts commented Oct 10, 2023

koko57 commented Oct 10, 2023

allroundexperts commented Oct 10, 2023

koko57 commented Oct 10, 2023 •

edited

Loading

mountiny commented Oct 10, 2023

burczu commented Oct 16, 2023 •

edited

Loading

mountiny commented Oct 16, 2023

koko57 commented Oct 16, 2023

MonilBhavsar commented Oct 16, 2023

koko57 commented Oct 16, 2023 •

edited

Loading

NikkiWines commented Oct 17, 2023

koko57 commented Oct 17, 2023

koko57 commented Oct 17, 2023

mountiny left a comment

mountiny Oct 17, 2023

koko57 Oct 17, 2023

mountiny left a comment

mountiny commented Oct 17, 2023

OSBotify commented Oct 17, 2023

OSBotify commented Oct 17, 2023

koko57 commented Oct 18, 2023

mountiny commented Oct 18, 2023

koko57 commented Oct 18, 2023

OSBotify commented Oct 18, 2023

		const currentUrl = getCurrentUrl();

		const isLoggingInAsNewUser = SessionUtils.isLoggingInAsNewUser(currentUrl, this.props.session.email);

fix: fix transitioning issue from old dot #28984

fix: fix transitioning issue from old dot #28984

Conversation

koko57 commented Oct 6, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Oct 9, 2023

allroundexperts commented Oct 9, 2023 • edited by mountiny Loading

Reviewer Checklist

Screenshots/Videos

allroundexperts commented Oct 9, 2023

koko57 commented Oct 10, 2023

koko57 commented Oct 10, 2023

allroundexperts commented Oct 10, 2023

koko57 commented Oct 10, 2023

allroundexperts commented Oct 10, 2023

koko57 commented Oct 10, 2023 • edited Loading

mountiny commented Oct 10, 2023

burczu commented Oct 16, 2023 • edited Loading

mountiny commented Oct 16, 2023

koko57 commented Oct 16, 2023

MonilBhavsar commented Oct 16, 2023

koko57 commented Oct 16, 2023 • edited Loading

NikkiWines commented Oct 17, 2023

koko57 commented Oct 17, 2023

koko57 commented Oct 17, 2023

mountiny left a comment

Choose a reason for hiding this comment

mountiny Oct 17, 2023

Choose a reason for hiding this comment

koko57 Oct 17, 2023

Choose a reason for hiding this comment

mountiny left a comment

Choose a reason for hiding this comment

mountiny commented Oct 17, 2023

OSBotify commented Oct 17, 2023

OSBotify commented Oct 17, 2023

koko57 commented Oct 18, 2023

mountiny commented Oct 18, 2023

koko57 commented Oct 18, 2023

OSBotify commented Oct 18, 2023

koko57 commented Oct 6, 2023 •

edited

Loading

allroundexperts commented Oct 9, 2023 •

edited by mountiny

Loading

koko57 commented Oct 10, 2023 •

edited

Loading

burczu commented Oct 16, 2023 •

edited

Loading

koko57 commented Oct 16, 2023 •

edited

Loading