[HOLD for payment 2023-10-25] Transition from OldDot to NewDot is slow and shows blank screen for long time

[mountiny]

### Problem

Coming from https://expensify.slack.com/archives/C05LX9D6E07/p1694668433572469?thread_ts=1694666491.998029&cid=C05LX9D6E07

When a new lead user signs up on OldDot and they want to chat with their setup specialist in NewDot, we use a transition to new.expensify.com to keep their session going in this new app.

However, this transition seems to got very slow now and blank page is shown for over 15 seconds which is terrible UX.

Seems like the issue is that on a first load we dont have proper data to show the reports

after refreshing it works fine

Solution

Investigate why the onyx data is not correctly loaded upon making the transition and fix it

cc @staszekscp @koko57

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01c534f630f870f749
• Upwork Job ID: 1709570879512326144
• Last Price Increase: 2023-10-04

Issue Owner

Current Issue Owner: @dylanexpensify

[melvin-bot]

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[koko57]

@mountiny I'm ready to help with this one 🙂

[mountiny]

@koko57 will handle this one for us 🎖️

[koko57]

Daily update: I'm still looking for the root cause, but I've noticed one strange thing - when the transition fails (I was logged in as a user A and wanted to log in as a user B) and I see the green empty screen the reports that are in the Onyx (like in the first screenshot) are the reports that should be displayed for the user A.

The rest of the data like login, contact methods, email, etc are already populated with user B's data. Then after the refresh the reports stay in Onyx unchanged among the reports that should be displayed for the user B

I logged out of both accounts and logged in separately again. For user A I had 185 keys in Onyx and for user B I had 340.
When logged in as user A and trying to transition from the OldDot as a user B, after the failure and then refresh I had 489 keys in Onyx.

[koko57]

I've just found that OpenReport and OpenApp are not called after the user is logged in to another account. I think it can the main problem here why we don't have a proper data to display

[koko57]

Daily update: Although we're navigating to the report screen, report screen doesn't mount.
On OpenApp and OpeReport requests - I tried to force both requests, but it didn't help. I'll continue looking into this issue tomorrow.

[mountiny]

Thanks for the updates

[koko57]

Daily update: (Sorry for not posting yesterday) unfortunately, not much progress here. I'm digging into the logOut - logIn as a new user flow. I've noticed that in this flow we're firing signOut twice: here and here. I wonder whether this flow could be simplified somehow? The ReportScreen is not mounting as well as SidebarLinksData - which is weird bc CentralPaneNavigator and BaseSidebarScreen both are.

[koko57]

Daily update: today I asked Edu for some help, we both think it's possibly a navigation issue. I'll continue investigating it on Monday.

[mountiny]

Investigation continues

[koko57]

Not much progress here. I only discovered that removing this from LogOutPreviousUserPage works but there's a glitch of the old user's chats at the beginning and there is some error in the session object after authenticating. As I've mentioned before we log out the user twice in the current flow. Maybe just simplifying it would fix the issue.

[koko57]

I guess I've finally found the root cause - it's a problem with Onyx. I'm starting working on my proposal.

[mountiny]

Great! Thanks!

[melvin-bot]

@koko57 @mountiny @dylanexpensify this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[koko57]

Working on a proposal, I have one solution on my mind, need to test it thoroughly. 🙂 If everything looks fine, maybe I'll be able to post the proposal tomorrow.

[koko57]

Unfortunately, my solution doesn't work properly, I need to find another one 😞

[koko57]

Came up with another solution, testing it now, but the first results look promising.

[dylanexpensify]

@koko57 mind giving us an update?

[koko57]

PR is still under review

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[koko57]

@mountiny I saw this #29849 and I'm on it. I know what's happening there but I need to find out why (bc it tested well, I wonder if there was some other changes that together with mine might have caused the issue)

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.86-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: fix transitioning issue from old dot #28984

If no regressions arise, payment will be issued on 2023-10-25. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @koko57 does not require payment (Contractor)
• @allroundexperts does not require payment (Eligible for Manual Requests)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@allroundexperts] The PR that introduced the bug has been identified. Link to the PR:
• [@allroundexperts] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@allroundexperts] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@allroundexperts] Determine if we should create a regression test for this bug.
• [@allroundexperts] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@dylanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[dylanexpensify]

payment tomorrow!

[dylanexpensify]

Payment Summary:

• Contributor+: @allroundexperts $500

Please apply!

[dylanexpensify]

@allroundexperts mind completing checklist? 🙇‍♂️

[allroundexperts]

@dylanexpensify I don't think that the checklist is applicable here. This was a performance optimisation PR.

[mountiny]

Agreed, @allroundexperts did you request on newdot? Can we close this issue?

[allroundexperts]

I've noted it @mountiny. We can close.

[JmillsExpensify]

$500 payment approved for @allroundexperts based on this comment.