[HOLD for payment 2023-10-18] [$1000] Chat - Notification is NOT received in the main device after Control policy was created

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Create a new account in New Dot in the testing device, validate it and stay logged in
2. Navigate to another tab and leave the ND tab in the background
3. Navigate to OldDot and login with account from Step 1
4. Create a Control or Collect policy

Expected Result:

Notification is received in the main testing device from the #Admin Room

Actual Result:

Notification is NOT received in the main testing device from the #Admin Room
#admins and #announce chats in ND tab in the background were not created (need a page reload, previously #admins and #announce were created without reload)

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.43.1

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6134592_T3540961_Web_Safari.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01065f736ac1027416
• Upwork Job ID: 1683479352616787968
• Last Price Increase: 2023-08-24
• Automatic offers:
• hungvu193 | Contributor | 26417598

[melvin-bot]

Triggered auto assignment to @NicMendonca (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[hannojg]

This could be a regression from my PR:

• [Fix #21022] Improve performance by reducing re-renders SidebarLinks #21406

looking into it!

[hannojg]

Taking my words back, the bug is reported on staging. The mentioned PR isn't on staging yet, so it can't have caused the issue!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01065f736ac1027416

[melvin-bot]

Current assignee @NicMendonca is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

[NicMendonca]

#21406 (comment) is deployed now FYI

[hannojg]

I can check later today if this PR caused the regression, yes!

[NicMendonca]

@hannojg any update?

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@mananjadhav, @NicMendonca Huh... This is 4 days overdue. Who can take care of this?

[NicMendonca]

We're still waiting for proposals here. I am assuming you haven't found anything @hannojg?

[hannojg]

I haven't checked yet, no. Does anyone else have time to check, super booked right now

[melvin-bot]

@mananjadhav @NicMendonca this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[NicMendonca]

@mananjadhav should we update price on this one?

@lanitochka17 are you still able to reproduce?

[hungvu193]

@hungvu193 Apologies I didn't understand what you mean by getting the link when clicking in OldDot.

I saw 2 issues in the video, the chat rooms didn't sync between page and the notification issues. To test the first issue, I need to get the shortLiveToken when we're being redirected from OldDot.
But if we only want to fix notification issue then I think we can start review the PR and it's ready

[hungvu193]

My concern is now clear, that issue I mentioned is now logged as a separate issue here:
#27418.

#26358 is ready!

[melvin-bot]

This issue has not been updated in over 15 days. @mananjadhav, @danieldoglas, @hungvu193, @NicMendonca eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[melvin-bot]

Based on my calculations, the pull request did not get merged within 3 working days of assignment. Please, check out my computations here:

• when @hungvu193 got assigned: 2023-08-30 18:24:43 Z
• when the PR got merged: 2023-10-09 17:47:17 UTC
• days elapsed: 27

On to the next one 🚀

[mananjadhav]

Thanks @mountiny @hungvu193 for helping on this one.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.80-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix Chat - Notification is NOT received in the main device after Control policy was created #26358

If no regressions arise, payment will be issued on 2023-10-18. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @mananjadhav does not require payment (Eligible for Manual Requests)
• @hungvu193 requires payment offer (Contributor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mananjadhav] The PR that introduced the bug has been identified. Link to the PR:
• [@mananjadhav] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@mananjadhav] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@mananjadhav] Determine if we should create a regression test for this bug.
• [@mananjadhav] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@NicMendonca] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[NicMendonca]

BZ Payment summary:

Reporter: N/A
Contributor: @hungvu193 - $1,000 (paid via Upwork)
Contributor +: @mananjadhav - $1,000 (paid via Expensify)

[NicMendonca]

@mananjadhav bump on the BZ checklist!

[mananjadhav]

I think we already comment on this PR regarding the problematic code. It looks like we've further updated this to getReportName in the main.

This doesn't need any update in the process and neither do we need a regression test here.

[NicMendonca]

Cool! Thanks!

@hungvu193 you've been paid! @mananjadhav don't forget to request payment via Expensify

BZ Payment summary:

Reporter: N/A
Contributor: @hungvu193 - $1,000 (paid via Upwork)
Contributor +: @mananjadhav - $1,000 (paid via Expensify)

[JmillsExpensify]

$1,000 payment approved for @mananjadhav based on summary above.