[No QA] [TS migration] Migrate 'localFileDownload' lib to TypeScript #27857

teneeto · 2023-09-20T12:19:08Z

Details

This change is made to migrate src/libs/localFileDownload/index.js, src/libs/localFileDownload/index.ios.js and src/libs/localFileDownload/index.android.js lib files to TS

Fixed Issues

$: 24886
PROPOSAL: 24886

Tests

Referencing the initial Issue

Goto Settings -> Security
Click/Tap on Two-factor authentication
A list of recovery codes should appear.
Pressing "Download" should download the file locally to the device. On iOS it should open the "Share" menu, enabling the user to save anywhere wanted. On Android, it should download directly to the Downloads folder

Verify that no errors appear in the JS console

Offline tests

Referencing the initial Issue

Goto Settings -> Security
Click/Tap on Two-factor authentication
A list of recovery codes should appear.
Pressing "Download" should download the file locally to the device. On iOS it should open the "Share" menu, enabling the user to save anywhere wanted. On Android, it should download directly to the Downloads folder

QA Steps

Referencing the initial Issue

Goto Settings -> Security
Click/Tap on Two-factor authentication
A list of recovery codes should appear.
Pressing "Download" should download the file locally to the device. On iOS it should open the "Share" menu, enabling the user to save anywhere wanted. On Android, it should download directly to the Downloads folder

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Screen.Recording.2023-10-02.at.07.12.26.mov

Mobile Web - Chrome

Screen.Recording.2023-10-02.at.07.14.15.mov

Mobile Web - Safari

Screen.Recording.2023-10-02.at.07.10.06.mov

Desktop

Screen.Recording.2023-10-02.at.07.06.46.mov

iOS

Screen.Recording.2023-10-02.at.06.24.02.mov

Android

Screen.Recording.2023-10-02.at.07.04.22.mov

src/libs/localFileDownload/types.ts

src/libs/localFileDownload/index.ios.ts

melvin-bot · 2023-10-02T04:49:28Z

@lakchote Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

…al-file-download

blazejkustra · 2023-10-02T14:16:35Z

Just so you know @lakchote, TS process was changed recently and now C+ are responsible for the reviewer checklist.

lakchote · 2023-10-09T13:25:51Z

@blazejkustra @fabioh8010 can one of you complete the reviewer checklist please? Thanks

blazejkustra · 2023-10-09T14:34:15Z

@blazejkustra @fabioh8010 can one of you complete the reviewer checklist please? Thanks

Just so you know @lakchote, TS process was changed recently and now C+ are responsible for the reviewer checklist.

Could you assign a C+ to this PR?

situchan

I can review this

melvin-bot · 2023-10-11T08:19:53Z

🎯 @cubuspl42, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #29265.

cubuspl42 · 2023-10-11T08:22:58Z

@situchan Did the policy change? I blindly approved this, as that was what C+ were supposed to do not so long ago

situchan · 2023-10-11T08:24:57Z

@situchan Did the policy change? I blindly approved this, as that was what C+ were supposed to do not so long ago

yes, please check this discussion you might have missed it

cubuspl42 · 2023-10-11T08:28:34Z

Okey, let me know if my approval screwed the automation; otherwise I'll move away

lakchote · 2023-10-11T08:52:42Z

@cubuspl42 Could you please complete the PR reviewer checklist? Thanks

situchan · 2023-10-11T09:15:36Z

Testing is in progress

cubuspl42 · 2023-10-11T09:16:18Z

@lakchote I missed the change of process as per the discussion. @situchan will be handling things here.

situchan · 2023-10-15T16:25:21Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web.mov

Mobile Web - Chrome

mchrome.mov

Mobile Web - Safari

msafari.mov

Desktop

desktop.mov

iOS

ios.mov

Android

android.mov

melvin-bot · 2023-10-15T16:25:51Z

🎯 @situchan, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #29638.

Beamanator

LGTM

OSBotify · 2023-10-16T06:44:50Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-10-16T21:49:00Z

🚀 Deployed to staging by https://github.com/Beamanator in version: 1.3.85-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-17T23:13:45Z

🚀 Deployed to production by https://github.com/francoisl in version: 1.3.85-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-10-18T00:00:09Z

🚀 Deployed to staging by https://github.com/Beamanator in version: 1.3.86-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-18T23:57:39Z

🚀 Deployed to production by https://github.com/francoisl in version: 1.3.86-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

teneeto added 4 commits September 20, 2023 13:09

ref: moved local file download to TS

88aff92

fix: undo wrongly migrated file download file to TS

61b1e6e

ref: move local file download to TS

7bd5be7

group platform-specific types

1eed015

fabioh8010 reviewed Sep 20, 2023

View reviewed changes

src/libs/localFileDownload/types.ts Show resolved Hide resolved

src/libs/localFileDownload/types.ts Outdated Show resolved Hide resolved

src/libs/localFileDownload/index.ios.ts Outdated Show resolved Hide resolved

resolve review comments

801dddc

fabioh8010 approved these changes Sep 26, 2023

View reviewed changes

teneeto marked this pull request as ready for review October 2, 2023 04:48

teneeto requested a review from a team as a code owner October 2, 2023 04:48

melvin-bot bot requested review from lakchote and removed request for a team October 2, 2023 04:49

Merge branch 'main' of github.com:Expensify/App into ts-migration/loc…

497e6c7

…al-file-download

teneeto marked this pull request as draft October 2, 2023 13:47

blazejkustra approved these changes Oct 2, 2023

View reviewed changes

teneeto marked this pull request as ready for review October 2, 2023 14:38

lakchote approved these changes Oct 3, 2023

View reviewed changes

lakchote requested review from a team and removed request for a team October 11, 2023 08:06

situchan reviewed Oct 11, 2023

View reviewed changes

cubuspl42 approved these changes Oct 11, 2023

View reviewed changes

melvin-bot bot mentioned this pull request Oct 11, 2023

Payment issue for E/App PR#27857 #29265

Closed

situchan approved these changes Oct 15, 2023

View reviewed changes

melvin-bot bot mentioned this pull request Oct 15, 2023

[Awaiting payment 26-10-23][$250] Payment issue for E/App PR#27857 #29638

Closed

Beamanator approved these changes Oct 16, 2023

View reviewed changes

Beamanator merged commit 7791d32 into Expensify:main Oct 16, 2023
15 of 19 checks passed

OSBotify mentioned this pull request Oct 16, 2023

Deploy Checklist: New Expensify 2023-10-16 #29717

Closed

OSBotify mentioned this pull request Oct 17, 2023

Deploy Checklist: New Expensify 2023-10-17 #29837

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[No QA] [TS migration] Migrate 'localFileDownload' lib to TypeScript #27857

[No QA] [TS migration] Migrate 'localFileDownload' lib to TypeScript #27857

teneeto commented Sep 20, 2023 •

edited

Loading

melvin-bot bot commented Oct 2, 2023

blazejkustra commented Oct 2, 2023

lakchote commented Oct 9, 2023

blazejkustra commented Oct 9, 2023 •

edited

Loading

situchan left a comment

melvin-bot bot commented Oct 11, 2023

cubuspl42 commented Oct 11, 2023

situchan commented Oct 11, 2023

cubuspl42 commented Oct 11, 2023

lakchote commented Oct 11, 2023

situchan commented Oct 11, 2023

cubuspl42 commented Oct 11, 2023

situchan commented Oct 15, 2023

melvin-bot bot commented Oct 15, 2023

Beamanator left a comment

OSBotify commented Oct 16, 2023

OSBotify commented Oct 16, 2023

OSBotify commented Oct 17, 2023

OSBotify commented Oct 18, 2023

OSBotify commented Oct 18, 2023

[No QA] [TS migration] Migrate 'localFileDownload' lib to TypeScript #27857

[No QA] [TS migration] Migrate 'localFileDownload' lib to TypeScript #27857

Conversation

teneeto commented Sep 20, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Oct 2, 2023

blazejkustra commented Oct 2, 2023

lakchote commented Oct 9, 2023

blazejkustra commented Oct 9, 2023 • edited Loading

situchan left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Oct 11, 2023

cubuspl42 commented Oct 11, 2023

situchan commented Oct 11, 2023

cubuspl42 commented Oct 11, 2023

lakchote commented Oct 11, 2023

situchan commented Oct 11, 2023

cubuspl42 commented Oct 11, 2023

situchan commented Oct 15, 2023

Reviewer Checklist

Screenshots/Videos

melvin-bot bot commented Oct 15, 2023

Beamanator left a comment

Choose a reason for hiding this comment

OSBotify commented Oct 16, 2023

OSBotify commented Oct 16, 2023

OSBotify commented Oct 17, 2023

OSBotify commented Oct 18, 2023

OSBotify commented Oct 18, 2023

teneeto commented Sep 20, 2023 •

edited

Loading

blazejkustra commented Oct 9, 2023 •

edited

Loading