-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Format line breaks in split bill description #29693
Conversation
@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Working on the videos right now |
@parasharrajat @francoisl Added all the videos as well |
Reviewer Checklist
Screenshots/VideosMobile Web - ChromeScreen.Recording.2023-10-16.at.10.57.29.AM.movMobile Web - SafariScreen.Recording.2023-10-16.at.10.58.23.AM.moviOSScreen.Recording.2023-10-16.at.10.57.52.AM.movAndroidScreen.Recording.2023-10-16.at.11.27.17.AM.mov |
Does not look like C+ review is needed. Let me know otherwise. |
Yeah I got this, thanks Rajat. I just need to get Android to build now 😅 |
Android is always the most annoying 😅 |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
(cherry picked from commit 54763e2)
🚀 Cherry-picked to staging by https://github.com/francoisl in version: 1.3.84-8 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
🚀 Deployed to production by https://github.com/francoisl in version: 1.3.84-10 🚀
|
🚀 Deployed to production by https://github.com/francoisl in version: 1.3.84-10 🚀
|
🚀 Deployed to staging by https://github.com/francoisl in version: 1.3.86-0 🚀
|
🚀 Deployed to production by https://github.com/francoisl in version: 1.3.86-5 🚀
|
Details
Fixed Issues
$ #29676
PROPOSAL: #29676 (comment)
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Screen.Recording.2023-10-16.at.11.17.20.PM-1.mov
Android: mWeb Chrome
Screen.Recording.2023-10-16.at.10.52.53.PM-1.mov
iOS: Native
Screen.Recording.2023-10-16.at.10.48.55.PM-1.mov
iOS: mWeb Safari
Screen.Recording.2023-10-16.at.10.42.55.PM-1.mov
MacOS: Chrome / Safari
Screen.Recording.2023-10-16.at.10.31.41.PM-1.mov
MacOS: Desktop
Screen.Recording.2023-10-16.at.10.56.42.PM-1.mov