[HOLD for payment 2023-11-01] [$500] Dev: Console error on bank account Onfido flow

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: Dev 1.3.86.1
Reproducible in staging?: n
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @Pujan92
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1697636190219869

Action Performed:

1. For any workspace go to Bank Account
2. Reach to step 3 which is Personal information(Choose document)
3. Observe the console warning in dev tools

Expected Result:

There should not be console warnings

Actual Result:

Console warnings exists due to withLocalizePropTypes.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~010994b55eb605b669
• Upwork Job ID: 1714642342115131392
• Last Price Increase: 2023-10-18
• Automatic offers:
• Pujan92 | Reporter | 27273804

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~010994b55eb605b669

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

[kbecciv]

Proposal by: @Pujan92
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1697636190219869

Proposal

Please re-state the problem that we are trying to solve in this issue.

Console warning for not providing withLocalizeProps

What is the root cause of that problem?

It is a regression from #27424 where we removed withLocalize and used useLocalize but in the propTypes we have StepPropTypes which expects props withLocalizePropTypes and giving the console warnings.

What changes do you think we should make in order to solve the problem?

We can take out withLocalizePropTypes from the StepPropTypes and add it to those components that require it bcoz now it seems to be not general for all steps. And I think sooner we are going to use useLocalize for other components too.

[trjExpensify]

@barttom @sobitneupane - I think this should be handled by you guys right from #16246?

[barttom]

@trjExpensify Yup, I'll handle this

[trjExpensify]

Cool, thanks. I'm going to assign you for tracking and remove help wanted :)

[trjExpensify]

Also, @sobitneupane I'll switch you for @mananjadhav.

[melvin-bot]

📣 @Pujan92 🎉 An offer has been automatically sent to your Upwork account for the Reporter role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[trjExpensify]

Eurgh, GH being silly @sobitneupane you might have to comment here to let me see you in the assignee selector. 🙄

[melvin-bot]

Triggered auto assignment to @tylerkaraszewski, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.90-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix/29868/requestor onfido props warnings #29950

If no regressions arise, payment will be issued on 2023-11-01. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @barttom does not require payment (Contractor)
• @Pujan92 requires payment offer (Reporter)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@tylerkaraszewski] The PR that introduced the bug has been identified. Link to the PR:
• [@tylerkaraszewski] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@tylerkaraszewski] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@barttom] Determine if we should create a regression test for this bug.
• [@barttom] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[tylerkaraszewski]

@barttom - I believe you need to check off these items?

[barttom]

@tylerkaraszewski That was a simple mistake during development, so I don't see the possibility of writing a test for it.

[tylerkaraszewski]

You can check the items off if you decide we don't need a test.

[trjExpensify]

In terms of payments, I think we just need $50 to @Pujan92 for the bug report right? This was a regression from #16246

[barttom]

@tylerkaraszewski checkboxes are disabled for me

[melvin-bot]

📣 @thesahindia Please request via NewDot manual requests for the Contributor role ($500)

[trjExpensify]

Ahh, @thesahindia ended up being the C+ on the PR instead of @sobitneupane. That'll be why Melv was asking you for the checklist @barttom.

Okay, so then we do need to pay @thesahindia $500 for the review because he wasn't involved in the PR that caused the regression. :)

[thesahindia]

Requesting on new dot.

[trjExpensify]

Perfecto, settled up with @Pujan92 on Upwork. Closing!

[JmillsExpensify]

$500 payment approved for @thesahindia based on this comment.