[HOLD for payment 2023-11-13] [$500] Workspace - Invite members - Tooltip does not show display name in member list

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.3.86.0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @namhihi237
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1697645427249979

Action Performed:

1. Prepare account B has display name
2. Login account A, click new chat and send message with account B
3. Create workspace
4. Go to members
5. Click invite and hover on user B on the list, Observe that the tooltip show display name
6. Select user B
7. Click next => Click invite
8. Hover on user B on the list member, Observe that the tooltip does not show display name

Expected Result:

Tooltip should show display name in step 7 same with step 4 if user has display name

Actual Result:

Tooltip does not show display name in member list

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2023-10-18.at.23.11.35.mov

Recording.5070.mp4

MacOS: Desktop

Screen.Recording.2023-10-18.at.23.14.26.mov

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0141d122e6e97c2984
• Upwork Job ID: 1714714265537466368
• Last Price Increase: 2023-10-18
• Automatic offers:
• namhihi237 | Contributor | 27355496
• namhihi237 | Reporter | 27355499

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0141d122e6e97c2984

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @robertKozik (External)

[kbecciv]

Proposal by: @namhihi237
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1697645427249979

Proposal

Please re-state the problem that we are trying to solve in this issue.

Inconsistent tooltip when hovering on account avatar with display name, it should show display name with you had display name

What is the root cause of that problem?

In BaseUserDetailsTooltip component we use accountID to get user information.
But we didn't pass the account id to member options at WorkspaceMembersPage:

App/src/pages/workspace/WorkspaceMembersPage.js

Lines 360 to 365 in 935e891

	icons: [
	{
	source: UserUtils.getAvatar(details.avatar, accountID),
	name: details.login,
	type: CONST.ICON_TYPE_AVATAR,
	},

What changes do you think we should make in order to solve the problem?

We should add id for icons:

icons: [{
    source: UserUtils.getAvatar(details.avatar, accountID),
    name: details.login,
    type: CONST.ICON_TYPE_AVATAR,
    id: accountID
}, ],

What alternative solutions did you explore? (Optional)

N/A

[robertKozik]

Thanks for your proposal @namhihi237, it solves the issue entirely. But before the assignment I'm curious whether we can find the PR which caused that issue, it would be great to include this info in the proposal as well

[namhihi237]

@robertKozik Yeah, I think this issue comes from #27767, Since we refactor here

[robertKozik]

Great, I think that this cause it as well. Thanks for confirming it as it supports your root cause well. Let's see your proposal in action @namhihi237

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @deetergp, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[sakluger]

@deetergp can you review @namhihi237's proposal and assign them if you agree with @robertKozik? Thanks!

[deetergp]

@namhihi237's proposal looks good to me 👍

[melvin-bot]

📣 @namhihi237 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

📣 @namhihi237 🎉 An offer has been automatically sent to your Upwork account for the Reporter role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.95-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix show name on tooltip member page #30322

If no regressions arise, payment will be issued on 2023-11-13. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @namhihi237 requires payment offer (Contributor)
• @robertKozik does not require payment (Contractor)
• @namhihi237 requires payment offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@robertKozik] The PR that introduced the bug has been identified. Link to the PR:
• [@robertKozik] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@robertKozik] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@robertKozik] Determine if we should create a regression test for this bug.
• [@robertKozik] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@sakluger] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[sakluger]

Paid out @namhihi237 for the reporting and contributor payments.

@robertKozik could you please complete the BZ checklist? Once you do we can close out the issue. Thanks!

[robertKozik]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@robertKozik] The PR that introduced the bug has been identified. Link to the PR: Selection List refactor phase 3: base #27767
• [@robertKozik] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/27767/files#r1391726373
• [@robertKozik] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• [@robertKozik] Determine if we should create a regression test for this bug. I don't think we need separate regression test for it. It came from the refactor so it's rather one-time problem
• [@robertKozik] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. N/A

[sakluger]

Thanks! We're good to close 👍