[HOLD for payment 2023-11-09] [$500] mWeb - Save Button is being overlapped by the keyboard on Welcome Message Page

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.3.89.1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @aman-atg
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1697888584763929

Action Performed:

1. Open the app.
2. Go to #announce/#admins chat
3. Click on header > Details > Settings > Welcome message
4. Click on the welcome message input.
5. Observe that the Save button is not visible.

Expected Result:

Save button should be shown at the top of keyboard just like in pages like Legal Name Page, Private Note Edit Page etc

Actual Result:

Save button is not visible when keyboard is shown

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

welcome-safari.mp4

RPReplay_Final1698067407.MP4

MacOS: Chrome / Safari

MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~016aded3956387f9c7
• Upwork Job ID: 1716446113884372992
• Last Price Increase: 2023-10-23
• Automatic offers:
• s77rt | Reviewer | 27341830
• aman-atg | Contributor | 27341831
• aman-atg | Reporter | 27341833

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~016aded3956387f9c7

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

[kbecciv]

Proposal by: @aman-atg
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1697888584763929

Proposal

Please re-state the problem that we are trying to solve in this issue.

Save button is being overlapped by the keyboard on Welcome Message page

What is the root cause of that problem?

The root cause of this problem is that we haven't used the shouldEnableMaxHeight and includeSafeAreaPaddingBottom={false} props for the ScreenWrapper on this page, which is resulting in the keyboard overlapping the Save button

What changes do you think we should make in order to solve the problem?

We should use both of these props here to prevent the keyboard from overlapping the Save button like we have on other pages

App/src/pages/ReportWelcomeMessagePage.js

Line 78 in 0d11e0b

<ScreenWrapper testID={ReportWelcomeMessagePage.displayName}>

[s77rt]

@aman-atg Thanks for the proposal. Your RCA is correct and the solution looks good to me 👍. Please comment and tag me so you can be assigned.

[aman-atg]

Commented!

[s77rt]

@aman-atg Thanks! Let's get this fixed 🚀

🎀 👀 🎀 C+ reviewed
Link to proposal

[melvin-bot]

Triggered auto assignment to @Li357, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[Li357]

Looks good!

[melvin-bot]

📣 @s77rt 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @aman-atg 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

📣 @aman-atg 🎉 An offer has been automatically sent to your Upwork account for the Reporter role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[aman-atg]

PR is ready for review!

cc: @s77rt

[JmillsExpensify]

PR review in progress

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.94-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• enable maxHeight to avoid keyboard overlapping the save button #30238

If no regressions arise, payment will be issued on 2023-11-09. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @s77rt requires payment offer (Reviewer)
• @aman-atg requires payment offer (Contributor)
• @aman-atg requires payment offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@s77rt] The PR that introduced the bug has been identified. Link to the PR:
• [@s77rt] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@s77rt] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@s77rt] Determine if we should create a regression test for this bug.
• [@s77rt] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@JmillsExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[s77rt]

• The PR that introduced the bug has been identified: Add Welcome message functionality in room settings #18662
• The offending PR has been commented on: Add Welcome message functionality in room settings #18662 (comment)
• A discussion in #expensify-open-source has been started: https://expensify.slack.com/archives/C01GTK53T8Q/p1699006095512429
• Determine if we should create a regression test for this bug: I feel like a regression test would be useless here because the bug can resurface in any place in the App. Adding a checklist item to the PR review process is more effective in preventing such bugs

[melvin-bot]

@JmillsExpensify, @Li357, @s77rt, @aman-atg Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

@JmillsExpensify, @Li357, @s77rt, @aman-atg Eep! 4 days overdue now. Issues have feelings too...

[Li357]

Are we good to close this?

[s77rt]

This is awaiting payment.

[melvin-bot]

@JmillsExpensify, @Li357, @s77rt, @aman-atg Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

@JmillsExpensify, @Li357, @s77rt, @aman-atg 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[melvin-bot]

@JmillsExpensify, @Li357, @s77rt, @aman-atg 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

[aman-atg]

bump @JmillsExpensify

[JmillsExpensify]

To clarify, wasn't this issue associated with a regression?

[JmillsExpensify]

It appears so based on this issue: #30707

[s77rt]

@JmillsExpensify No. It seems that the a new issue was found during the PR testing. But it's not related.

[JmillsExpensify]

Thanks for confirming. Given that the delay in the PR was on our side, payment summary as follows:

• Issue reporter: @aman-atg $50
• Contributor: @aman-atg $750 (incl. urgency bonus)
• Contributor+: @s77rt $750 (incl. urgency bonus)

[JmillsExpensify]

Everyone paid out based on the above payment summary and no regression test. Closing.