[HOLD for payment 2023-11-06] [Performance] Optimize setting initial ref in functional components

[sebryu]

What performance issue do we need to solve?

Setting initial ref in functional components in a way that is running calculation only once

What is the impact of this on end-users?

Slightly more loading time/memory usage of multiple components

List any benchmarks that show the severity of the issue

Gains may be minor, but new approach is following best practices (also discussed on slack with Expensify team )

Proposed solution (if any)

Changing not optimal useRefs to other hooks (or setting initial value to useRef if applicable).

List any benchmarks after implementing the changes to show impacts of the proposed solution (if any)

It's not optimal to collect those benchmark in this case.

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Version Number:
Reproducible in staging?:
Reproducible in production?:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:

[melvin-bot]

Triggered auto assignment to @mountiny (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[sebryu]

Issue created for tracking purposes.
PR already open for review (proposal approved by engineers on slack) : #29643

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.92-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Improved initial value in useRefs - changed useRefs to more suitable hooks #29643

If no regressions arise, payment will be issued on 2023-11-06. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @sebryu does not require payment (Contractor)
• @allroundexperts does not require payment (Eligible for Manual Requests)

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[mountiny]

We only need to pay $250 to @allroundexperts, there was a regression from the PR

[trjExpensify]

Sounds good!

[trjExpensify]

Waiting out the regression period still, Melv.

[mountiny]

This is ready @allroundexperts can you make a request on NewDot and we can close this one

[mountiny]

@allroundexperts have you made the request?

[allroundexperts]

Yes. Good to close. Thanks!

[JmillsExpensify]

$250 payment approved for @allroundexperts