[$500] Distance-App crashes tapping on download receipt in android& on tapping receipt in mweb&web

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.3.92-0

Reproducible in staging?: Y

Reproducible in production?: N

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Expensify/Expensify Issue URL:

Issue reported by: Applause-Internal Team

Slack conversation: @

Action Performed:

1. Launch app
2. Tap fab
3. Tap request money
4. Tap distance
5. Select start and finish waypoints
6. Tap next
7. Select a Workspace
8. Tap Request amount
9. Tap on distance request created to open distance request detail page
10. Tap on the receipt
11. Tap on 3 dots on top and select download receipt

Expected Result:

When user taps on receipt or taps on download receipt app must not crash.

Actual Result:

App crashes tapping on download receipt in android& on crashes on tapping receipt in mweb & web

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Android: Native

Bug6252678_1698372915007.cras.mp4

Bug6252678_1698372747379!app_crashes.txt

Android: mWeb Chrome

Bug6252678_1698372895524.mweb_crash.mp4

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~013fac84786d952629
• Upwork Job ID: 1717850193169375232
• Last Price Increase: 2023-10-27

[melvin-bot]

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~013fac84786d952629

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ArekChr (External)

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @MariaHCD (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[izarutskaya]

Not reproduced in production

Rpreplay.Final1698402342.mp4

[hungvu193]

Seem regression from this PR:
#29643

App/src/components/Attachments/AttachmentCarousel/index.js

Line 210 in eef8347

onViewableItemsChanged={updatePage}

updatePage is an useCallback it will re-create when its dependencies changed and it's not supported with onViewableItemsChanged. We should revert it to useRef.

[situchan]

being fixed in #30481

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[MariaHCD]

Thanks, @situchan! Going to close this one in favor of #30490 since this is happening for all attachments not just for distance requests.