Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] IOU Report - User is sent to blinking/flashing screen after opening sent IOR request #30282

Closed
6 tasks done
lanitochka17 opened this issue Oct 24, 2023 · 32 comments
Closed
6 tasks done
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff

Comments

@lanitochka17
Copy link

lanitochka17 commented Oct 24, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.3.90-1

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

Action Performed:

  1. Using two accounts, using User A, send IOU request to User B
  2. Using User B, open IOU preview and click on individual request(Red Dot appears with report on LHN)
  3. Log out and back in User B and open request

Expected Result:

User is able to open request and view IOU details

Actual Result:

Blinking page is shown after clicking on report
"Hmm, nothing is here" occurs on occasion instead of blinking page or red dot in LHN

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • Windows: Chrome
  • MacOS: Desktop

Screenshots/Videos

Android: Native
Bug6249105_1698167408004.XRecorder_24102023_121107.mp4
Android: mWeb Chrome
Bug6249105_1698167328582.RPReplay_Final1698164257.mp4
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Bug6249105_1698167222525.Video_2023_10_24-1.mp4
MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0134567ff2a3f3bab0
  • Upwork Job ID: 1716926610572148736
  • Last Price Increase: 2023-10-31
@lanitochka17 lanitochka17 added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Oct 24, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 24, 2023

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Oct 24, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented Oct 24, 2023

Triggered auto assignment to @AndrewGable (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@AndrewGable
Copy link
Contributor

Can you reproduce @greg-schroeder ?

@AndrewGable
Copy link
Contributor

I think @danielrvidal says he is seeing this in production, can you confirm @lanitochka17 ?

@AndrewGable
Copy link
Contributor

Demoting to normal bug as this is happening on production according to this!

@AndrewGable AndrewGable added External Added to denote the issue can be worked on by a contributor and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Oct 24, 2023
@melvin-bot melvin-bot bot changed the title IOU Report - User is sent to blinking screen after opening sent IOR request [$500] IOU Report - User is sent to blinking screen after opening sent IOR request Oct 24, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 24, 2023

Job added to Upwork: https://www.upwork.com/jobs/~0134567ff2a3f3bab0

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Oct 24, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 24, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh (External)

@AndrewGable AndrewGable added the Daily KSv2 label Oct 24, 2023
@Jenemark
Copy link
Contributor

Jenemark commented Oct 25, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

The application blinks when clicking report on the LHN, the indicator also turns red.

What is the root cause of that problem?

The root cause seems to be on the side of OnyxData, when running the app in localhost it works as expected.
Can also be tested by copying the curl for the HTTP request and changing staging with your localhost:8082. (Do this in Postman, Insomnia, etc...) The http always seems to fail on non localhost. Even if the page is actually showing, the response body returns with an error.

The error body from the HTTP response:

	"code": 666,
	"jsonCode": 404,
	"type": "Expensify\\Libs\\Error\\ExpError",
	"UUID": "b9114bf5-a67c-44a3-b0f3-b4a27fab05f2",
	"message": "Policy does not exist or you do not have access. Try refreshing the page.",
	"title": "Policy Inaccessible",
	"data": {
		"onyxData": [
			{
				"onyxMethod": "merge",
				"key": "report_4361403564968695",
				"value": {
					"errorFields": {
						"createChat": {
							"1698219760662790": "Policy does not exist or you do not have access. Try refreshing the page."
						}
					}
				}
			}
		]
	},
	"htmlMessage": "",
	"onyxData": [
		{
			"onyxMethod": "merge",
			"key": "report_4361403564968695",
			"value": {
				"errorFields": {
					"createChat": {
						"1698219760662790": "Policy does not exist or you do not have access. Try refreshing the page."
					}
				}
			}
		}
	],
	"requestID": "81b8d2ff582e10b1-CPH"
}

What changes do you think we should make in order to solve the problem?

This could be a certificate or policy issue on the backend endpoint not allowing access from the staging/production. Without having access to the backend an actual fix for this will be hard to implement.

What alternative solutions did you explore? (Optional)

@melvin-bot melvin-bot bot added the Overdue label Oct 26, 2023
@hungvu193
Copy link
Contributor

Here's the issue about retry logic and I think it's being handled here:
#13667

@greg-schroeder
Copy link
Contributor

@hungvu193 are you suggesting we hold for the linked issue?

@melvin-bot melvin-bot bot removed the Overdue label Oct 27, 2023
@hoangzinh
Copy link
Contributor

hoangzinh commented Nov 1, 2023

It looks like a BE issue, after relogin, when userB opens the IOU report, BE returns the error "Policy does not exist or you do not have access. Try refreshing the page." for the API command OpenReport

Screenshot 2023-11-01 at 08 49 16

The issue that @hungvu193 mentioned #30282 (comment) is another issue. It won't solve the root cause of this issue.

cc @greg-schroeder @AndrewGable

@melvin-bot melvin-bot bot added the Overdue label Nov 3, 2023
Copy link

melvin-bot bot commented Nov 6, 2023

@AndrewGable, @hoangzinh, @greg-schroeder Huh... This is 4 days overdue. Who can take care of this?

@AndrewGable AndrewGable added Internal Requires API changes or must be handled by Expensify staff and removed External Added to denote the issue can be worked on by a contributor labels Nov 6, 2023
Copy link

melvin-bot bot commented Nov 6, 2023

Current assignee @hoangzinh is eligible for the Internal assigner, not assigning anyone new.

@AndrewGable
Copy link
Contributor

Marking internal for now!

@melvin-bot melvin-bot bot removed the Overdue label Nov 6, 2023
Copy link

melvin-bot bot commented Nov 7, 2023

@AndrewGable @hoangzinh @greg-schroeder this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@greg-schroeder
Copy link
Contributor

This is internal now as it's a BE issue, Expensify engineer will work on shortly

@melvin-bot melvin-bot bot added the Overdue label Nov 13, 2023
@greg-schroeder
Copy link
Contributor

Same as above

@melvin-bot melvin-bot bot removed the Overdue label Nov 13, 2023
Copy link

melvin-bot bot commented Nov 14, 2023

@AndrewGable @hoangzinh @greg-schroeder this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

@hoangzinh
Copy link
Contributor

just wanna confirm @AndrewGable will work on this issue, won't he?

@greg-schroeder
Copy link
Contributor

Yeah @AndrewGable do you mind giving an ETA on this one?

@AndrewGable AndrewGable removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Nov 16, 2023
@melvin-bot melvin-bot bot added the Overdue label Nov 16, 2023
@AndrewGable AndrewGable added Weekly KSv2 and removed Daily KSv2 labels Nov 16, 2023
@melvin-bot melvin-bot bot removed the Overdue label Nov 16, 2023
@AndrewGable
Copy link
Contributor

I'll look at it soon-ish, I want to make sure it still happens before digging into too deep.

@mvtglobally
Copy link

Issue not reproducible during KI retests. (First week)

Copy link

melvin-bot bot commented Nov 21, 2023

@AndrewGable @hoangzinh @greg-schroeder this issue is now 4 weeks old and preventing us from maintaining WAQ. This should now be your highest priority. Please post below what your plan is to get a PR in review ASAP. Thanks!

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Nov 21, 2023
@hoangzinh
Copy link
Contributor

@greg-schroeder @AndrewGable it looks like this issue has been fixed somewhere

Screen.Recording.2023-11-21.at.21.58.39.mov

@greg-schroeder
Copy link
Contributor

Ah, I think you're right.

@greg-schroeder
Copy link
Contributor

I'm going to close, then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff
Projects
None yet
Development

No branches or pull requests

8 participants