[HOLD for payment 2023-12-04] [HOLD for payment 2023-11-29] [$125] [Form Provider Refactor] BankAccountManualStep

[luacmartins]

Coming from #25397 (comment), we created a new Form provider that works with functional components and we need to refactor all usages of the old Form component.

This issue is specific to refactoring src/pages/ReimbursementAccount/BankAccountManualStep.js

cc @kowczarz @cdOut

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01d24f22fcaf598dd6
• Upwork Job ID: 1716963666355748865
• Last Price Increase: 2023-10-26

[melvin-bot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01d24f22fcaf598dd6

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @mananjadhav (Internal)

[luacmartins]

@cdOut will you be working on this issue too?

[cdOut]

@luacmartins yes, I will be working on this issue.

[melvin-bot]

Current assignee @mananjadhav is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Upwork job price has been updated to $125

[melvin-bot]

@mananjadhav, @luacmartins, @greg-schroeder, @cdOut Whoops! This issue is 2 days overdue. Let's get this updated quick!

[luacmartins]

We have a draft PR

[mananjadhav]

@luacmartins Does this need C+ review? I can see the PR is in draft since a few days.

[luacmartins]

Yes please! We're still working through other migration PRs, but we'll need C+ review once the PR is ready!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.1-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [Form Provider Refactor] AdditionalDetailsStep and AddressForm #30568

If no regressions arise, payment will be issued on 2023-11-29. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @mananjadhav does not require payment (Eligible for Manual Requests)
• @cdOut does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mananjadhav] The PR that introduced the bug has been identified. Link to the PR:
• [@mananjadhav] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@mananjadhav] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@mananjadhav] Determine if we should create a regression test for this bug.
• [@mananjadhav] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@greg-schroeder] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[greg-schroeder]

@mananjadhav you're free to make a manual request for $125 in NewDot for the reviewer role to be paid out 11/29

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.3-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [Form Provider Refactor] BankAccountManualStep #30525

If no regressions arise, payment will be issued on 2023-12-04. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @mananjadhav does not require payment (Eligible for Manual Requests)
• @cdOut does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mananjadhav] The PR that introduced the bug has been identified. Link to the PR:
• [@mananjadhav] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@mananjadhav] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@mananjadhav] Determine if we should create a regression test for this bug.
• [@mananjadhav] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@greg-schroeder] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[mananjadhav]

@luacmartins @greg-schroeder I didn't realize until today that the price was set to $125. Can we please up the price to normal payout? It wasn't a drop-in replacement, had to review the draftValues logic as well.

[luacmartins]

@mananjadhav thanks for raising this. I understand that not issues are made equal and this one involved more than just a simple drop-in replacement, but we decided to price these at $125 regardless of the level of involvement needed. I hope that you understand that.

[mananjadhav]

Okay thanks for clarifying.

[JmillsExpensify]

$125 payment approved for @mananjadhav based on this comment.

[luacmartins]

@JmillsExpensify it seems like we processed payment already. Are we good to close?