Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HOLD for payment 2023-11-22] [ECARD] CRITICAL: Settings - Reveal Details Follow Up - Add Error Handling #30329

Closed
grgia opened this issue Oct 25, 2023 · 21 comments
Closed

[HOLD for payment 2023-11-22] [ECARD] CRITICAL: Settings - Reveal Details Follow Up - Add Error Handling #30329

grgia opened this issue Oct 25, 2023 · 21 comments
Assignees
@allroundexperts @NickTooker @grgia @lukemorawski @dubielzyk-expensify
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Design ECard Wave5-free-submitters External Added to denote the issue can be worked on by a contributor Waiting for copy User facing verbiage needs polishing

Comments

@grgia
Copy link
Contributor

grgia commented Oct 25, 2023 •
edited
Loading

Follow up from #29017 (comment)

Pending the results from marketing/design, we will update the error handling. Slack convo here: https://expensify.slack.com/archives/C027726KHT4/p1698162266272779

Image

We will also remove this promise: #29017 (comment)

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0161ba717edf2a3e86
  • Upwork Job ID: 1717110115130617856
  • Last Price Increase: 2023-10-25
@grgia grgia self-assigned this Oct 25, 2023
@grgia
Copy link
Contributor Author

grgia commented Oct 25, 2023 •
edited
Loading

cc @lukemorawski will take this one

@grgia grgia added Daily KSv2 External Added to denote the issue can be worked on by a contributor labels Oct 25, 2023
@melvin-bot melvin-bot bot changed the title [ECard Settings] Reveal Details Follow Up - Add Error Handling [$500] [ECard Settings] Reveal Details Follow Up - Add Error Handling Oct 25, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 25, 2023

Job added to Upwork: https://www.upwork.com/jobs/~0161ba717edf2a3e86

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Oct 25, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 25, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

@grgia grgia removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Oct 25, 2023
@grgia grgia changed the title [$500] [ECard Settings] Reveal Details Follow Up - Add Error Handling [ECard Settings] Reveal Details Follow Up - Add Error Handling Oct 25, 2023
@lukemorawski
Copy link
Contributor

@grgia Hey. Thanks for CC!

@melvin-bot
Copy link

melvin-bot bot commented Oct 25, 2023

📣 @allroundexperts Please request via NewDot manual requests for the Reviewer role ($500)

@grgia grgia added the Waiting for copy User facing verbiage needs polishing label Oct 25, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 25, 2023

Triggered auto assignment to @NickTooker (Waiting for copy), see https://stackoverflow.com/c/expensify/questions/7025/ for more details.

@grgia
Copy link
Contributor Author

grgia commented Oct 25, 2023

@NickTooker we need to check off the copy for this error. There's more context in this slack convo - https://expensify.slack.com/archives/C03SSAQG5/p1698224498878229

ping me if you have any questions!

@grgia grgia mentioned this issue Oct 25, 2023
Merged
65 tasks
@NickTooker
Copy link

An error occurred while loading the card details. Please check your internet connection and try again.

How about this? Addressing the edge case but keeping the main portion of the error message.

@joekaufmanexpensify
Copy link
Contributor

That sounds good to me!

@melvin-bot melvin-bot bot added the Overdue label Oct 30, 2023
@grgia grgia added the Design label Oct 30, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 30, 2023

Triggered auto assignment to @dubielzyk-expensify (Design), see these Stack Overflow questions for more details.

@melvin-bot melvin-bot bot removed the Overdue label Oct 30, 2023
@grgia
Copy link
Contributor Author

grgia commented Oct 30, 2023 •
edited
Loading

Hey @dubielzyk-expensify could you mock the error state for this page?
This is the copy:

An error occurred while loading the card details. Please check your internet connection and try again.

And there's more context here: https://expensify.slack.com/archives/C027726KHT4/p1698162266272779

Figma here

Shawn proposed we follow a similar pattern to this

@grgia
Copy link
Contributor Author

grgia commented Nov 1, 2023

Figma link

@grgia
Copy link
Contributor Author

grgia commented Nov 1, 2023

@lukemorawski design has been finalized!

@grgia
Copy link
Contributor Author

grgia commented Nov 1, 2023

@lukemorawski could you also fix the formatting of the expiration date?

Image

@dubielzyk-expensify
Copy link
Contributor

Sorry. I didn't update this ticket, but mock provided:
CleanShot 2023-11-02 at 14 20 24@2x

Figma

@melvin-bot melvin-bot bot added the Overdue label Nov 6, 2023
@grgia
Copy link
Contributor Author

grgia commented Nov 6, 2023

We got the final translations today, so should be moving forward with this one. Thanks for the mocks @dubielzyk-expensify !

@melvin-bot melvin-bot bot removed the Overdue label Nov 6, 2023
@dylanexpensify dylanexpensify added the ECard Wave5-free-submitters label Nov 7, 2023
@dylanexpensify dylanexpensify changed the title [ECard Settings] Reveal Details Follow Up - Add Error Handling [ECARD] CRITICAL: Settings - Reveal Details Follow Up - Add Error Handling Nov 7, 2023
@lukemorawski lukemorawski mentioned this issue Nov 8, 2023
Merged
59 tasks
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 Weekly KSv2 labels Nov 9, 2023
@melvin-bot melvin-bot bot changed the title [ECARD] CRITICAL: Settings - Reveal Details Follow Up - Add Error Handling [HOLD for payment 2023-11-22] [ECARD] CRITICAL: Settings - Reveal Details Follow Up - Add Error Handling Nov 15, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Nov 15, 2023
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Nov 15, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Nov 15, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.99-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-11-22. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Nov 22, 2023
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Nov 27, 2023

@allroundexperts, @NickTooker, @grgia, @lukemorawski, @dubielzyk-expensify Huh... This is 4 days overdue. Who can take care of this?

@NickTooker
Copy link

@grgia Do you need me for anything else here? Thanks!

@melvin-bot melvin-bot bot removed the Overdue label Nov 27, 2023
@grgia
Copy link
Contributor Author

grgia commented Nov 27, 2023

nope, closing! @NickTooker

@grgia grgia closed this as completed Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@allroundexperts allroundexperts

@NickTooker NickTooker

@grgia grgia

@lukemorawski lukemorawski

@dubielzyk-expensify dubielzyk-expensify

Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Design ECard Wave5-free-submitters External Added to denote the issue can be worked on by a contributor Waiting for copy User facing verbiage needs polishing
Projects
No open projects
[#whatsnext] Wave 05 - Deprecate Free
Status: Done
Milestone
No milestone
Development

No branches or pull requests
7 participants
@allroundexperts @NickTooker @grgia @joekaufmanexpensify @dylanexpensify @lukemorawski @dubielzyk-expensify