[HOLD for payment 2023-12-28] [$500] Thread - Admin lands in [Delete message] after login when employee subscribes to welcome message

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.3.93-1
Reproducible in staging?: Y
**Reproducible in production?:**N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Issue found when executing PR #27994

Action Performed:

1. [Admin] Invite employee to a workspace
2. [Admin] Log out
3. [Employee] Open the workspace chat > right-click on the welcome message > Subscribe to thread
4. [Admin] Log in

Expected Result:

Admin lands on valid chat report

Actual Result:

Admin is redirected to [Delete message] from the welcome message thread. Sometimes 'welcome message' thread. opens without [Deleted message]

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Bug6258036_1698754537286.20231031_144009.mp4

MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01853efb86b5ca79a2
• Upwork Job ID: 1721684595387928576
• Last Price Increase: 2023-11-07
• Automatic offers:
• aimane-chnaif | Reviewer | 27759906
• tienifr | Contributor | 27759907

Issue Owner

Current Issue Owner: @srikarparsi

[melvin-bot]

Triggered auto assignment to @NicMendonca (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @AndrewGable (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[Beamanator]

In this thread, @chiragsalian and @AndrewGable and I agreed this is a pretty weird edge case, so NAB - also ccing @srikarparsi since this most likely came from #27994

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

@NicMendonca, @srikarparsi Eep! 4 days overdue now. Issues have feelings too...

[srikarparsi]

Hey this is reproducible and I believe this and I believe this can be a frontend fix so I'm making this external

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01853efb86b5ca79a2

[melvin-bot]

@NicMendonca, @srikarparsi, @aimane-chnaif, @tienifr Whoops! This issue is 2 days overdue. Let's get this updated quick!

[srikarparsi]

Not overdue, bumped here

[melvin-bot]

@NicMendonca, @srikarparsi, @aimane-chnaif, @tienifr Still overdue 6 days?! Let's take care of this!

[melvin-bot]

@NicMendonca, @srikarparsi, @aimane-chnaif, @tienifr 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

[NicMendonca]

I am going on leave so have to re-assign this.

Both contributors have been paid. We're just waiting on feedback from @srikarparsi on expected behaviour for a regression test

[melvin-bot]

Triggered auto assignment to @conorpendergrast (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[conorpendergrast]

From the thread, it looks like the conclusion is that we do not need to thread on automated whispers

[melvin-bot]

@conorpendergrast, @srikarparsi, @aimane-chnaif, @tienifr Eep! 4 days overdue now. Issues have feelings too...

[srikarparsi]

Yup! That seems like the case, @conorpendergrast in that case I believe we can pay out @aimane-chnaif and @tienifr for the PR

[conorpendergrast]

Well then, today I will pay out based on this comment. Thank you for confirming @srikarparsi!

[aimane-chnaif]

This was paid already. Good to close?

[conorpendergrast]

Haha I was just discovering that

[aimane-chnaif]

@conorpendergrast please close upwork contract what @NicMendonca didn't

[conorpendergrast]

Contracts ended. I think we still need the C+ checklist, in particular for regression tests now that we have confirmed the expected behaviour

[aimane-chnaif]

Regression Test Proposal

1. As admin, invite employee to a workspace
2. Login with employee
3. Open the workspace chat
4. Right-click/Long press on the welcome message
5. Verify that "Reply in thread", "Join thread" options don't show in context menu

[conorpendergrast]

Regression test created: https://github.com/Expensify/Expensify/issues/367771

All done, thanks everyone