[HOLD for payment 2024-01-04] [$500] IOS - A blank spot appears after deleting a money request

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

**Version Number:**1.2.94.0
**Reproducible in staging?:**Y
**Reproducible in production?:**Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Request money manually form Fab menu
2. Select user
3. Add receipt
4. Select from Gallery
5. Complete request
6. Open Request
7. Select tree dot and select Delete Request

Expected Result:

NO blank spot appears after deleting a money request

Actual Result:

A blank spot appears after deleting a money request

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6259710_1698859295882.RPReplay_Final1698856245__1_.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~013eb8adb4d15a7d21
• Upwork Job ID: 1719769628619288576
• Last Price Increase: 2023-11-15
• Automatic offers:
• shubham1206agra | Reviewer | 27753278
• tienifr | Contributor | 27753279

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~013eb8adb4d15a7d21

[melvin-bot]

Triggered auto assignment to @NicMendonca (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @shubham1206agra (External)

[tienifr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

IOS - A blank spot appears after deleting a money request

What is the root cause of that problem?

We already have the logic to scroll to bottom when the last item change height here. But we just use listItemHeightNormal: 64 and it's not enough. For the money request with receipt, the height will be 278 > 64 so the FlatList does not scroll to bottom

What changes do you think we should make in order to solve the problem?

We should add the logic to scroll to bottom if the last action get changed

In order to do that, we can store the previous last reportActionID and compare it with current last reportActionID

In ReportActionsList

    const previousLastIndex = usePrevious(sortedReportActions[0].reportActionID) // we can use useRef here

    useEffect(()=>{
        if(previousLastIndex !== sortedReportActions[0].reportActionID && reportActionSize.current > sortedReportActions.length){
            reportScrollManager.scrollToBottom()
        }
    }, [previousLastIndex, sortedReportActions[0].reportActionID])

Result

Screen.Recording.2023-11-02.at.15.06.19.mov

[NicMendonca]

@shubham1206agra proposal for you ^

[shubham1206agra]

@tienifr Thanks for the proposal.
The RCA looks right. I have some follow-up questions.
Why won't increasing the height work?
And can you try to come up with an alternative solution? Cause this solution might introduce regressions.

[tienifr]

Why won't increasing the height work?

@shubham1206agra I thought about this solution but the height is dynamic (we can write the long message), that why we can't just increase the height

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@NicMendonca, @shubham1206agra Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@NicMendonca, @shubham1206agra Whoops! This issue is 2 days overdue. Let's get this updated quick!

[NicMendonca]

@shubham1206agra bump on this comment!

[shubham1206agra]

@tienifr proposal looks good to me. I just need to confirm all scenerios that might break using this logic.

[shubham1206agra]

Can someone confirm if its still reproducible in DEV?

[shubham1206agra]

I think #26498 changed the value of autoscrollToTopThreshold to 128.
See #26498 (review).

@tienifr A similar solution to you was marked as a workaround. #26498 (comment)

cc @roryabraham @mountiny as you have more context to this issue.

[tienifr]

Increasing autoscrollToTopThreshold is not a good idea IMO, let's write the super long message (the height would > 128px) then delete it, the blank space will appear

[mountiny]

I think Rory mentioned we could dynamically set the autoscrollToTopThreshold to the screen height, right? that would work then for most cases.

[melvin-bot]

@NicMendonca @shubham1206agra this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

📣 @shubham1206agra 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @tienifr 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

This issue has not been updated in over 15 days. @rlinoz, @NicMendonca, @shubham1206agra, @tienifr eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[shubham1206agra]

I will finish the review this weekend

[NicMendonca]

@shubham1206agra did you get a chance to review?

[shubham1206agra]

@NicMendonca Yes, I just needed some minor adjustments, which I requested before approving the PR

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.18-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: 30726 A blank spot appears after deleting a money request #31670

If no regressions arise, payment will be issued on 2024-01-04. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @shubham1206agra requires payment automatic offer (Reviewer)
• @tienifr requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@shubham1206agra] The PR that introduced the bug has been identified. Link to the PR:
• [@shubham1206agra] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@shubham1206agra] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@shubham1206agra] Determine if we should create a regression test for this bug.
• [@shubham1206agra] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@NicMendonca] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[shubham1206agra]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@shubham1206agra] The PR that introduced the bug has been identified. Link to the PR: Improve goBack function #26498
• [@shubham1206agra] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/26498/files#r1440636967
• [@shubham1206agra] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: Not required
• [@shubham1206agra] Determine if we should create a regression test for this bug. Yes
• [@shubham1206agra] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

1. Request money manually form Fab menu with receipt.
2. Open Request created in previous step.
3. Select three dot and select Delete Request, and delete the request.

• [@NicMendonca] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[NicMendonca]

@shubham1206agra @tienifr You've both been paid via Upwork 👍

[NicMendonca]

all set here!