[$500] [Wave 6: Tags] Tag written as "Parents: Child" appears as "Parents\: Child"

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v1.3.94-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation: @

Action Performed:

Precondition: Category with subcategory in the "Parents: Child" format is added to Tags on OD.

1. Navigate to staging.new.expensify.com.
2. Go to workspace chat > + > Request money > Manual.
3. Enter the amount and proceed to confirmation page.
4. Click Tag.

Expected Result:

Since subcategory is not supported in Tags, the tag in "Parents: Child" format should appear in "Parents: Child" format.

Actual Result:

The tag written as "Parents: Child" appears as "Parents: Child".

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0111054913fb9cbbb1
• Upwork Job ID: 1719801714306273280
• Last Price Increase: 2023-11-08

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0111054913fb9cbbb1

[melvin-bot]

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (External)

[FitseTLT]

Proposal

Please re-state the problem that we are trying to solve in this issue.

"Parent:Child" form of a tag will appear "Parent/:Child" in Tag list

What is the root cause of that problem?

Tag text sent from the server is with the slash included "Parent/:Child", it must related to some escaping code in the back end.

What changes do you think we should make in order to solve the problem?

It might need to be solved from backend but we can also remove the slash before we display it on the frontend.
And the perfect place to do that I think is here:
Change this code

App/src/libs/OptionsListUtils.js

Lines 912 to 920 in aa18b6d

	function getTagsOptions(tags) {
	return _.map(tags, (tag) => ({
	text: tag.name,
	keyForList: tag.name,
	searchText: tag.name,
	tooltipText: tag.name,
	isDisabled: !tag.enabled,
	}));
	}

to

function getTagsOptions(tags) {
    return _.map(tags, (tag) => {
        const slashRemoved = removeSlash(tag.name);
        return {
            text: slashRemoved,
            keyForList: slashRemoved,
            searchText: slashRemoved,
            tooltipText: slashRemoved,
            isDisabled: !tag.enabled,
        };
    });
}

function removeSlash(tag) {
    return tag.replace(/(\\)+/g, '');
}

What alternative solutions did you explore? (Optional)

[saranshbalyan-1234]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Tag written as "Parents: Child" appears as "Parents: Child"

What is the root cause of that problem?

This is due the issue of getting escape character while saving a category app is introducing escape characters.

What changes do you think we should make in order to solve the problem?

While creating a new category, which i think is not there in new dot, it is there in old dot, we have to remove escape characters either from frontend or from backend

What alternative solutions did you explore? (Optional)

Remove escape characters from new dot while showing it on UI
N/A

[MrJithil]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The escape character showing in multi level tags.

What is the root cause of that problem?

In Old Dot, to create multiple line tags, we need to upload the file in csv. As per the system design, to add a tag with ":" in it, we need to add a single "" in order to do so.

This tags are rendering the extra \ in the tag text.

What changes do you think we should make in order to solve the problem?

In the
src/components/OptionRow.js

we are getting the const text = lodashGet(props.option, 'text', ''); After this, there are rule sets like fullTitle, indentsLength etc being run.
Here, we will introduce a new line const escapedText = text.replace(<regex>, '')

What alternative solutions did you explore? (Optional)

Write escaping inside the options map.

function getTagsOptions(tags) {
    return _.map(tags, (tag) => ({
        text: tag.name.replace(<regex>, '',) // here the tags list will convert to the tags options
        keyForList: tag.name,
        searchText: tag.name,
        tooltipText: tag.name,
        isDisabled: !tag.enabled,
    }));
}

We should not touch the other places of getTagsOptions map.

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[CortneyOfstad]

Getting engineering eyes on this and we've had issues with this in the past but it is usually caused by strange characters in the tag names.

[melvin-bot]

Triggered auto assignment to @youssef-lr (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[melvin-bot]

@youssef-lr, @CortneyOfstad, @jjcoffee Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[jjcoffee]

@CortneyOfstad Just to clarify are we waiting for @youssef-lr to look into this, or shall I still go ahead with reviewing proposals?

[CortneyOfstad]

I believe we should wait on @youssef-lr for to review, just to be safe 👍

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[CortneyOfstad]

@youssef-lr bump — thanks!

[CortneyOfstad]

@FitseTLT @jjcoffee — I've sent you both offers in Upwork for this job. Please let me know once you accept and I can get this paid — thanks!

[jjcoffee]

@CortneyOfstad Accepted, thanks! Just a heads up in case you missed it - there was a regression here.

[CortneyOfstad]

@jjcoffee thanks for the heads up! Will adjust the title to reflect that. Thanks!

[CortneyOfstad]

Not overdue 👍

[jjcoffee]

Working through another regression, unfortunately! #32203

[jjcoffee]

#32203 is no longer replicable, I think we can take this back off hold @CortneyOfstad.

[roryabraham]

@izarutskaya Can we please retest this issue? Also requested retest in slack: https://expensify.slack.com/archives/C9YU7BX5M/p1702088246126149

[roryabraham]

This appears to have been fixed. Can anyone else confirm?

[jjcoffee]

Working fine for me! There is some discussion though regarding not correctly escaping the tags when sending back to the server (which is what oldDot does).

[CortneyOfstad]

Do we feel comfortable closing this in favor of #32203 (comment) since the scope of the issue has not changed @roryabraham @jjcoffee?

[lanitochka17]

Issue is still reproducible on the latest build 1.4.30-0

20240123_222449.mp4

[jjcoffee]

@lanitochka17 Thanks for raising! We'll be handling on #32203 instead, so this can be closed.