[HOLD for payment 2023-11-17] Login - Chat loads infinitely after logging in unless user opens another chat

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.3.96.0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Navigate to staging.new.expensify.com
2. Log in with an existing account with chats.

Expected Result:

Chat loads without issue after login.

Actual Result:

Chat loads infinitely until user opens another chat.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6266664_1699315357675.20231107_075145.mp4

View all open jobs on GitHub

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @marcaaron (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[bernhardoj]

Reverting the onyx bump seems to fix the problem for me

[tgolen]

I'm taking a look into this one

[tgolen]

This is being discussed here: https://expensify.slack.com/archives/C035J5C9FAP/p1699374131021109

[tgolen]

I've confirmed that Expensify/react-native-onyx#412 is the cause of the problems. I'd like to see if I can find a fix for it without needing to revert, though I know that's going to delay the deploy.

[tgolen]

Getting this reviewed and merged today. Once the Onyx PR is merged, I need to create an App PR to bump the Onyx version. I think I'll create a draft PR for that now so that it'll be ready.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.97-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Bump the onyx version to 1.0.115 #31066

If no regressions arise, payment will be issued on 2023-11-17. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

[getusha]

@tgolen could you please add the Bug label to assign BZ for C+ payment?

[melvin-bot]

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[tgolen]

@laurenreidexpensify Could you please help with payments on this one? @getusha needs to be paid for a C+ review on the PR.

[laurenreidexpensify]

Payment Summary:

• C+ Review @getusha $500, offer sent in Upwork

[getusha]

@laurenreidexpensify accepted!

[laurenreidexpensify]

Payment Summary:

C+ Review @getusha $500, payment issued in Upwork