Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deploy Checklist: New Expensify 2023-11-06 #30929

Closed
OSBotify opened this issue Nov 6, 2023 · 30 comments
Closed

Deploy Checklist: New Expensify 2023-11-06 #30929

OSBotify opened this issue Nov 6, 2023 · 30 comments
Assignees
@applausebot
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash

Comments

@OSBotify
Copy link
Contributor

OSBotify commented Nov 6, 2023 •
edited by puneetlath
Loading

Release Version: 1.3.96-15
Compare Changes: production...staging

This release contains changes from the following pull requests:

Internal QA:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
  • I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads
@kavimuru kavimuru added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Nov 6, 2023
@kavimuru
Copy link

kavimuru commented Nov 6, 2023

Checking off the following PRs from the past builds
#29140
#29845
#29984
#30065
#30263
#30320
#30322
#30342
#30401
#30478
#30591
#30609
#30640
#30656
#30671
#30708
#30710
#30712
#30731
#30736
#30655

@OSBotify
Copy link
Contributor Author

OSBotify commented Nov 7, 2023

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.3.96-0 🚀

@kavimuru
Copy link

kavimuru commented Nov 7, 2023

Not sure if QA can test or it is internal.
#30822 and #30820

@cristipaval
Copy link
Contributor

Checking off #30991, it's a minor issue, not a blocker.

@mountiny
Copy link
Contributor

mountiny commented Nov 7, 2023

@puneetlath
Copy link
Contributor

Checked off #30945 as not a blocker.

@puneetlath
Copy link
Contributor

Checked off #30935 as not a blocker.

@kavimuru
Copy link

kavimuru commented Nov 7, 2023

@puneetlath could check this one? #30929 (comment)

@puneetlath
Copy link
Contributor

@kavimuru I'll ask internally.

Checking off #31000 as non-reproducible.

@puneetlath
Copy link
Contributor

#30977 has been fixed via CP.

@puneetlath
Copy link
Contributor

@kavimuru looks like #30822 and #30820 got tested internally and are passing.

@kavimuru
Copy link

kavimuru commented Nov 7, 2023

Thank you!

@marcaaron
Copy link
Contributor

I demoted #30936 to a regular bug. Reason here.

@kavimuru
Copy link

kavimuru commented Nov 7, 2023

Regression is down to 6%. We are still validating few PRs.

#30050 blocked with #30979
#29781 failing with #29235 (not fixed)
#30459 failing with #30376 (not fixed in iOS)
#30669 failing with #22949 (known issue and checking it off)

@peterdbarkerUK
Copy link
Contributor

peterdbarkerUK commented Nov 7, 2023 •
edited
Loading

I can reproduce #30976, not sure if it's NAB as it only affects mWeb Android and is a minor visual error (and I'm still new at this).

@madmax330 is offline until tomorrow, could someone else take a look-see?

@kavimuru
Copy link

kavimuru commented Nov 7, 2023

Regression is complete. Validating the Cps now.
#30050 blocked with #30979
#29781 failing with #29235 (not fixed)
#30459 failing with #30376 (not fixed in iOS)
#30653 failing with #28858 (not fixed)
#30751 failing with ##25790 (comment) in desktop and #31000 in web
#30831 failing with #30949
#30515 failing with #31028

@Beamanator
Copy link
Contributor

Beamanator commented Nov 8, 2023 •
edited
Loading

Checked off #30979 b/c was fixed via #30995 on Android, v1.3.96-5

@mountiny
Copy link
Contributor

mountiny commented Nov 8, 2023

Some of the new PR which show as deployed in 1.3.96-6 were not deployed

@mvtglobally
Copy link

@mountiny bunch of PRs got unchecked by Melvin. Do we need to retest on a new build or good to just check them off again

@mountiny
Copy link
Contributor

mountiny commented Nov 8, 2023

@mvtglobally this is the only PR which was included in the 96-6 build #30962 so we should check all the other ones which have been commented with the deploy comment in this version and check them off as they have not been deployed actually

@puneetlath
Copy link
Contributor

@kavimuru is #30459 failing?

@kavimuru
Copy link

kavimuru commented Nov 8, 2023

@puneetlath Only in iOS.

@luacmartins
Copy link
Contributor

Checking off #31062. It's a dupe of another issue and it also happens in prod.

@puneetlath
Copy link
Contributor

##30653 was reverted. Checking off.

@puneetlath
Copy link
Contributor

All cleared! Shipping it.

@puneetlath
Copy link
Contributor

:shipit:

@os-botify
Copy link

os-botify bot commented Nov 8, 2023

This issue either has unchecked items or has not yet been marked with the :shipit: emoji of approval.
Reopening!

@os-botify os-botify bot reopened this Nov 8, 2023
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Nov 8, 2023

📣 @os-botify[bot]! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

  1. Make sure you've read and understood the contributing guidelines.
  2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
    Screen Shot 2022-11-16 at 4 42 54 PM
    Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

@puneetlath
Copy link
Contributor

:shipit:

@puneetlath puneetlath reopened this Nov 8, 2023
@puneetlath
Copy link
Contributor

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@applausebot applausebot

Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests