[HOLD FOR PAYMENT] [$500] mWeb/Chrome - Compose-After pasting emoji, cursor moving single space away

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.3.96-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation: @

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Tap on a report
3. Search emoji by typing :depa and select it from suggestions
4. Select and copy the emoji and paste it

Expected Result:

After pasting emoji, cursor must not move single space away.

Actual Result:

After pasting emoji, cursor moving single space away.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6266997_1699345284262.space.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~015f8946b141752346
• Upwork Job ID: 1721857426065879040
• Last Price Increase: 2023-11-07

[melvin-bot]

Triggered auto assignment to @NicMendonca (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~015f8946b141752346

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @alitoshmatov (External)

[izarutskaya]

Issue is not reproducible in production

Screen_Recording_20231107_135621_Chrome.mp4

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @MariaHCD (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[HardikChoudhary24]

Proposal

Please re-state the problem that we are trying to solve in this issue

• After pasting emoji, cursor moving single space away

What is the root cause of that problem?

• The root cause of this issue is that we add whitespace after inserting emoji via native keyboard, and we are not checking whether we are entering it manually or directly pasting it.

App/src/pages/home/report/ReportActionCompose/ComposerWithSuggestions/ComposerWithSuggestions.js

Line 264 in 8d6fc37

const isEmojiInserted = diff.length && endIndex > startIndex && EmojiUtils.containsOnlyEmojis(diff);

What changes do you think we should make in order to solve the problem?

• To address this problem, we can resolve it by simply checking whether we are pasting a emoji or inserting it manually.
• This can be done by adding the below code in ComposerWithSuggestion component.

const [isTextPasted,setIsTextPasted] = useState(false);

• And then passing setIsTextPasted as a prop to the Composer Component.

setIsTextPasted = {()=>setIsTextPasted(true)}

• And setting the value of isTextNotPasted in the handlePastePlainText function in the composer component.
  

  App/src/components/Composer/index.js

  Lines 265 to 271 in 8d6fc37

  	const handlePastePlainText = useCallback(
  	(event) => {
  	const plainText = event.clipboardData.getData('text/plain');
  	paste(plainText);
  	},
  	[paste],
  	);

const handlePastePlainText = useCallback(
        (event) => {
            setIsTextPasted();
            const plainText = event.clipboardData.getData('text/plain');
            paste(plainText);
        },
        [paste],
    );

And then adding isTextPasted when we are checking for the inserted text.

const isEmojiInserted = !isTextPasted && diff.length && endIndex > startIndex && EmojiUtils.containsOnlyEmojis(diff) ;
setIsTextPasted(false);

What alternative solutions did you explore? (Optional)
N/A

[MariaHCD]

I don't think this should block the deploy. But we can certainly get this fixed.

Thoughts, @alitoshmatov?

[alitoshmatov]

@MariaHCD agree, I think this issue can handled as a regression from #30412

[bondydaa]

#23658 (comment)

we're going to revert the PR that caused this

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[bondydaa]

revert pr is up #31011

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[bondydaa]

revert PR was CP'd to staging, can you please retest to confirm it's fixed?

[MariaHCD]

Retested on staging mWeb Chrome and looks good!

XRecorder_08112023_112740.mp4

[puneetlath]

Reopening as we need to pay @alitoshmatov for C+ review

[alitoshmatov]

PR was deployed to production in 10th November, tomorrow it will be ready for payment

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[alitoshmatov]

We can proceed with payment

[NicMendonca]

@alitoshmatov are you paid via Upwork, or Expensify? If Upwork, can you apply to the job? https://www.upwork.com/jobs/~015f8946b141752346

[alitoshmatov]

@NicMendonca Upwork, applied

[mvtglobally]

Issue not reproducible during KI retests. (Second week)

[mvtglobally]

Issue not reproducible during KI retests. (Third week)

[alitoshmatov]

@NicMendonca Friendly bump for payment

[NicMendonca]

paid!