[HOLD for payment 2023-11-17] [$500] mWeb/Chrome - Start Chat- #Rooms creation menu is misaligned

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.3.96-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation: @

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Tap fab
3. Tap start chat
4. Tap chat---room--chat (navigate to and fro)

Expected Result:

The room page left margin must show enough space and alignment of page must be correct.

Actual Result:

After tapping chat, if user taps room, by navigating to and fro, left margin no space is shown and alignment is not fine.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6266785_1699326229571.6room.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01a9e9cfdca0e3fa3a
• Upwork Job ID: 1721845296933953536
• Last Price Increase: 2023-11-07
• Automatic offers:
• situchan | Reviewer | 27576928
• tienifr | Contributor | 27576931

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01a9e9cfdca0e3fa3a

[melvin-bot]

Triggered auto assignment to @peterdbarkerUK (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan (External)

[izarutskaya]

Not reproduced in production

Screen_Recording_20231107_103714_Chrome.mp4

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @madmax330 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[s-alves10]

I am not able to reproduce this on the latest main. Please help me if I missed something

[peterdbarkerUK]

Yep I can reproduce this. It's not quite as extreme as the video, but switching to room seems to jogglingly over/undershoot and eventually settle slightly off-centre. Updated the OP to make it a bit clearer.

[peterdbarkerUK]

[madmax330]

@peterdbarkerUK is this on staging or production?

[madmax330]

It's known that it's broken on staging, but it works on main/dev. So that means it's already fixed, we're just not sure by which PR so we would need to CP that is my guess

[peterdbarkerUK]

Ah, I failed to find that it was known, thanks for clarifying. Will you investigate that?

[tienifr]

@madmax330 @peterdbarkerUK I can still reproduce this issue on latest main

Proposal

Please re-state the problem that we are trying to solve in this issue.

#Rooms creation menu is misaligned, especially if tapping it back and forth quickly between the Chat and Room

What is the root cause of that problem?

In useAutoFocusInput, we'll auto focus after a timeout here https://github.com/Expensify/App/blob/4f9210729a368e16be965d1607a63559189a7e8c/src/hooks/useAutoFocusInput.js#L19C5-L19C5

However, in slow devices like on Android, the navigation animation can take more than 300ms. In this case, we'll auto focus on the input before the animation finishes, which interferes with the navigation, causing the misalignment. We previously have similar issues on iOS, when we autofocus on the input immediately, before the navigation ends.

What changes do you think we should make in order to solve the problem?

We should run this block inside InteractionManager.runAfterInteractions, to make sure in the case transition animation takes longer than usual, the autofocus will still only happen after the navigation ends.

What alternative solutions did you explore? (Optional)

We can increase the timeout value so it can accommodate the slow device case.

An alternative we can potentially explore is to rely only on runAfterInteractions for certain platforms, since as far as I remember, the timeout was added to fix an issue on Android, we might not need it for other platforms. But the timeout approach is a tried-and-true one so I prefer to simply add the fix for this case on top of it.

[madmax330]

Nice find @tienifr can you make a PR for this quickly?

[tienifr]

Yes I can work on this now. Please assign.

[melvin-bot]

📣 @situchan 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @tienifr 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[tienifr]

PR ready for review #31063.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.97-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Fix: New room page is misaligned after page transition #31063

If no regressions arise, payment will be issued on 2023-11-17. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @situchan requires payment offer (Reviewer)
• @tienifr requires payment offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@situchan] The PR that introduced the bug has been identified. Link to the PR:
• [@situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@situchan] Determine if we should create a regression test for this bug.
• [@situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@peterdbarkerUK] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[peterdbarkerUK]

Noice. @situchan I'm on the fence about this needing specific regression testing, what do you think?

Payments sent:

• @tienifr $500 Contributor
• @situchan $500 Reviewer

Job closed

[situchan]

The root cause is performance degrade. Handling that in #31190
This was caught by Applause team so no need specific regression testing.