Show the context menu when we long press assignee of a task #28840

ShogunFire · 2023-10-04T16:22:47Z

Details

Like for other previews, we show the context menu when we long press a task assignee

Fixed Issues

$ #23026
PROPOSAL: #23026 (comment)

Tests

Click FAB -> Assign task
Add task details
Select assignee
Long press on Assignee of task
Verify that the context menu shows on platforms with touch screen

Verify that no errors appear in the JS console

Offline tests

Same tests

QA Steps

Same tests

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web.mp4

Mobile Web - Chrome

mweb.mp4

Mobile Web - Safari

safari.mp4

Desktop

2023-10-26.11-46-25.mp4

iOS

2023-10-26.11-41-11.mp4

Android

2023-10-26.12-32-03.mp4

Signed-off-by: Pierre Michel <pmiche04@gmail.com>

Signed-off-by: Pierre Michel <pmiche04@gmail.com> # Conflicts: # src/components/ReportActionItem/TaskPreview.js

Signed-off-by: Pierre Michel <pmiche04@gmail.com>

melvin-bot · 2023-10-04T16:22:53Z

@abdulrahuman5196 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Signed-off-by: Pierre Michel <pmiche04@gmail.com>

abdulrahuman5196 · 2023-10-05T06:15:48Z

@ShogunFire The author's checklist is pending on this. Not sure if PR is complete.

ShogunFire · 2023-10-06T15:54:19Z

I will try to add the videos today

abdulrahuman5196 · 2023-10-10T12:56:42Z

Any update on the PR @ShogunFire ?

ShogunFire · 2023-10-10T15:20:22Z

I have troubles testing on android because of a reanimated error, on mweb and safari it works but on ios it doesn't, I am not sure why but it might be because we use onPress in TextLink which is used in MentionRenderer, we also have a preventDefault in the callback of onPress here that could cause this problem

App/src/components/TextLink.js

Line 47 in c228338

event.preventDefault();

abdulrahuman5196 · 2023-10-12T12:11:17Z

@ShogunFire Any update on the issue?

ShogunFire · 2023-10-12T14:41:40Z

I have more informations on the cause:
In MentionUserRenderer we pass onPress to the TextLink (which will pass it to the Text component)
For android and ios, react native uses a Touchable when we pass the prop onPress to the Text component.

When there is a nested Touchable or Pressable, only the nested events are called and the events from the parent Pressable are ignored, that's why the long press event is never called and the context menu doesn't show.

I am trying to find a solution but so far it seems difficult unless we don't pass the onPress when the user mention is in a task preview. The consequence of this is that in task previews when we click the user, it will open the task report instead of the user details, is it acceptable ?

abdulrahuman5196 · 2023-10-13T06:55:46Z

@ShogunFire I don't understand the issue you are saying?

Can you provide code pointer or screen recording videos to clarify?

ShogunFire · 2023-10-13T11:59:50Z

In TaskPreview Here I set up the onLongPress event to show the context menu.

But it doesn't work when we click on the user mention. We put the user-mention tag here

And the text inside that tag is rendered by MentionUserRenderer that uses onPress event here

Basically for ios and android the Pressable that is used is the one in MentionUserRenderer and not the one in TaskPreview so the longPress event is never called (the context menu doesn't show)

What I can try to do is pass arguments to user-mention tag to be able to set up the onLongPress event directly in MentionUserRenderer

Signed-off-by: Pierre Michel <pmiche04@gmail.com>

abdulrahuman5196 · 2023-10-14T07:05:00Z

@ShogunFire This is already working for normally messages, how is it working there? Can we re-use the same logic here as well?

ShogunFire · 2023-10-14T11:28:15Z

Normal messages don't have onPress event. User mentions show the Details of the user when you click them.

Signed-off-by: Pierre Michel <pmiche04@gmail.com>

ShogunFire · 2023-10-26T17:46:01Z

@abdulrahuman5196 Sorry for the late update, so another PR tried to solve the issue with user mention here: #29648 . To work in our case it was just lacking a provider around TaskPreview which I added. Now everything should work fine. Ready for review

abdulrahuman5196 · 2023-10-30T13:01:34Z

Hi, @ShogunFire We have merge conflicts here?

Signed-off-by: Pierre Michel <pmiche04@gmail.com> # Conflicts: # src/components/ReportActionItem/TaskPreview.js

Signed-off-by: Pierre Michel <pmiche04@gmail.com>

ShogunFire · 2023-10-30T19:22:06Z

@abdulrahuman5196 I resolved the conflicts

Signed-off-by: Pierre Michel <pmiche04@gmail.com>

abdulrahuman5196 · 2023-10-31T11:26:54Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2023-10-31.at.4.54.40.PM.mp4

Android: mWeb Chrome

Screen.Recording.2023-10-31.at.4.34.31.PM.mp4

iOS: Native

Screen.Recording.2023-10-31.at.4.35.19.PM.mp4

iOS: mWeb Safari

Screen.Recording.2023-10-31.at.4.33.04.PM.mp4

MacOS: Chrome / Safari

Screen.Recording.2023-10-31.at.4.32.10.PM.mp4

MacOS: Desktop

Screen.Recording.2023-10-31.at.4.37.47.PM.mp4

abdulrahuman5196

Changes looks good and works well. Reviewers checklist is also complete.

All yours. @AndrewGable

🎀 👀 🎀
C+ Reviewed

abdulrahuman5196 · 2023-11-02T10:13:26Z

Gentle ping @AndrewGable

OSBotify · 2023-11-02T16:20:18Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-11-06T22:33:52Z

🚀 Deployed to staging by https://github.com/AndrewGable in version: 1.3.96-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-11-09T22:51:25Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.96-15 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-11-10T15:48:21Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.97-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

ShogunFire added 4 commits July 21, 2023 15:52

Add longPress support for TaskPreview

68a36ae

Signed-off-by: Pierre Michel <pmiche04@gmail.com>

Add ControlSelection to imports

0efba40

Signed-off-by: Pierre Michel <pmiche04@gmail.com>

Merge branch 'main' into longPressForTaskPreviews

67c1539

Signed-off-by: Pierre Michel <pmiche04@gmail.com> # Conflicts: # src/components/ReportActionItem/TaskPreview.js

The merge was wrong

67125d1

Signed-off-by: Pierre Michel <pmiche04@gmail.com>

ShogunFire requested a review from a team as a code owner October 4, 2023 16:22

melvin-bot bot requested review from abdulrahuman5196 and removed request for a team October 4, 2023 16:22

ShogunFire added 2 commits October 4, 2023 11:09

We use chatReportID not chatReport

eb4fe93

Signed-off-by: Pierre Michel <pmiche04@gmail.com>

reportPropTypes is not used

eb985de

Signed-off-by: Pierre Michel <pmiche04@gmail.com>

Merge branch 'main' into longPressForTaskPreviews

0a733ff

Signed-off-by: Pierre Michel <pmiche04@gmail.com>

ShogunFire added 2 commits October 26, 2023 13:58

Merge remote-tracking branch 'origin/main' into longPressForTaskPreviews

ecdc42c

Signed-off-by: Pierre Michel <pmiche04@gmail.com>

Adding the provider for context menu around task preview

1976e13

Signed-off-by: Pierre Michel <pmiche04@gmail.com>

ShogunFire added 2 commits October 30, 2023 16:14

Merge remote-tracking branch 'origin/main' into longPressForTaskPreviews

1f8290f

Signed-off-by: Pierre Michel <pmiche04@gmail.com> # Conflicts: # src/components/ReportActionItem/TaskPreview.js

Merge was wrong

61da9cd

Signed-off-by: Pierre Michel <pmiche04@gmail.com>

ShogunFire added 2 commits October 30, 2023 16:35

Improve the imports for lint

58cecfa

Signed-off-by: Pierre Michel <pmiche04@gmail.com>

After npm run prettier

6d8043a

Signed-off-by: Pierre Michel <pmiche04@gmail.com>

abdulrahuman5196 approved these changes Oct 31, 2023

View reviewed changes

melvin-bot bot requested a review from AndrewGable October 31, 2023 11:33

AndrewGable approved these changes Nov 2, 2023

View reviewed changes

AndrewGable merged commit fdfa3f2 into Expensify:main Nov 2, 2023
12 checks passed

abzokhattab mentioned this pull request Nov 3, 2023

[$500] Task - Long tap on task assignee crashes the app #30799

Closed

6 tasks

OSBotify mentioned this pull request Nov 6, 2023

Deploy Checklist: New Expensify 2023-11-06 #30929

Closed

OSBotify mentioned this pull request Nov 8, 2023

Deploy Checklist: New Expensify 2023-11-08 #31077

Closed

abdulrahuman5196 mentioned this pull request Nov 17, 2023

[$1000] mWeb - Long pressing assignee of task not working properly #23026

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Show the context menu when we long press assignee of a task #28840

Show the context menu when we long press assignee of a task #28840

ShogunFire commented Oct 4, 2023 •

edited

Loading

melvin-bot bot commented Oct 4, 2023

abdulrahuman5196 commented Oct 5, 2023 •

edited

Loading

ShogunFire commented Oct 6, 2023

abdulrahuman5196 commented Oct 10, 2023

ShogunFire commented Oct 10, 2023

abdulrahuman5196 commented Oct 12, 2023

ShogunFire commented Oct 12, 2023

abdulrahuman5196 commented Oct 13, 2023 •

edited

Loading

ShogunFire commented Oct 13, 2023 •

edited

Loading

abdulrahuman5196 commented Oct 14, 2023

ShogunFire commented Oct 14, 2023

ShogunFire commented Oct 26, 2023 •

edited

Loading

abdulrahuman5196 commented Oct 30, 2023

ShogunFire commented Oct 30, 2023

abdulrahuman5196 commented Oct 31, 2023 •

edited

Loading

abdulrahuman5196 left a comment

abdulrahuman5196 commented Nov 2, 2023

OSBotify commented Nov 2, 2023

OSBotify commented Nov 6, 2023

OSBotify commented Nov 9, 2023

OSBotify commented Nov 10, 2023

Show the context menu when we long press assignee of a task #28840

Show the context menu when we long press assignee of a task #28840

Conversation

ShogunFire commented Oct 4, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Oct 4, 2023

abdulrahuman5196 commented Oct 5, 2023 • edited Loading

ShogunFire commented Oct 6, 2023

abdulrahuman5196 commented Oct 10, 2023

ShogunFire commented Oct 10, 2023

abdulrahuman5196 commented Oct 12, 2023

ShogunFire commented Oct 12, 2023

abdulrahuman5196 commented Oct 13, 2023 • edited Loading

ShogunFire commented Oct 13, 2023 • edited Loading

abdulrahuman5196 commented Oct 14, 2023

ShogunFire commented Oct 14, 2023

ShogunFire commented Oct 26, 2023 • edited Loading

abdulrahuman5196 commented Oct 30, 2023

ShogunFire commented Oct 30, 2023

abdulrahuman5196 commented Oct 31, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

abdulrahuman5196 left a comment

Choose a reason for hiding this comment

abdulrahuman5196 commented Nov 2, 2023

OSBotify commented Nov 2, 2023

OSBotify commented Nov 6, 2023

OSBotify commented Nov 9, 2023

OSBotify commented Nov 10, 2023

ShogunFire commented Oct 4, 2023 •

edited

Loading

abdulrahuman5196 commented Oct 5, 2023 •

edited

Loading

abdulrahuman5196 commented Oct 13, 2023 •

edited

Loading

ShogunFire commented Oct 13, 2023 •

edited

Loading

ShogunFire commented Oct 26, 2023 •

edited

Loading

abdulrahuman5196 commented Oct 31, 2023 •

edited

Loading