Deploy Checklist: New Expensify 2023-11-08

[OSBotify]

Release Version: 1.3.97-7
Compare Changes: production...staging

This release contains changes from the following pull requests:

• Theme switching: Add TypeScript types #24178
• [No QA] Only one active deploy at a time #27399
• [No QA] [TS migration] Migrate 'PersonalDetails.js' lib to TypeScript #28269
• Fix/27165: don't allow go to next step if empty waypoint #28308
• Create Copilot page #28361
• perf: refactor heavy operations when user starts to type #28469
• [NoQA] Add Spanish accessibility translation for floating action button #28703
• [No QA][TS migration] Migrate 'Clipboard' lib to TypeScript #28789
• ##23220 WEB maintainVisibleContentPosition #28793
• Show the context menu when we long press assignee of a task #28840
• Update The-Expenses-Page.md #29037
• [NoQA] Bump onyx - Fix out of order updates #29169
• [No QA] [TS migration] Migrate 'useKeyboardShortcut.js' hook to TypeScript #29226
• Fix/28925: Anonymous user can edit profile #29248
• [TS migration] Migrate 'useCurrentReportID.js' hook to TypeScript #29264
• Close Account on Mobile #29522
• [No QA][TS migration] Migrate 'withToggleVisibilityView.js' HOC to TypeScript #29559
• Composer - optimise rendering behaviour for onKeyPress & onSubmit #29561
• [No QA] [TS migration] Migrate 'LinearGradient' component to TypeScript #29580
• Update CSV-Import.md #29584
• Fix for Not found page appearing for private notes list, view and edit pages in deep link #29636
• [TS migration] Migrate 'Localize' lib to TypeScript  #29742
• [TS migration] Migrate 'SafeAreaConsumer.js' component to TypeScript #29755
• Remove error when all workspace is deleted #29781
• [No QA] [TS migration] Migrate 'PopoverProvider' component to TypeScript #29857
• Update Expensify-Playbook-For-Small-To-Medium-Sized-Businesses.md #29907
• [TS migration] Migrate 'FullscreenLoadingIndicator.js' component to TypeScript #29988
• Fix: android pdf scrolling issue #30050
• [No QA] [TS migration] Migrate 'withNavigationFallback.js' HOC to TypeScript #30072
• [TS migration] Migrate 'OpacityView.js' component to TypeScript #30074
• [TS migration] Migrate 'SelectCircle.js' component to TypeScript #30077
• Use OSBotify App token in additional workflows #30106
• Fix/27544 Incorrect Old Dot comment formatting when viewed on New Dot #30193
• feat: new emoji font for Windows #30201
• fix: regression 29888 #30231
• refactor: LHN dataflow rework #30242
• Create Fringe-Benefits.md #30245
• Limit report routes in the customStackNavigator #30279
• Update error flow for prevent splitting bill with workspace and additional participants #30302
• [Perf] ReportScreen rendering optimisation part 2 #30354
• [Form Provider Refactor] WorkspaceSettingsPage #30355
• Update Categories.md #30358
• feat: add whitespace after inserting emoji via native keyboard #30412
• [Form Provider Refactor] KnowATeacherPage #30434
• [No QA] [TS migration] Migrate 'SVGImage' component to TypeScript #30443
• ignore currency symbol for tbd #30459
• Move QRCode component out of the folder #30480
• [DEV] E2e/add typing tests #30502
• Remove last few report.managerEmail uses #30515
• Fix: Add Empty State Background To Tasks #30516
• Update and rename File-A-Dispute.md to Dispute-A-Transaction.md #30524
• Fix avatar of the report action is not displayed properly if there is report preview action before it #30553
• fix: 30268 The keyboard closes after a moment when tapping back button #30557
• Fix: 27902 Members - Invite message doesn't remain when User navigate back to Invite members page #30562
• [TS migration] Migrate 'InlineErrorText.js' component to TypeScript #30580
• Optimistically set achData to null when VBBA is deleted #30597
• Fix: invite and remove member when offline in workspace #30627
• [NoQA] feat: add perf tests for composer #30633
• Workspace settings page form error fix #30638
• remove unused TextPill.js file #30642
• Left line/border of quoted text is not visible when hovering over it in Notes #30653
• fix: Extra padding between bank account selector and ToS checkbox #30657
• Update Reimbursement.md #30661
• [NoQA] Update Teachers Unite by removing the '!' and capitalising the U #30667
• Fix arrow up on message deletion #30669
• Fix/30539: App crash when creating task #30670
• Fix: Merchant is not focused when back from search page #30675
• fix: private note draft not cleanup after saving #30688
• remove double onyx in profile page  #30694
• Fix: Wallet page does not update instantly when bank account is added or deleted #30700
• fix Android inconsistent pixel of +n triangle corner #30701
• fix "Sign in with Google" button jumping #30705
• Delete docs/articles/expensify-classic/expensify-card/Connect-To-Indi… #30711
• Delete docs/articles/expensify-classic/get-paid-back/Third-Party-Paym… #30713
• Delete docs/articles/expensify-classic/integrations/travel-integratio… #30714
• Delete docs/articles/expensify-classic/bank-accounts-and-credit-cards… #30715
• Delete docs/articles/expensify-classic/getting-started/Policy-Admins.md #30716
• Delete docs/articles/expensify-classic/getting-started/Best-Practices.md #30717
• Update and rename Personal-Credit-Cards.md to Personal-Cards.md #30718
• Update and rename Overview.md to Billing-Overview.md #30719
• [NoQA] Update and rename Card-Settings.md to Admin-Card-Settings-and-Feature… #30722
• Update and rename Adding-Users.md to Add-Members-to-your-Workspace.md #30723
• XOF currency not searchable by its second term #30735
• Only search USA address in address form #30745
• [HelpDot] Fix search styling #30748
• Fix: Whisper message displays in public room only after page refresh #30751
• fix: Distance: prevent unnecessary operations when adding an empty stop #30754
• Upgrade lottie-react-native to 6.4.0 #30772
• Fix: HeaderWithBackButton component shows error in storybook #30773
• Adds Violations Beta #30779
• [No QA] Add missing displayName to components #30784
• Update Approval-Workflows.md #30785
• fix 30211 #30787
• Bump expensify-common to not allow link with multiline alias text preceeded by header markdown #30808
• [CP Staging] Fix issue where displayed selected date is a day before actually selected date #30810
• Display public room in LHN #30814
• [CP Staging] Fix there is no assign task option on a task report #30816
• [CP Staging] fix regression copy to clipboard #30818
• Fix Out of Pocket Spend / Company Spend Totals calculation in NewDot #30820
• Fix EReceipt Color Hashing #30822
• Update Workday help to include custom field 1 and 2 #30828
• [CP Staging] fix: Green dot for money request is still displayed in spite of having deleted the workspace #30830
• Fix/30304: zipcode does not clear when country change #30831
• [CP Staging] fix: use parseISO instead od Date #30845
• [NoQA] Revert "perf: refactor heavy operations when user starts to type" #30852
• Update Attendee-Tracking.md #30853
• Fix ios and msafari to scroll text of edit message to bottom when click edit comment #30857
• Show displayName in IOU if the primary actor is a workspace #30862
• fix wrong last sender name in LHN after login #30872
• change font size for code block in H1 #30876
• fix: allow creating Distance request from expense reports #30881
• [CP Stag] fix an issue with min height of screen when Offline Indicator is shown #30887
• Make lint happy on main #30899
• Update CONTRIBUTING.md #30916
• Fix/30848: Reset hasOutstandingChildRequest to false after paying money #30918
• feat: replace more dates by parseISO #30923
• Update Expensify-Card-Perks.md #30926
• [ImgBot] Optimize images #30928
• [CP Staging] Fix app crash on Home Address Page #30959
• [CP Staging] fix: remove wrong use of createRef #30962
• [CP Staging] fix: displaying avatars in LHNOptionList #30965
• Fix: Billable switch does not have top padding #30970
• [CP Staging] Revert "Left line/border of quoted text is not visible when hovering over it in Notes" #30978
• fix: pdf send attachment regression #30995
• Revert "feat: add whitespace after inserting emoji via native keyboard" #31011
• [CP Staging] fix: 30988 New dot opens when navigate to the staging magic link, not abracadabra page #31014
• Update money request options for different room types #31025
• Fix wrong placeholder alignment and broken autofill #31044
• fix: No space between description & show more option #31048
• [CP Staging] Fix: New room page is misaligned after page transition #31063
• [CP Staging] Fix crash on staging with rendering html #31079
• [CP Staging] Fix: Cannot navigate by Tab key #31118
• [CP Staging] Money Request description input style refactor #31127
• [CP Staging] Move View wrapper to AttachmentViewPdf #31130
• Revert "Fix: Wallet page does not update instantly when bank account is added or deleted" #31153
• Revert "##23220 WEB maintainVisibleContentPosition" #31158
• [CP Staging] Fix/issue 31069 #31184

Deploy Blockers:

• [HOLD for payment 2023-11-21] [$500] Wrong position of payment method dropdown menu #31069
• The app crashes when user clicking on the avatar of Workspace #31078
• [HOLD for payment 2023-11-21] [HOLD for payment 2023-11-17] Chat - Concierge Avatar is not centered #31080
• [HOLD for payment 2024-01-31] Web - Chat - Cursor shows a hand instead of a text cursor "I" when hovering over text in code block #31085
• Workspace - Process is looped when attempting to split Distance request in workspace chat #31086
• [HOLD for payment 2023-11-27] Personal details - City and Postcode fields are not populated with suggested address #31091
• [HOLD for payment 2023-11-17] [$500] Chat - Pressing Tab closes emoji picker on Desktop or moves focus to the composer on Web #31098
• [HOLD for payment 2023-11-27] [$500] PDF preview - Eye icon to show password on password protected PDF file is not working #31101
• [WAITING ON CHECKLIST][HOLD for payment 2023-11-21] [$500] Attachment - File name is placed on the left of the preview page if add docx and mp4. #31103
• [$500] Conversation-Page gets scrolled everytime user taps back button #31106
• [$500] iOS - App - The name of the app is truncated and it's missing a space #31108
• [HOLD for payment 2023-11-21] [HOLD for payment 2023-11-17] [$500] Android-IOU-Description entered cannot be seen but displayed in IOU details page. #31114
• Web - Public room - Main chat view flickers when returning from thread and hovering over chat #31119
• Web - Chat - BackHandler console error shows up when refreshing the page #31120
• Android - Distance request - Cursor and preview are missing in description field #31132
• Web - Distance - The app starts flashing when any changes are made as the admin. #31139
• [$500] Web - IOU - App start flashing when any changes as the admin #31143
• [HOLD for payment 2023-12-07] [$500] Group chat - Cursor appears disabled briefly when opening user profile from group member view #31147
• Wallet - Loading spinner for Expensify wallet amount when changing default payment method #31149
• Web - Invite member - Inviting someone to a workspace is broken #31159
• [$1000] mWeb - Cannot open protected PDF in chat view while logged into an old account #31166

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
• I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

[kavimuru]

Checking off the following PRs from the past builds:
#24178
#28308
#28361
#28469
#28793
#28840
#29037
#29248
#29522
#29561
#29584
#29636
#29742
#29755
#29781
#29907
#29988
#30050
#30074
#30077
#30106
#30193
#30201
#30231
#30242
#30245
#30279
#30302
#30354
#30355
#30412
#30434
#30459
#30480
#30502
#30515
#30516
#30524
#30553
#30557
#30562
#30580
#30627
#30638
#30642
#30653
#30657
#30661
#30669
#30670
#30675
#30688
#30700
#30701
#30705
#30711
#30713
#30714
#30715
#30716
#30717
#30718
#30719
#30723
#30735
#30745
#30748
#30751
#30754
#30772
#30773
#30779
#30785
#30787
#30810
#30814
#30816
#30818
#30820
#30822
#30828
#30830
#30831
#30845
#30853
#30857
#30862
#30872
#30887
#30899
#30916
#30918
#30923
#30926
#30928
#30959
#30965
#30995
#31011
#31014

[OSBotify]

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.3.97-0 🚀

[kavimuru]

Regression is at 77%.

[mountiny]

#31098 fixed in staging

[kavimuru]

@puneetlath in which build should we test the cps which are unchecked?

[mountiny]

@kavimuru when the cp is completed there should be a comment on the pr with the release number in which the change was deployed in

[kavimuru]

@mountiny Thanks ! It has been 18 hours and I don't see the release number #31079. So I wanted to double check.

[kavimuru]

@puneetlath Regression is completed.

Open Blockers:
#31069
#31085
#31091
#31103
#31106
#31108
#31114
#31139
#31143
#31149

[puneetlath]

Thanks @kavimuru!

[kavimuru]

We are waiting for the release version of the build to validate the cps.

[puneetlath]

The latest staging version is 1.3.97-4

[puneetlath]

The commenting on the PRs is broken for some reason, looking into that.

[kavimuru]

@puneetlath can we go ahead and validate all the 3 cps in 1.3.97-4 build?

[puneetlath]

Yes please!

[puneetlath]