[$500] Conversation-Page gets scrolled everytime user taps back button

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.3.97-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation: @

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Tap on a report which has manual request created with receipt
3. Tap on IOU and navigate to IOU detail page
4. Tap on receipt
5. Tap app's back button twice
6. Note IOU report page gets scrolled
7. Again tap app's back button
8. Note 1:1DM page gets scrolled

Expected Result:

When user taps app's back button, the 1:1DM and IOU report page must not get scrolled.

Actual Result:

Everytime user taps app's back button, the 1:1DM and IOU report page gets scrolled.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6269680_1699519346376.scrl.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~017921447fb2922a05
• Upwork Job ID: 1722563222139772928
• Last Price Increase: 2023-11-09

[melvin-bot]

Triggered auto assignment to @NicMendonca (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~017921447fb2922a05

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @MariaHCD (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[MariaHCD]

Trying to find out if a specific PR caused this: https://expensify.slack.com/archives/C01GTK53T8Q/p1699527511463139?thread_ts=1699526175.326109&cid=C01GTK53T8Q

[MariaHCD]

Able to reproduce the issue:

XRecorder_09112023_184943.mp4

[MariaHCD]

Honestly, it's a bit tough to repro locally on an android emulator so I can't confirm if that reverting that PR fixes it. And I don't think we currently have a solution to allow testing Android mWeb on a physical device since the hostname change. I think we should fix this but I don't necessarily think this should block the deploy.

Any thoughts here @eVoloshchak?

[mountiny]

Discussed in the slack thread, this seems like it might stem from the RNW update and some change in how that handles the autoscrollToTopThreshold property on the chat list, we can treat this as a normal bug

https://expensify.slack.com/archives/C01GTK53T8Q/p1699526175326109

[MariaHCD]

Thanks, @mountiny! We're open for proposals here.

[artus9033]

Hi, I'm Artur from Callstack - expert contributor group - and I would like to work on this issue.

[melvin-bot]

The BZ member will need to manually hire artus9033 for the Contributor role. Please store your Upwork details and apply to our Upwork job so this process is automatic in the future!

[melvin-bot]

@eVoloshchak, @artus9033, @MariaHCD, @NicMendonca Eep! 4 days overdue now. Issues have feelings too...

[eVoloshchak]

Not overdue, looks like we're waiting for a proposal from @artus9033

[melvin-bot]

@eVoloshchak @artus9033 @MariaHCD @NicMendonca this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[MariaHCD]

@artus9033 any updates on a proposal here?

[artus9033]

Sorry, I focused on other issues on my radar, but I will investigate and report by tomorrow.

[artus9033]

Seems like I still can't reproduce it @MariaHCD . I tried on Android mWeb Chrome in simulator and iOS Safari in simulator, and finally on a physical Android device running newest Chrome, and on each one of them the screen maintains the scrolling position, thus there is no such an overscroll behaviour like in your recording - would you check on my reproduction attempt in the attached video? Also, can you still reproduce the problem with the current main?

Screen_Recording_20231128_222609_Chrome.mp4

[melvin-bot]

@eVoloshchak @artus9033 @MariaHCD @NicMendonca this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ and will need to go internal. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

[MariaHCD]

I retested on a physical Android device and I'm getting the same behavior as you @artus9033. It looks like the keyboard is now being opened when the back button is pressed so the scrolling issue doesn't seem to be happening anymore:

XRecorder_01122023_102951.mp4

@izarutskaya Could you retest and let us know what you find?

[MariaHCD]

@izarutskaya if you could please retest to see if this is still an issue? 🙏🏼

[melvin-bot]

@eVoloshchak @artus9033 @MariaHCD @NicMendonca this issue is now 4 weeks old and preventing us from maintaining WAQ, can you:

• Decide whether any proposals currently meet our guidelines and can be approved as-is today
• If no proposals meet that standard, please take this issue internal and treat it as one of your highest priorities
• If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

[melvin-bot]

Current assignee @eVoloshchak is eligible for the Internal assigner, not assigning anyone new.

[MariaHCD]

@izarutskaya let's retest this one to see if it's still an issue.

[melvin-bot]

@eVoloshchak, @artus9033, @MariaHCD, @NicMendonca Whoops! This issue is 2 days overdue. Let's get this updated quick!

[MariaHCD]

From my tests, I wasn't able to reproduce the issue on mWeb Android. I think we are okay to close this for now.