[HOLD for payment 2023-11-21] [HOLD for payment 2023-11-17] [$500] Android-IOU-Description entered cannot be seen but displayed in IOU details page.

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.3.97-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation: @

Action Performed:

1. Launch app
2. Tap fab
3. Tap request money
4. Tap manual
5. Enter an amount
6. Tap next
7. Select an user
8. Tap 3 dots and tap "add receipt"
9. Tap Request
10. Tap IOU to open IOU details page
11. Tap description
12. Enter any text
13. Tap save

Expected Result:

User must be able to see description entered.

Actual Result:

Description entered cannot be seen but displayed in IOU details page.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6269794_1699526647153.android.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~018aa91dfca07b2ed6
• Upwork Job ID: 1722580951529140224
• Last Price Increase: 2023-11-09
• Automatic offers:
• esh-g | Contributor | 27594134
• akinwale | Contributor | 27594656

Issue Owner

Current Issue Owner: @mallenexpensify

Issue Owner

Current Issue Owner: @mallenexpensify

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~018aa91dfca07b2ed6

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (External)

[izarutskaya]

Not reproduced in production

Screen_Recording_20231109_183146_New.Expensify.mp4

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @mountiny (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[esh-g]

Proposal

Available to raise a PR quickly!

Please re-state the problem we are trying to solve

Android-IOU-Description entered cannot be seen but displayed in IOU details page

What is the root cause?

verticalAlignTop is passed like this in MoneyRequestDescription:

containerStyles={[styles.autoGrowHeightMultilineInput, styles.verticalAlignTop]}

App/src/pages/iou/MoneyRequestDescriptionPage.js

Line 143 in 9862a3e

containerStyles={[styles.autoGrowHeightMultilineInput, styles.verticalAlignTop]}

This means the container gets aligned to top and not the input itself.

What changes should be made to fix this?

We should pass it as an input style:

containerStyles={[styles.autoGrowHeightMultilineInput]}
inputStyle={[styles.verticalAlignTop]}

Just like we do here:

App/src/pages/tasks/TaskDescriptionPage.js

Lines 111 to 112 in 9862a3e

	containerStyles={[styles.autoGrowHeightMultilineInput]}
	inputStyle={[styles.verticalAlignTop]}

[ZhenjaHorbach]

In addition to the first proposition
Judging by the code
We have the same bug on EditRequestDescriptionPage too

App/src/pages/EditRequestDescriptionPage.js

Line 78 in 9862a3e

containerStyles={[styles.autoGrowHeightMultilineInput, styles.verticalAlignTop]}

Therefore, it would be good to fix it in two places at once

[melvin-bot]

📣 @Santhosh-Sellavel Please request via NewDot manual requests for the Reviewer role ($500)

[melvin-bot]

📣 @esh-g 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[mountiny]

@esh-g can you please raise the PR as quickly as possbile? thanks!

[esh-g]

Yes @mountiny Just working on it now

[esh-g]

PR is here: #31127
@mountiny

[melvin-bot]

📣 @akinwale 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[mountiny]

Requesting a CP, @esh-g could you please identify which PR caused this regression?

[aimane-chnaif]

#16660 was linked but I don't see any comment which referenced this.
I thought similar bug to composer text align issue we fixed before.

[esh-g]

Yes, the PR that caused this issue is this: #24482
(don't think a regression test is needed for this)

[mountiny]

Ok thanks!

[puneetlath]

Fix was CP'd. Removing the blocker label.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.97-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Money Request description input style refactor #31127

If no regressions arise, payment will be issued on 2023-11-17. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @akinwale requires payment offer (Contributor)
• @esh-g requires payment offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@akinwale] The PR that introduced the bug has been identified. Link to the PR:
• [@akinwale] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@akinwale] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@akinwale] Determine if we should create a regression test for this bug.
• [@akinwale] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@mallenexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.98-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Money Request description input style refactor #31127

If no regressions arise, payment will be issued on 2023-11-21. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @akinwale requires payment offer (Contributor)
• @esh-g requires payment offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@akinwale] The PR that introduced the bug has been identified. Link to the PR:
• [@akinwale] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@akinwale] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@akinwale] Determine if we should create a regression test for this bug.
• [@akinwale] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@mallenexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[akinwale]

• [@akinwale] The PR that introduced the bug has been identified. Link to the PR:
• [@akinwale] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@akinwale] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

The issue here was as a result of the react-native-web update done in #24482, not due to a feature implementation nor code changes.

• [@akinwale] Determine if we should create a regression test for this bug.
• [@akinwale] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression test

1. Launch the Expensify app.
2. Navigate to an existing money request or create a new one, ensuring that a description is provided before saving.
3. Tap on the description to edit.
4. Verify that the description text is visible in the text input field.
5. Verify that the description text is editable.

Do we agree 👍 or 👎?

[akinwale]

@mallenexpensify Just noting here that the correct payment date here should be 2013-11-17, since the PR was initially deployed to production on 2023-11-10. Thanks.

[mallenexpensify]

Contributor: @esh-g paid $500 via Upwork
Contributor+: @akinwale paid $500 via Upwork

Regression test update

• https://github.com/Expensify/Expensify/issues/337591

Thanks!