Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[$3500] Upgrade to react-native-web v0.19.6 or greater #16660

Closed
roryabraham opened this issue Mar 29, 2023 · 100 comments
Closed

[$3500] Upgrade to react-native-web v0.19.6 or greater #16660

roryabraham opened this issue Mar 29, 2023 · 100 comments
Assignees
@kevinksullivan @roryabraham @getusha @aimane-chnaif
Labels
Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review Task Weekly KSv2

Comments

@roryabraham
Copy link
Contributor

roryabraham commented Mar 29, 2023 •
edited
Loading

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Problem

There are a number of initiatives and bug fixes that depend on React Native 0.19. We can aggregate those all here:

Solution

Upgrade E/App to use react-native-web 0.19.

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01a99afc2bafb0eada
  • Upwork Job ID: 1668778453001940992
  • Last Price Increase: 2023-12-01
  • Automatic offers:
    • aimane-chnaif | Reviewer | 26072994
    • getusha | Contributor | 26072996
Issue OwnerCurrent Issue Owner: @kevinksullivan
@roryabraham roryabraham self-assigned this Mar 29, 2023
@roryabraham
Copy link
Contributor Author

I synced our fork with the upstream yesterday, so our fork officially contains the 0.19 code. It's not published yet though. Assigning to myself to publish our react-native-web fork when this comes off HOLD.

@roryabraham roryabraham mentioned this issue Mar 29, 2023
Closed
1 task
@parasharrajat
Copy link
Member

This is a big move but a good one. A lot of refactoring might be needed as many things have been changed https://github.com/necolas/react-native-web/releases/tag/0.19.0. Happy to help if needed.

@melvin-bot melvin-bot bot added the Overdue label Apr 6, 2023
@roryabraham
Copy link
Contributor Author

We had a couple of VirtualizedList fixes from #12054 included in 19.2 🎉

@melvin-bot melvin-bot bot removed the Overdue label Apr 12, 2023
@roryabraham roryabraham mentioned this issue Apr 12, 2023
Closed
@melvin-bot melvin-bot bot added the Overdue label Apr 21, 2023
@christianwen christianwen mentioned this issue Apr 21, 2023
Open
@roryabraham
Copy link
Contributor Author

Still on HOLD

@melvin-bot melvin-bot bot removed the Overdue label Apr 24, 2023
@ntdiary ntdiary mentioned this issue Apr 26, 2023
Closed
1 task
@koko57 koko57 mentioned this issue Apr 28, 2023
Closed
6 tasks
@melvin-bot melvin-bot bot added the Overdue label May 2, 2023
@roryabraham
Copy link
Contributor Author

Still on HOLD

@melvin-bot melvin-bot bot removed the Overdue label May 2, 2023
@cristipaval
Copy link
Contributor

cristipaval commented May 3, 2023 •
edited
Loading

FYI: I added one more issue in the Problem statement, in the list of the issues held on this one.

@melvin-bot melvin-bot bot added the Overdue label May 11, 2023
@fedirjh fedirjh mentioned this issue May 23, 2023
Closed
6 tasks
@roryabraham
Copy link
Contributor Author

No update here, still on HOLD for the Accessible Pressables project, which is making steady progress. Technically we don't need to complete the project, we just need to get to a point where there's no more Touchable components.

@melvin-bot melvin-bot bot removed the Overdue label May 23, 2023
@janicduplessis
Copy link
Contributor

I opened a PR to sync again, this will unblock #19345 as one of the new release fixes an issue with batchSize > 1 and inverted FlatList.

@roryabraham What is the reason for the hold on the pressables project?

@roryabraham
Copy link
Contributor Author

I believe RNW 0.19 removed all the Touchable components, so we just need to finish migrating all our our Touchables to the new Pressable components, then we can upgrade to 0.19

@janicduplessis
Copy link
Contributor

I just verified and they got deprecated and not removed so it could still be usable before the Touchable migration project is done. We could add the warning to logbox ignore list until the migration is over.

@melvin-bot melvin-bot bot added the Overdue label Jun 8, 2023
@roryabraham
Copy link
Contributor Author

At this point, there are only 5 remaining Touchable components across the app, so let's just finish that migration then take this off hold early next week

@melvin-bot melvin-bot bot removed the Overdue label Jun 9, 2023
@roryabraham roryabraham added the Weekly KSv2 label Oct 13, 2023
@arthurmfgtab
Copy link
Contributor

Hey, I'm Arthur from Callstack and I'll start working on this 🙋

@getusha
Copy link
Contributor

getusha commented Oct 23, 2023

@arthurmfgtab there is a PR #24482 already, we just need some help here #24482 (comment)

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Oct 30, 2023
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Nov 8, 2023

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Nov 8, 2023
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Nov 9, 2023

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Nov 9, 2023

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Nov 9, 2023

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Nov 9, 2023

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@aimane-chnaif aimane-chnaif mentioned this issue Nov 9, 2023
Closed
6 tasks
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Nov 9, 2023

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@iwiznia
Copy link
Contributor

iwiznia commented Nov 20, 2023

What's the state of this?

@getusha
Copy link
Contributor

getusha commented Nov 20, 2023

@iwiznia PR is already deployed to prod, it is awaiting a payment
cc @roryabraham @mountiny @kevinksullivan

@iwiznia
Copy link
Contributor

iwiznia commented Nov 20, 2023

Oh nice! Can I unhold #10731 then?

@getusha
Copy link
Contributor

getusha commented Nov 20, 2023

@iwiznia Yeah, we are now using react-native-web 0.19+ version https://github.com/Expensify/App/blob/main/package.json#L161 and inputMode is supported.

@aimane-chnaif
Copy link
Contributor

@kevinksullivan this is ready for payment too.
Here's summary

@roryabraham roryabraham changed the title [$2000] Upgrade to react-native-web v0.19.6 or greater [$3500] Upgrade to react-native-web v0.19.6 or greater Dec 1, 2023
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Dec 1, 2023

Upwork job price has been updated to $3500

@roryabraham
Copy link
Contributor Author

Updating the bounty to $3500 as this was a larger issue with many sub-issues and conflicts

@roryabraham roryabraham removed the Reviewing Has a PR in review label Dec 1, 2023
@kevinksullivan
Copy link
Contributor

Payments made

@github-project-automation github-project-automation bot moved this from HIGH to Done in [#whatsnext] #quality Dec 1, 2023
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 labels Dec 20, 2023
@roryabraham roryabraham mentioned this issue Dec 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kevinksullivan kevinksullivan

@roryabraham roryabraham

@getusha getusha

@aimane-chnaif aimane-chnaif

Labels
Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review Task Weekly KSv2
Projects
[#whatsnext] #quality
Status: Done
Milestone
No milestone
Development

No branches or pull requests