Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] Web - IOU - App start flashing when any changes as the admin #31143

Closed
1 of 6 tasks
izarutskaya opened this issue Nov 9, 2023 · 13 comments
Closed
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Reviewing Has a PR in review Weekly KSv2

Comments

@izarutskaya
Copy link

izarutskaya commented Nov 9, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v1.3.97-2
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation: @

Action Performed:

Precondition:
Create IOU with the receipt as employee

  1. Log in as the workspace admin
  2. Navigate to the workspace chat with the employee
  3. Navigate to the request conversation and fix the errors as the admin

Expected Result:

The admin is able to edit the missing information. Nothing strange doesn't happen.

Actual Result:

The admin is able to edit the missing information. Nothing strange doesn't happen.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6270184_1699546803287.flash.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0196a9e3104ad62434
  • Upwork Job ID: 1722653994643566592
  • Last Price Increase: 2023-11-09
@izarutskaya izarutskaya added DeployBlockerCash This issue or pull request should block deployment External Added to denote the issue can be worked on by a contributor Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Nov 9, 2023
@melvin-bot melvin-bot bot changed the title Web - IOU - App start flashing when any changes as the admin [$500] Web - IOU - App start flashing when any changes as the admin Nov 9, 2023
Copy link

melvin-bot bot commented Nov 9, 2023

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Copy link

melvin-bot bot commented Nov 9, 2023

Job added to Upwork: https://www.upwork.com/jobs/~0196a9e3104ad62434

Copy link

melvin-bot bot commented Nov 9, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Nov 9, 2023
Copy link

melvin-bot bot commented Nov 9, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Nov 9, 2023
@OSBotify
Copy link
Contributor

OSBotify commented Nov 9, 2023

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Nov 9, 2023

Triggered auto assignment to @dangrous (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

Copy link

melvin-bot bot commented Nov 9, 2023

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@dangrous
Copy link
Contributor

dangrous commented Nov 9, 2023

git bisect weirdly did not help here, trying some other ways

@dangrous
Copy link
Contributor

dangrous commented Nov 9, 2023

It feels like this might be related? #28793

I coudl replicate this on local for a moment and now I can't anymore so weird stuff is happening

@dangrous
Copy link
Contributor

dangrous commented Nov 9, 2023

okay confirmed, removing src/components/FlatList/index.web.js (which was added in #28793) fixes this. The PR mentions that there will be "glitches" until an upstream PR is fixed, I think we might want to revert until that time? Will copy this on the PR.

@puneetlath
Copy link
Contributor

Yes, I agree. I think we need to revert as these glitches are not minor.

@melvin-bot melvin-bot bot added Reviewing Has a PR in review and removed Hourly KSv2 labels Nov 9, 2023
@melvin-bot melvin-bot bot added the Weekly KSv2 label Nov 9, 2023
@puneetlath
Copy link
Contributor

The PR that caused this ended up getting reverted. Removing the deploy blocker label.

@puneetlath puneetlath removed the DeployBlockerCash This issue or pull request should block deployment label Nov 10, 2023
@dangrous
Copy link
Contributor

Closing, will handle on the updated PR for #23220

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

No branches or pull requests

6 participants