Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HOLD for payment 2024-01-18] Fix FlatList jumping #23220

Closed
roryabraham opened this issue Jul 19, 2023 · 24 comments
Closed

[HOLD for payment 2024-01-18] Fix FlatList jumping #23220

roryabraham opened this issue Jul 19, 2023 · 24 comments
Assignees
@perunt
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering Weekly KSv2

Comments

@roryabraham
Copy link
Contributor

Part of the Comment Linking project

Main issue: #20282
Doc section: https://docs.google.com/document/d/1v-ZaIRTZL5LIsyPWB0IopBNNgCajf5WC1OA8cVKtd8I/edit#bookmark=id.bry74gx446k1
Project: Comment Linking

Address the noticeable jumps in the list when scrolling and simultaneously adding items from the bottom of the list. This fix will be applied on both native and web sides.

Manual Test Steps

TBD

#Automated Tests
TBD – probably none
@roryabraham
Copy link
Contributor Author

cc @perunt

@roryabraham roryabraham mentioned this issue Jul 19, 2023
Closed
@perunt
Copy link
Contributor

perunt commented Jul 20, 2023

Here we go! 🚀

@perunt
Copy link
Contributor

perunt commented Jul 25, 2023 •
edited
Loading

I re-tested this with a large dataset, and I can confirm that it's now sliding significantly less. I noticed that in version 0.72.1, the react-test-renderer was removed from the runtime, which seems to have improved things. When using a single item render per batch, it functions kinda ok(similar to previous performance levels). As such, I don't believe we need to make any changes here. And we can hop on the next steps.
Here video
@roryabraham , wdyt?

@roryabraham
Copy link
Contributor Author

Sounds good. Hopefully we'll get much better performance (and no scroll-jumps) when we integrate WishList

perunt added a commit to margelo/expensify-app-fork that referenced this issue Sep 6, 2023
@perunt
Merge branch 'main' of https://github.com/margelo/expensify-app-fork …
89fefbf 
…into feat/#Expensify#23220-bidirectional-pagination
perunt added a commit to margelo/expensify-app-fork that referenced this issue Sep 6, 2023
@perunt
Merge branch 'main' of https://github.com/Expensify/App into feat/#Ex…
741a3b9 
…pensify#23220-bidirectional-pagination
perunt added a commit to margelo/expensify-app-fork that referenced this issue Sep 6, 2023
@perunt
Merge branch 'main' of https://github.com/Expensify/App into feat/#Ex…
a82dc0f 
…pensify#23220-bidirectional-pagination
perunt added a commit to margelo/expensify-app-fork that referenced this issue Sep 6, 2023
@perunt
Merge branch 'main' of https://github.com/Expensify/App into feat/#Ex…
2619fa8 
…pensify#23220-bidirectional-pagination
perunt added a commit to margelo/expensify-app-fork that referenced this issue Sep 11, 2023
@perunt
Merge branch 'main' of https://github.com/Expensify/App into feat/#Ex…
3df7a19 
…pensify#23220-bidirectional-pagination
perunt added a commit to margelo/expensify-app-fork that referenced this issue Sep 11, 2023
@perunt
Merge branch 'main' of https://github.com/margelo/expensify-app-fork …
a480524 
…into feat/#Expensify#23220-bidirectional-pagination
perunt added a commit to margelo/expensify-app-fork that referenced this issue Sep 15, 2023
@perunt
Merge branch 'main' of https://github.com/margelo/expensify-app-fork …
694c423 
…into feat/#Expensify#23220-bidirectional-pagination
perunt added a commit to margelo/expensify-app-fork that referenced this issue Sep 19, 2023
@perunt
Merge branch 'main' of https://github.com/margelo/expensify-app-fork …
e6f23df 
…into feat/#Expensify#23220-bidirectional-pagination
perunt added a commit to margelo/expensify-app-fork that referenced this issue Sep 19, 2023
@perunt
Merge branch 'main' of https://github.com/margelo/expensify-app-fork …
045b07d 
…into feat/#Expensify#23220-bidirectional-pagination
perunt added a commit to margelo/expensify-app-fork that referenced this issue Sep 20, 2023
@perunt
Merge branch 'main' of https://github.com/margelo/expensify-app-fork …
063ef90 
…into feat/#Expensify#23220-bidirectional-pagination
perunt added a commit to margelo/expensify-app-fork that referenced this issue Sep 21, 2023
@perunt
Merge branch 'main' of https://github.com/margelo/expensify-app-fork …
bde5a21 
…into feat/#Expensify#23220-bidirectional-pagination
perunt added a commit to margelo/expensify-app-fork that referenced this issue Sep 21, 2023
@perunt
Merge branch 'main' into feat/#Expensify#23220-bidirectional-pagination
821adb8
perunt added a commit to margelo/expensify-app-fork that referenced this issue Sep 21, 2023
@perunt
Merge branch 'feat/#Expensify#23220-bidirectional-pagination' of http…
652967c 
…s://github.com/margelo/expensify-app-fork into feat/#Expensify#23220-bidirectional-pagination
perunt added a commit to margelo/expensify-app-fork that referenced this issue Sep 22, 2023
@perunt
Merge branch 'main' of https://github.com/Expensify/App into feat/#Ex…
84cb84c 
…pensify#23220-bidirectional-pagination
perunt added a commit to margelo/expensify-app-fork that referenced this issue Sep 22, 2023
@perunt
Merge branch 'main' of https://github.com/Expensify/App into feat/#Ex…
1829ade 
…pensify#23220-bidirectional-pagination
perunt added a commit to margelo/expensify-app-fork that referenced this issue Sep 25, 2023
@perunt
Merge branch 'main' of https://github.com/Expensify/App into feat/#Ex…
063af42 
…pensify#23220-bidirectional-pagination
perunt added a commit to margelo/expensify-app-fork that referenced this issue Sep 28, 2023
@perunt
Merge branch 'main' of https://github.com/Expensify/App into feat/#Ex…
7dfc82e 
…pensify#23220-bidirectional-pagination
perunt added a commit to margelo/expensify-app-fork that referenced this issue Oct 2, 2023
@perunt
Merge branch 'main' of https://github.com/Expensify/App into feat/#Ex…
6839c22 
…pensify#23220-bidirectional-pagination
perunt added a commit to margelo/expensify-app-fork that referenced this issue Oct 4, 2023
@perunt
Merge branch 'main' of https://github.com/Expensify/App into feat/#Ex…
c1201d5 
…pensify#23220-bidirectional-pagination
perunt added a commit to margelo/expensify-app-fork that referenced this issue Oct 5, 2023
@perunt
Merge branch 'main' of https://github.com/Expensify/App into feat/#Ex…
f0ae93f 
…pensify#23220-bidirectional-pagination
perunt added a commit to margelo/expensify-app-fork that referenced this issue Oct 5, 2023
@perunt
Merge branch 'feat/#Expensify#23220-bidirectional-pagination' of http…
0895706 
…s://github.com/margelo/expensify-app-fork into feat/#Expensify#23229-linking
perunt added a commit to margelo/expensify-app-fork that referenced this issue Dec 30, 2023
@perunt
Merge branch 'main' of https://github.com/Expensify/App into feat/#Ex…
ee09b8a 
…pensify#23220-web-maintainVisibleContentPosition
perunt added a commit to margelo/expensify-app-fork that referenced this issue Dec 30, 2023
@perunt
Merge branch 'feat/#Expensify#23220-web-maintainVisibleContentPositio…
d001638 
…n' of https://github.com/margelo/expensify-app-fork into feat/#Expensify#23229-linking
perunt added a commit to margelo/expensify-app-fork that referenced this issue Dec 31, 2023
@perunt
Merge branch 'main' of https://github.com/Expensify/App into feat/#Ex…
69ee59b 
…pensify#23220-web-maintainVisibleContentPosition
perunt added a commit to margelo/expensify-app-fork that referenced this issue Jan 2, 2024
@perunt
Merge branch 'main' of https://github.com/Expensify/App into feat/#Ex…
cb4e9b7 
…pensify#23220-web-maintainVisibleContentPosition
perunt added a commit to margelo/expensify-app-fork that referenced this issue Jan 4, 2024
@perunt
Merge branch 'main' of https://github.com/Expensify/App into feat/#Ex…
ae17f61 
…pensify#23220-web-maintainVisibleContentPosition
perunt added a commit to margelo/expensify-app-fork that referenced this issue Jan 5, 2024
@perunt
Merge branch 'main' of https://github.com/Expensify/App into feat/#Ex…
42ec7a7 
…pensify#23220-web-maintainVisibleContentPosition
perunt added a commit to margelo/expensify-app-fork that referenced this issue Jan 5, 2024
@perunt
Merge branch 'main' of https://github.com/Expensify/App into feat/#Ex…
54921a9 
…pensify#23220-web-maintainVisibleContentPosition
perunt added a commit to margelo/expensify-app-fork that referenced this issue Jan 8, 2024
@perunt
Merge branch 'feat/#Expensify#23220-web-maintainVisibleContentPositio…
7febd4a 
…n' of https://github.com/margelo/expensify-app-fork into feat/#Expensify#23229-linking
roryabraham added a commit that referenced this issue Jan 9, 2024
@roryabraham
Merge pull request #32098 from margelo/feat/##23220-web-maintainVisib…
4e25271 
…leContentPosition

HIGH: (Comment linking: step 2) [23220] WEB maintain visible content position
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Jan 10, 2024
@melvin-bot melvin-bot bot changed the title Fix FlatList jumping [HOLD for payment 2024-01-18] Fix FlatList jumping Jan 11, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Jan 11, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jan 11, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Jan 11, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.24-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-01-18. 🎊

For reference, here are some details about the assignees on this issue:

  • @perunt does not require payment (Contractor)

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Jan 17, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Jan 18, 2024

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Jan 29, 2024

@perunt 10 days overdue. I'm getting more depressed than Marvin.

@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Jan 31, 2024

@perunt 12 days overdue. Walking. Toward. The. Light...

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Feb 5, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Feb 5, 2024

This issue has not been updated in over 14 days. @perunt eroding to Weekly issue.

@melvin-bot melvin-bot bot removed the Overdue label Feb 5, 2024
@perunt
Copy link
Contributor

perunt commented Feb 6, 2024

Hey, it was merged a while ago. There will be another enhancement for the scrolling experience, but the original issue has been fixed. I guess we can close it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@perunt perunt

Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering Weekly KSv2
Projects
Comment Linking
Status: Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@dangrous @thienlnam @roryabraham @perunt