-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2023-11-02] Implement bidirectional pagination in ReportActionsList #23223
Comments
Triggered auto assignment to @sonialiap ( |
cc @perunt |
Triggered auto assignment to Design team member for new feature review - @shawnborton ( |
Here we go! 🚀 |
This issue has not been updated in over 15 days. @perunt eroding to Monthly issue. P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do! |
@perunt Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
@perunt 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it! |
1 similar comment
@perunt 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it! |
@perunt 10 days overdue. Is anyone even seeing these? Hello? |
It's not overdue, the PR is ready and waiting for another perf improvements PRs to be merged. |
@perunt Eep! 4 days overdue now. Issues have feelings too... |
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results. If a regression has occurred and you are the assigned CM follow the instructions here. If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future. |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.91-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2023-11-02. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
|
BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
@perunt Eep! 4 days overdue now. Issues have feelings too... |
Assigning new feature and @s77rt for C+ payment |
@sonialiap can you please issue C+ review payment to @s77rt then close this out? |
@s77rt offer sent |
Hi, How are you? |
📣 @webmaster1022! 📣
|
@webmaster1022 this issue has been resolved. Please check out the Open issues with the |
@sonialiap Accepted! Please make sure the payment is $125 (for two regressions: #30423 and #30729). Thanks! |
Thanks @s77rt , payment of $125 sent ✔️ |
HOLD on:
Part of the Comment Linking project
Main issue: #20282
Doc section: https://docs.google.com/document/d/1v-ZaIRTZL5LIsyPWB0IopBNNgCajf5WC1OA8cVKtd8I/edit#bookmark=id.tgiglcuu8pr9
Project: Comment Linking
For bidirectional scrolling, we need to enable the addition of new data to the chat from both ends. The top end utilizes built-in methods
onEndReachedThreshold
andonEndReached
. We need to start usingonStartReached
for the bottom end as well.We should call the
GetOlderActions
APIonEndReached
andGetNewerActions
APIonStartReached
.Also, this PR should enable the
CheckForPreviousReportActionID
migration being built here.Manual Test Steps
TBD
Automated Tests
TBD
Issue Owner
Current Issue Owner: @sonialiapThe text was updated successfully, but these errors were encountered: