Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Comment Linking! #23229

Closed
roryabraham opened this issue Jul 20, 2023 · 22 comments
Closed

Implement Comment Linking! #23229

roryabraham opened this issue Jul 20, 2023 · 22 comments
Assignees
@perunt
Labels
Engineering Monthly KSv2

Comments

@roryabraham
Copy link
Contributor

HOLD on #23223

Part of the Comment Linking project

Main issue: #20282
Doc section: https://docs.google.com/document/d/1v-ZaIRTZL5LIsyPWB0IopBNNgCajf5WC1OA8cVKtd8I/edit#bookmark=id.izionaowheco
Project: Comment Linking

Feature Description

In this issue, we should:

  • Configure deeplinking on a per-reportAction level
  • Create a function that will take already filtered by timestamp reportActions and filter them for gap detection using comparison by reportActionID and previousReportActionID.
  • Develop a function that accepts data and identifies where the gaps exist(from function described above). This function should carefully manage what part of the data should be passed to FlatList, ensuring seamless data management for bidirectional scrolling.
  • Positioning the linked message at the edge of the list, so it appears at the bottom of the screen.

Manual Test Steps

TBD

Automated Tests

TBD
This was referenced Jul 20, 2023
Closed
Closed
@perunt
Copy link
Contributor

perunt commented Jul 20, 2023

Here we go! 🚀

@melvin-bot melvin-bot bot added Monthly KSv2 and removed Weekly KSv2 labels Aug 21, 2023
@melvin-bot
Copy link

melvin-bot bot commented Aug 21, 2023

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

perunt added a commit to margelo/expensify-app-fork that referenced this issue Oct 2, 2023
@perunt
Merge branch 'main' of https://github.com/Expensify/App into feat/#Ex…
2b2fd86 
…pensify#23229-linking
perunt added a commit to margelo/expensify-app-fork that referenced this issue Oct 4, 2023
@perunt
Merge branch 'main' of https://github.com/Expensify/App into feat/#Ex…
4f42f2a 
…pensify#23229-linking
perunt added a commit to margelo/expensify-app-fork that referenced this issue Oct 5, 2023
@perunt
Merge branch 'feat/#Expensify#23220-bidirectional-pagination' of http…
0895706 
…s://github.com/margelo/expensify-app-fork into feat/#Expensify#23229-linking
perunt added a commit to margelo/expensify-app-fork that referenced this issue Oct 9, 2023
@perunt
Merge branch 'feat/#Expensify#23220-bidirectional-pagination' of http…
39d1747 
…s://github.com/margelo/expensify-app-fork into feat/#Expensify#23229-linking
perunt added a commit to margelo/expensify-app-fork that referenced this issue Oct 10, 2023
@perunt
Merge branch 'feat/#Expensify#23220-bidirectional-pagination' of http…
ab6350b 
…s://github.com/margelo/expensify-app-fork into feat/#Expensify#23229-linking
perunt added a commit to margelo/expensify-app-fork that referenced this issue Oct 11, 2023
@perunt
Merge branch 'feat/#Expensify#23220-bidirectional-pagination' of http…
86e4a69 
…s://github.com/margelo/expensify-app-fork into feat/#Expensify#23229-linking
perunt added a commit to margelo/expensify-app-fork that referenced this issue Oct 23, 2023
@perunt
Merge branch 'feat/#Expensify#23220-bidirectional-pagination' of http…
00071da 
…s://github.com/margelo/expensify-app-fork into feat/#Expensify#23229-linking
perunt added a commit to margelo/expensify-app-fork that referenced this issue Oct 24, 2023
@perunt
Merge branch 'main' of https://github.com/Expensify/App into feat/#Ex…
60d4110 
…pensify#23229-linking
perunt added a commit to margelo/expensify-app-fork that referenced this issue Oct 25, 2023
@perunt
Merge branch 'main' of https://github.com/Expensify/App into feat/#Ex…
bfb6da6 
…pensify#23229-linking
@melvin-bot melvin-bot bot closed this as completed Nov 2, 2023
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Nov 2, 2023

@perunt, this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

perunt added a commit to margelo/expensify-app-fork that referenced this issue Nov 3, 2023
@perunt
Merge branch 'main' of https://github.com/Expensify/App into feat/#Ex…
8f9f32c 
…pensify#23229-linking
perunt added a commit to margelo/expensify-app-fork that referenced this issue Nov 3, 2023
@perunt
Merge branch 'feat/#Expensify#23220-web-adjustForMaintainVisibleConte…
b94dde2 
…ntPosition' of https://github.com/margelo/expensify-app-fork into feat/#Expensify#23229-linking
perunt added a commit to margelo/expensify-app-fork that referenced this issue Nov 7, 2023
@perunt
Merge branch 'feat/#Expensify#23229-linking' of https://github.com/ma…
07b40b0 
…rgelo/expensify-app-fork; branch 'main' of https://github.com/Expensify/App into feat/#Expensify#23229-linking
perunt added a commit to margelo/expensify-app-fork that referenced this issue Nov 7, 2023
@perunt
Merge branch 'main' of https://github.com/Expensify/App into feat/#Ex…
177b08c 
…pensify#23229-linking
perunt added a commit to margelo/expensify-app-fork that referenced this issue Nov 7, 2023
@perunt
Merge branch 'main' of https://github.com/Expensify/App into feat/#Ex…
66a5c85 
…pensify#23229-linking
@roryabraham roryabraham reopened this Nov 8, 2023
@melvin-bot melvin-bot bot added Monthly KSv2 and removed Weekly KSv2 labels Jan 18, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Jan 18, 2024

This issue has not been updated in over 15 days. @perunt eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

perunt added a commit to margelo/expensify-app-fork that referenced this issue Jan 19, 2024
@perunt
Merge branch 'main' of https://github.com/Expensify/App into feat/#Ex…
b0035bf 
…pensify#23229-linking
perunt added a commit to margelo/expensify-app-fork that referenced this issue Jan 19, 2024
@perunt
Merge branch 'main' of https://github.com/Expensify/App into feat/#Ex…
1db6e8c 
…pensify#23229-linking
perunt added a commit to margelo/expensify-app-fork that referenced this issue Jan 25, 2024
@perunt
Merge branch 'main' of https://github.com/Expensify/App into feat/#Ex…
8c4b032 
…pensify#23229-linking
perunt added a commit to margelo/expensify-app-fork that referenced this issue Jan 30, 2024
@perunt
Merge branch 'main' of https://github.com/Expensify/App into feat/#Ex…
82b7e8b 
…pensify#23229-linking
perunt added a commit to margelo/expensify-app-fork that referenced this issue Feb 2, 2024
@perunt
Merge branch 'main' of https://github.com/Expensify/App into feat/#Ex…
7bdf855 
…pensify#23229-linking
perunt added a commit to margelo/expensify-app-fork that referenced this issue Feb 6, 2024
@perunt
Merge branch 'main' of https://github.com/Expensify/App into feat/#Ex…
312f952 
…pensify#23229-linking
perunt added a commit to margelo/expensify-app-fork that referenced this issue Feb 7, 2024
@perunt
Merge branch 'main' of https://github.com/Expensify/App into feat/#Ex…
ce1354e 
…pensify#23229-linking
perunt added a commit to margelo/expensify-app-fork that referenced this issue Feb 7, 2024
@perunt
Merge branch 'perunt/onStartReached-fix' of https://github.com/margel…
ddb682c 
…o/expensify-app-fork into feat/#Expensify#23229-linking
perunt added a commit to margelo/expensify-app-fork that referenced this issue Feb 12, 2024
@perunt
Merge branch 'main' of https://github.com/Expensify/App into feat/#Ex…
c926703 
…pensify#23229-linking
perunt added a commit to margelo/expensify-app-fork that referenced this issue Feb 13, 2024
@perunt
Merge branch 'feat/#Expensify#23229-linking' of https://github.com/ma…
810184f 
…rgelo/expensify-app-fork into feat/23229-linking-e2e
perunt added a commit to margelo/expensify-app-fork that referenced this issue Feb 13, 2024
@perunt
Merge branch 'feat/#Expensify#23229-linking' of https://github.com/ma…
3ad7459 
…rgelo/expensify-app-fork into feat/23229-linking-e2e
perunt added a commit to margelo/expensify-app-fork that referenced this issue Feb 13, 2024
@perunt
Merge branch 'feat/#Expensify#23229-linking' of https://github.com/ma…
d537da2 
…rgelo/expensify-app-fork into feat/23229-linking-e2e
perunt added a commit to margelo/expensify-app-fork that referenced this issue Feb 13, 2024
@perunt
Merge branch 'feat/#Expensify#23229-linking' of https://github.com/ma…
af70579 
…rgelo/expensify-app-fork into feat/23229-linking-e2e
perunt added a commit to margelo/expensify-app-fork that referenced this issue Feb 19, 2024
@perunt
Merge branch 'main' of https://github.com/Expensify/App into feat/#Ex…
6660257 
…pensify#23229-linking
perunt added a commit to margelo/expensify-app-fork that referenced this issue Mar 1, 2024
@perunt
Merge branch 'main' of https://github.com/Expensify/App into feat/#Ex…
3fbbb19 
…pensify#23229-linking
perunt added a commit to margelo/expensify-app-fork that referenced this issue Mar 12, 2024
@perunt
Merge branch 'main' of https://github.com/Expensify/App into feat/#Ex…
485aad8 
…pensify#23229-linking
perunt added a commit to margelo/expensify-app-fork that referenced this issue Mar 12, 2024
@perunt
Merge branch 'main' of https://github.com/Expensify/App into feat/#Ex…
a747515 
…pensify#23229-linking
perunt added a commit to margelo/expensify-app-fork that referenced this issue Mar 13, 2024
@perunt
Merge branch 'main' of https://github.com/Expensify/App into feat/#Ex…
ad44807 
…pensify#23229-linking
perunt added a commit to margelo/expensify-app-fork that referenced this issue Mar 19, 2024
@perunt
Merge branch 'main' of https://github.com/Expensify/App into feat/#Ex…
a77f3de 
…pensify#23229-linking
perunt added a commit to margelo/expensify-app-fork that referenced this issue Mar 20, 2024
@perunt
Merge branch 'main' of https://github.com/Expensify/App into feat/#Ex…
09dcee2 
…pensify#23229-linking
roryabraham pushed a commit that referenced this issue Mar 20, 2024
@perunt
Merge branch 'main' of https://github.com/Expensify/App into feat/##2…
dae1aa6 
…3229-linking
roryabraham added a commit that referenced this issue Mar 20, 2024
@roryabraham
Merge pull request #30269 from margelo/feat/##23229-linking
b306886 
HIGH: (Comment linking: Step 4) Main "glue" PR for Comment Linking
@melvin-bot melvin-bot bot closed this as completed Apr 5, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Apr 5, 2024

@perunt, this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

@roryabraham
Copy link
Contributor Author

this is done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@perunt perunt

Labels
Engineering Monthly KSv2
Projects
Comment Linking
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@peterdbarkerUK @roryabraham @perunt