Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD] Scroll to new message #23231

Closed
roryabraham opened this issue Jul 20, 2023 · 9 comments
Closed

[HOLD] Scroll to new message #23231

roryabraham opened this issue Jul 20, 2023 · 9 comments
Assignees

Comments

@roryabraham
Copy link
Contributor

roryabraham commented Jul 20, 2023

HOLD on #23229

Part of the Comment Linking project

Main issue: #20282
Doc section: https://docs.google.com/document/d/1v-ZaIRTZL5LIsyPWB0IopBNNgCajf5WC1OA8cVKtd8I/edit#bookmark=id.trn1p6c41ba
Project: Comment Linking

Feature Description

Update the New Message floating button such that it will re-render the FlatList centered on the oldest unread message in the chat.

Manual Test Steps

  1. Send a message with a link to a comment that is >50 (ideally a couple hundred) messages back in the history of the same chat.
  2. Mark one of the visible messages as unread, then click on the link to the older message.
  3. Now receive >50 new messages from another user.
  4. Verify that the New Message popover appears.
  5. Click on the New Message popover.
  6. Verify that you are taken to the message you marked as unread in step 2.
  7. Scroll in either direction and more chats should load.

Automated Tests

Because this is convoluted to manually test, it seems like a very good candidate for some automated UI tests to prevent it breaking in the future.

@melvin-bot melvin-bot bot added Monthly KSv2 and removed Weekly KSv2 labels Aug 21, 2023
@melvin-bot
Copy link

melvin-bot bot commented Aug 21, 2023

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@melvin-bot melvin-bot bot closed this as completed Nov 2, 2023
Copy link

melvin-bot bot commented Nov 2, 2023

@roryabraham, this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

Copy link

melvin-bot bot commented Jan 29, 2024

@roryabraham, this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

@roryabraham
Copy link
Contributor Author

reopening but keeping on HOLD

Copy link

melvin-bot bot commented May 7, 2024

@roryabraham, this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

@roryabraham roryabraham reopened this May 15, 2024
@roryabraham roryabraham self-assigned this May 15, 2024
@melvin-bot melvin-bot bot added the Overdue label May 24, 2024
@roryabraham
Copy link
Contributor Author

No update

@melvin-bot melvin-bot bot removed the Overdue label May 28, 2024
@melvin-bot melvin-bot bot added the Overdue label Jun 5, 2024
@melvin-bot melvin-bot bot removed the Weekly KSv2 label Jun 20, 2024
Copy link

melvin-bot bot commented Jun 20, 2024

This issue has not been updated in over 15 days. @roryabraham eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@melvin-bot melvin-bot bot added the Monthly KSv2 label Jun 20, 2024
@melvin-bot melvin-bot bot removed the Overdue label Jun 20, 2024
@melvin-bot melvin-bot bot added the Overdue label Jul 22, 2024
@roryabraham
Copy link
Contributor Author

@melvin-bot melvin-bot bot removed the Overdue label Jul 27, 2024
@roryabraham
Copy link
Contributor Author

Closing this as a dupe of #35011, which has better context at this point

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

1 participant