[$1000] Jump to last unread chat when opening a report

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.28.0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @MonilBhavsar
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1705558628672569

Action Performed:

1. A is participant of a chat or room
2. As another user send some good number of messages to chat report, so new messages can be scrolled up and down
3. As user A, open the chat report

Expected Result:

The chat report view opens from where the messages are unread and user can scroll down

Actual Result:

The chat report view is scrolled down to the last message and user needs to scroll up to find last read message

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Recording.5931.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01fc144b2f2f5df388
• Upwork Job ID: 1749920553887232000
• Last Price Increase: 2024-06-11
• Automatic offers:
• ikevin127 | Contributor | 0
• ishpaul777 | Contributor | 102670752

Issue Owner

Current Issue Owner: @roryabraham

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01fc144b2f2f5df388

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

[jeremy-croff]

This PR #28793 specifically makes it scrolled to the bottom, seems like NAB

[trjExpensify]

I'm a bit confused by the bug report @MonilBhavsar, so asking about it here. I thought this was something we'd implement via comment linking.

[roryabraham]

HOLD for comment linking: #30269

[melvin-bot]

Current assignee @trjExpensify is eligible for the NewFeature assigner, not assigning anyone new.

[trjExpensify]

No change, still on hold Melv!

[trjExpensify]

Samesies, Melv!

[trjExpensify]

Still on hold, comment linking got held for the deploy freeze last week.

[trjExpensify]

Taking the issue off hold.

[ishpaul777]

we are discussing this on slack

[roryabraham]

My suggestion for next steps:

• Right now, when OpenReport is called w/o any specific reportActionID as an anchor, we essentially return the 50 newest visible actions on the report. We'll want to update that such that it looks at the clientLastReadTime (already passed by App) and use that to determine the anchor action. It will then return 25 messages before and 25 messages after that anchor, and the client will render those
• Then we already have some logic to fetch newer actions as the user scrolls down

I'll need to test carefully to make sure that making the back-end changes won't break NewDot without any changes. If it won't then we're good here. If it will, some additional steps and a more careful rollout might be needed.

[trjExpensify]

What's the latest here?

[ishpaul777]

any updates here? @roryabraham

[roryabraham]

Was looking into this, chats are fetched in OpenReport from Web-E here

[roryabraham]

ok, I tried just making the change to pass the clientLastReadTime as the anchor action, but it didn't work. Seems like NewDot changes will be needed. The new message indicator appeared below the message I marked as unread, and it looked like we only returned actions before that point, not before and after.

On top of that, the main issue was that the reportActionsPages_ Onyx key was populated assuming that we were at the end of the chat. In addition, the IOU actions seem to have been fetched and delivered to the front-end separately.

[roryabraham]

So one thing I'm seeing is that this code is problematic. Because we don't have access to the lastReadReportActionID. (only the lastReadTime, which will tend to be more reliable, because what if the lastReadReportActionID were deleted while you were offline or something?).

Basically, that code was built with the (then-correct) assumption that initially opening a report without a cursor action would mean that you'll get the latest actions. However, this issue seeks to change that. To correctly track pagination with this change, we need to return some additional pagination metadata. Fortunately, I've already got an issue for that here. So I'm going to put this on HOLD for that

[roryabraham]

still working on #41153

[ishpaul777]

Not overdue #41153 is WIP

[trjExpensify]

Yep, agreed!

[roryabraham]

All the PRs for the back-end of #41153 have been merged and should go to prod on Wednesday 2024-09-18