Wallet - Loading spinner for Expensify wallet amount when changing default payment method

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.3.97-3
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

Precondition: account has 2 or more payment method

1. Open the App
2. Login with any Expensifail account
3. Go to Settings -> Wallet -> Change default payment method

Expected Result:

Expensify wallet amount not changes

Actual Result:

Expensify wallet amount refreshing with loading spinner

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6270258_1699551314224.Record_2023-11-09-13-31-10_4f9154176b47c00da84e32064abf1c48.mp4

Production

RPReplay_Final1699551308.MP4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @peterdbarkerUK (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @neil-marcellini (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[neil-marcellini]

Taking a look 👀

[neil-marcellini]

The regression came from this PR Fix: Wallet page does not update instantly when bank account is added or deleted.

I agree that the wallet amount shouldn't refresh or have to load when you change the default payment method. However, I think this "bug" is arguable more minor than the one fixed by that PR, which is that the wallet page doesn't update when adding or removing a bank account. I think we should put up a quick fix, and if we start holding up the deploy we can remove the blocker label.

@Pujan92 do you want to put up a quick fix? I'll start investigating too.

[neil-marcellini]

Ok so the OpenPaymentsPage API command returns bank accounts, funds, user wallet, paypal, and card list. The user wallet is where the balance comes from and that's why we show a loader when it's updating. That makes sense, but again, we shouldn't need to update the balance when adding or removing bank accounts.

So why did we decide to call this API command again when a bank account is added or deleted? The APIs which do that should return the updated list of bank accounts.

[neil-marcellini]

Ok I took a second look at the issue that was supposed to be solved. It looks like when the user doesn't have a bank account we don't show the wallet, so when one is added we need to send an update for the wallet key, which we currently don't do for the API AddPersonalBankAccount.

Since we need backend changes, and the original issue isn't really that bad, I now think that we should revert the PR causing the regression. It's not the right approach anyways.

[neil-marcellini]

CP requested here