Fix/27544 Incorrect Old Dot comment formatting when viewed on New Dot #30193

Victor-Nyagudi · 2023-10-23T18:25:48Z

Details

When viewing a report approved/submitted on Old Dot in New Dot, it was incorrectly formatted i.e. bolded, white, and separated on different lines.

This PR restores the grey color and regular font weight similar to other types of report actions/system messages and shows the approved/submitted report on one line.

Fixed Issues

$ #27544
PROPOSAL: #27544 (comment)

Tests

Pre-requisite: User A must have created a "Collect" workspace on Old Dot whose "Approval Mode" is set to "Submit and Approve", is the admin of the workspace, and has invited User B as an employee.

As User B, click on "Reports" in the left sidebar and then click on the green pill button at the top right of the screen that says "New report" in the workspace User A invited you to.
Type a message in the composer at the bottom of the card that appears e.g. "Hello from the Old Dot workspace" and press Enter to send it.
In the browser Url, you'll see an object like {"pageReportID":8096248714236998,"keepCollection":true}. Copy the number after pageReportID.
Open a new browser window, log in as User A on New Dot, and paste the number you just copied from Old Dot in the browser Url to navigate to the report. It should look something like this: staging.new.expensify.com/r/[the long number you copied goes here not surrounded by brackets].
Verify the message sent from Old Dot by User B is present and formatted correctly e.g. like a regular chat message - white in color and regular font weight. If you're not sure what this looks like, click on the large green button on the bottom left of the screen -> start chat -> enter an email or select from list -> type something in the composer and then send.
Go back to the browser window where you're logged in as User B on Old Dot and add an expense to the report you created in step 1. Set User A as the person you're submitting to and ensure it's in the workspace you were invited to.
Verify the text "You submitted this report to User A" is shown above the composer in the card at the centre of the screen right after your first message as User B.
Go back to the New Dot window where you're logged in as User A viewing the report from Old Dot. You may need to refresh the page for the report to update.
Verify the text "User B submitted this report to you" is shown after the first message User B sent and is greyed out, has a regular font weight, and is all on one line.
Go back to Old Dot where you're logged in as User A and open the report User B created.
Verify the chat history in the card is the same as the one you saw as User A in New Dot.
Click on the green pill button at the top left that says "Approve".
Verify the text "You final approved this report" appears just above the composer as the most recent message in the large card at the center of the screen.
Go back to New Dot where you logged in as User A viewing the report of the workspace created in Old Dot. You might need to refresh the page.
Verify the message "You final approved this report" is shown as the most recent message just above the composer and is greyed out, has a regular font weight, and is all in one line.
Send a message in the report while on New Dot as User A e.g. "This is a message from New Dot".
Verify the message you just sent is formatted correctly like in step 5.
If you don't see the conversation in the LHN in New Dot while on mobile devices or the desktop app, with the native app/browser open on mobile or the desktop app open, send a message in the workspace in New Dot from Mac Chrome. You should see the conversation with the most recent message in the LHN.
On Mac Chrome, Mac Safari, and Mac Desktop, resize the browser/app to different sizes. On Android Chrome and iOS Safari, switch between portrait mode and landscape mode.
Verify all messages are formatted correctly as you've seen so thus far.

Please note:

You'll notice that the copy to clipboard icon appears when you hover over the system messages from Old Dot while in New Dot, however, clicking it doesn't copy anything to the clipboard. Try doing so and pasting what you "copied" in the composer.

If in Android Web DEV (connected using your Mac's IP address and port number) you try long-pressing a message (in other chats too other than the workspace here), choose "Copy to clipboard" , and then try pasting the text in the composer, what you tried copying isn't pasted.

Verify that no errors appear in the JS console

Offline tests

After repeating the steps in "Tests" above, turn off your wifi or go to your avatar in the top left -> preferences -> toggle force offline.

Verify the text "You final approved this report" and "User B submitted this report to you" is greyed out, has a regular font weight, and is all in one line.

QA Steps

Same as above in Tests section.

Additional Steps (after performing steps in Tests section)

While on New Dot, send a message with a link included in the workspace created on Old Dot e.g. "Hello www.google.com".
Verify the link is blue and underlined.
Send a message in the same workspace formatted to use markdown e.g. bold, italic, strikethrough, a mix of markdown styles, etc.
Verify the appropriate markdown style is applied.
Hover over the messages you sent in Step 1 and 3, click on the pencil icon, and edit the message. Press "Enter" when done.
Verify the edited text is what you edited the message to, and the small "edited" label is applied.
Hover over the "You final approved this report" and "User B submitted this report to you" messages and click on one of the emojis.
Verify the emojis are shown below the messages.
Copy the link in the Url, sign out of New Dot, paste it in the browser, and then press Enter.
Log into your account.
Verify you're directed to the Old Dot workspace page, and everything looks the way you left it, including the "You final approved this report" and "User B submitted this report to you" messages being greyed out, having a regular font weight, and appearing on one line.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

…ages

This was causing a lint error during PR checks

Caught this little error currently on latest main that would've rendered 'props.framgent.text' literally instead of the actual text

Victor-Nyagudi · 2023-10-24T11:07:41Z

~~Caught this little bug currently on the latest main that would've literally rendered 'props.fragment.text' instead of the actual text.~~
Found this piece of code that looked a bit suspicious on latest main. With the current implementation, it would literally render 'props.fragment.text`

App/src/pages/home/report/ReportActionItemFragment.js

Line 185 in d282473

return <Text>props.fragment.text</Text>;

~~I've fixed it like so in the PR.~~
I've changed it to the following in my PR.

<Text>{props.fragment.text}</Text>

Seeing how the other cases are handled, it's possible this may have been intentional.

App/src/pages/home/report/ReportActionItemFragment.js

Lines 170 to 183 in 60576fe

    
           case 'LINK': 
        
               return <Text>LINK</Text>; 
        
           case 'INTEGRATION_COMMENT': 
        
               return <Text>REPORT_LINK</Text>; 
        
           case 'REPORT_LINK': 
        
               return <Text>REPORT_LINK</Text>; 
        
           case 'POLICY_LINK': 
        
               return <Text>POLICY_LINK</Text>; 
        
           // If we have a message fragment type of OLD_MESSAGE this means we have not yet converted this over to the 
        
           // new data structure. So we simply set this message as inner html and render it like we did before. 
        
           // This wil allow us to convert messages over to the new structure without needing to do it all at once. 
        
           case 'OLD_MESSAGE': 
        
               return <Text>OLD_MESSAGE</Text>;

If at all any of you, @jjcoffee or @lakchote, feel this change isn't needed, I can just revert it. It could also save on some testing.

Victor-Nyagudi · 2023-10-24T11:08:30Z

Just Android Native testing left to go, and the PR should be ready for review. Saved it for last because it can take a while to build.

This reverts commit 9c06778.

Victor-Nyagudi · 2023-10-24T14:34:29Z

Tried building from Android Studio, but that took a long time to even import the files, so I switched back to using VS Code.

Still waiting on the app to build on Android Native.

Victor-Nyagudi · 2023-10-24T17:12:37Z

Android Native has built, but the font is still bolded, for some reason. The color is grey as expected.

Investigating.

Victor-Nyagudi · 2023-10-24T17:58:14Z

It seems that's just how afontWeight: 'normal' looks on Android because when I tried changing it to fontWeight: 'bold', the text got bigger and thicker.

melvin-bot · 2023-10-24T17:59:56Z

@jjcoffee Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Victor-Nyagudi · 2023-10-24T18:16:08Z

The styling guide says inline styles are forbidden, but I was a bit hesitant to create a helper method ~~in styles.ts~~ to add just two styles ReportActionItemFragment, so I figured I'd ask first.

An inline style has been applied over here, so I thought maybe things could work as is.

App/src/components/MentionSuggestions.js

Line 107 in 3380266

    
           style={[StyleUtils.getColoredBackgroundStyle(isColored), styles.mentionSuggestionsHandle, {...(isColored && {color: styles.text})}]}

In any case, should we go with the helper method, I could add this in ~~the styles variable of styles.ts~~ ~~StyleUtils.ts~~ styles.ts according to what's said in the styling guide.

getMutedColorAndNormalFontWeight: (isApprovedOrSubmittedReportActionType: Boolean) => (isApprovedOrSubmittedReportActionType ? {color: theme.textSupporting, fontWeight: 'normal'} : {}),

And then replace the added style in ReportActionItemFragment with this:

style={[
    styles.chatItemMessageHeaderSender,
    props.isSingleLine ? styles.pre : styles.preWrap,
    styles.getMutedColorAndNormalFontWeight(_.contains([CONST.REPORT.ACTIONS.TYPE.APPROVED, CONST.REPORT.ACTIONS.TYPE.SUBMITTED], props.actionName)),
]}

…matting

jjcoffee · 2023-10-25T12:42:41Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

jjcoffee · 2023-10-25T14:46:33Z

If you hover anywhere over the messages "You final approved this report" or "User B submitted this report to you" in the Old Dot workspace while on New Dot, a tooltip with no Avatar is displayed.

@Victor-Nyagudi Regarding the above, to keep things consistent with other system messages, I actually think we don't want tooltips to display here. Is it an easy fix? I think technically it's out of scope for this issue, but it might as well be fixed if it's not too big a deal!

Victor-Nyagudi · 2023-10-25T15:06:55Z

@jjcoffee The fragments we get from Old Dot are wrapped in UserDetailsTooltip.

I suspect this could be why the tooltip is shown on hover, though I haven't dived too deep into it.

App/src/pages/home/report/ReportActionItemFragment.js

Lines 155 to 169 in e6af6e9

    
           case 'TEXT': 
        
               return ( 
        
                   <UserDetailsTooltip 
        
                       accountID={props.accountID} 
        
                       delegateAccountID={props.delegateAccountID} 
        
                       icon={props.actorIcon} 
        
                   > 
        
                       <Text 
        
                           numberOfLines={props.isSingleLine ? 1 : undefined} 
        
                           style={[styles.chatItemMessageHeaderSender, props.isSingleLine ? styles.pre : styles.preWrap]} 
        
                       > 
        
                           {props.fragment.text} 
        
                       </Text> 
        
                   </UserDetailsTooltip> 
        
               );

It's EOD for me (I can still reply on mobile), so I'll take a deeper look first thing tomorrow to try figure out why the tooltip is there in the first place and what we can potentially do about it.

src/pages/home/report/ReportActionItemFragment.js

src/pages/home/report/ReportActionItemMessage.js

@jjcoffee

…t with <Text> This is done as per @jjcoffee's suggestion. Co-authored-by: Joel Davies <joeld.dev@gmail.com>

…matting

… to ReportActionItemFragment

jjcoffee · 2023-11-02T09:48:10Z

I'm open to suggestions on how we can implement the optional wrapping

Hmm did you consider just adding flex-direction: row conditionally on the parent View?

App/src/pages/home/report/ReportActionItemMessage.js

Line 51 in 3db5ff4

    
           <View style={[styles.chatItemMessage, !props.displayAsGroup && isAttachment ? styles.mt2 : {}, ...props.style]}>

I think it's just a bit messy to unnecessarily wrap with a <Text> when we don't need to, but if there's no other way we can stick to it, I guess!

Victor-Nyagudi · 2023-11-02T10:11:33Z

Yes, I did explore styling the View with flexDirection: 'row' in my proposal, but this caused issues when the screen was resized.

jjcoffee · 2023-11-02T10:20:02Z

@Victor-Nyagudi Ah sorry, forgot about that! What about just display: inline then? The RTL issue seems to be present when using a <Text> wrapper (even if setting LTR styles on the children).

Victor-Nyagudi · 2023-11-02T10:29:44Z

No worries.

Did you notice any issues when the fragments aren't wrapped in a <Text> component?

I'm investigating as we speak.

…matting

…L scenarios Arabic display names caused the text to start from the right side of the screen even though the system message is in English

Victor-Nyagudi · 2023-11-02T22:02:45Z

Looks like one of the checks failed.

I'll investigate first thing in the morning.

Victor-Nyagudi · 2023-11-03T07:47:19Z

It appears the performance test started failing after I merged main here 8afe93c before my most recent changes.

These tests also seem to be fairly new. Could we try running them again to see if they're still failing?

@jjcoffee We're also approaching the 9 business days mark, so this PR is now my top priority so we can get it merged before that point is reached.

src/pages/home/report/ReportActionItemFragment.js

jjcoffee · 2023-11-03T12:47:37Z

@Victor-Nyagudi Just a heads up that it's about 3 hours until my EOD.

Victor-Nyagudi · 2023-11-03T12:57:12Z

Got it, @jjcoffee . I'm available for all 3.

jjcoffee · 2023-11-03T12:59:04Z

@Victor-Nyagudi Any luck with this?

Victor-Nyagudi · 2023-11-03T13:02:47Z

Checking right now.

Victor-Nyagudi · 2023-11-03T13:05:24Z

@jjcoffee Aside from the shouldConvertToLTR bit, is there anything else that requires my attention?

jjcoffee · 2023-11-03T13:06:31Z

@Victor-Nyagudi Nope happy with everything else!

jjcoffee

LGTM!

Victor-Nyagudi · 2023-11-03T13:56:16Z

Thank you for your patience and sticking with me through this one, @jjcoffee.

lakchote · 2023-11-06T10:41:25Z

Great work and collaboration both of you @Victor-Nyagudi @jjcoffee 👍

OSBotify · 2023-11-06T10:49:19Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-11-06T22:31:25Z

🚀 Deployed to staging by https://github.com/lakchote in version: 1.3.96-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-11-09T22:48:58Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.96-15 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-11-10T15:45:36Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.97-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Victor-Nyagudi added 3 commits October 23, 2023 19:36

Wrap ReportActionItemFragment inside a Text component

482d001

Restore grey color and regular font weight to APPROVED/SUBMITTED mess…

b591c52

…ages

Conditionally surround ReportActionItemFragment with Text component

51a4f16

Victor-Nyagudi changed the title ~~Fix/27544 incorrect Old Dot comment formatting when viewed on New Dot~~ Fix/27544 Incorrect Old Dot comment formatting when viewed on New Dot Oct 23, 2023

Victor-Nyagudi added 2 commits October 23, 2023 22:43

Remove return statement surrounding ReportActionItemFragment

c108645

This was causing a lint error during PR checks

Surround 'props.fragment.text' in curly braces

9c06778

Caught this little error currently on latest main that would've rendered 'props.framgent.text' literally instead of the actual text

Victor-Nyagudi mentioned this pull request Oct 24, 2023

HOLD for payment 2023-11-17 - [$1000] Web - Incorrect comment formatting after approval #27544

Closed

6 tasks

Victor-Nyagudi added 2 commits October 24, 2023 14:23

Describe function using JS Docs syntax & use inline ternary statement

9165187

Revert "Surround 'props.fragment.text' in curly braces"

89baf40

This reverts commit 9c06778.

Victor-Nyagudi marked this pull request as ready for review October 24, 2023 17:59

Victor-Nyagudi requested a review from a team as a code owner October 24, 2023 17:59

melvin-bot bot requested review from jjcoffee and removed request for a team October 24, 2023 17:59

Merge branch 'Expensify:main' into fix/27544-incorrect-OD-comment-for…

64d204b

…matting

jjcoffee reviewed Oct 25, 2023

View reviewed changes

src/pages/home/report/ReportActionItemFragment.js Outdated Show resolved Hide resolved

jjcoffee reviewed Oct 25, 2023

View reviewed changes

src/pages/home/report/ReportActionItemFragment.js Outdated Show resolved Hide resolved

jjcoffee reviewed Oct 25, 2023

View reviewed changes

src/pages/home/report/ReportActionItemMessage.js Outdated Show resolved Hide resolved

Victor-Nyagudi and others added 3 commits October 26, 2023 09:41

Reword comment explaining reason for wrapping ReportActionItemFragmen…

286ed53

…t with <Text> This is done as per @jjcoffee's suggestion. Co-authored-by: Joel Davies <joeld.dev@gmail.com>

Merge branch 'Expensify:main' into fix/27544-incorrect-OD-comment-for…

2802633

…matting

Pass isApprovedOrSubmittedReportActionType prop instead of actionName…

1d698f3

… to ReportActionItemFragment

Victor-Nyagudi and others added 2 commits November 2, 2023 13:43

Merge branch 'Expensify:main' into fix/27544-incorrect-OD-comment-for…

8afe93c

…matting

Conditionally wrap report action fragments in Text and account for RT…

f669405

…L scenarios Arabic display names caused the text to start from the right side of the screen even though the system message is in English

jjcoffee reviewed Nov 3, 2023

View reviewed changes

src/pages/home/report/ReportActionItemFragment.js Outdated Show resolved Hide resolved

jjcoffee reviewed Nov 3, 2023

View reviewed changes

src/pages/home/report/ReportActionItemFragment.js Show resolved Hide resolved

Rename shouldConvertToLTR prop to isFragmentContainingDisplayName

ffb1e9a

jjcoffee approved these changes Nov 3, 2023

View reviewed changes

melvin-bot bot requested a review from lakchote November 3, 2023 13:51

lakchote approved these changes Nov 6, 2023

View reviewed changes

lakchote merged commit 70f680d into Expensify:main Nov 6, 2023
15 checks passed

OSBotify mentioned this pull request Nov 6, 2023

Deploy Checklist: New Expensify 2023-11-06 #30929

Closed

OSBotify mentioned this pull request Nov 8, 2023

Deploy Checklist: New Expensify 2023-11-08 #31077

Closed

Victor-Nyagudi deleted the fix/27544-incorrect-OD-comment-formatting branch November 22, 2023 05:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix/27544 Incorrect Old Dot comment formatting when viewed on New Dot #30193

Fix/27544 Incorrect Old Dot comment formatting when viewed on New Dot #30193

Victor-Nyagudi commented Oct 23, 2023 •

edited

Loading

Victor-Nyagudi commented Oct 24, 2023

Victor-Nyagudi commented Oct 24, 2023

Victor-Nyagudi commented Oct 24, 2023

Victor-Nyagudi commented Oct 24, 2023

Victor-Nyagudi commented Oct 24, 2023 •

edited

Loading

melvin-bot bot commented Oct 24, 2023

Victor-Nyagudi commented Oct 24, 2023 •

edited

Loading

jjcoffee commented Oct 25, 2023 •

edited

Loading

jjcoffee commented Oct 25, 2023

Victor-Nyagudi commented Oct 25, 2023

jjcoffee commented Nov 2, 2023

Victor-Nyagudi commented Nov 2, 2023

jjcoffee commented Nov 2, 2023

Victor-Nyagudi commented Nov 2, 2023

Victor-Nyagudi commented Nov 2, 2023

Victor-Nyagudi commented Nov 3, 2023

jjcoffee commented Nov 3, 2023

Victor-Nyagudi commented Nov 3, 2023

jjcoffee commented Nov 3, 2023

Victor-Nyagudi commented Nov 3, 2023 •

edited

Loading

Victor-Nyagudi commented Nov 3, 2023

jjcoffee commented Nov 3, 2023

jjcoffee left a comment

Victor-Nyagudi commented Nov 3, 2023

lakchote commented Nov 6, 2023

OSBotify commented Nov 6, 2023

OSBotify commented Nov 6, 2023

OSBotify commented Nov 9, 2023

OSBotify commented Nov 10, 2023

Fix/27544 Incorrect Old Dot comment formatting when viewed on New Dot #30193

Fix/27544 Incorrect Old Dot comment formatting when viewed on New Dot #30193

Conversation

Victor-Nyagudi commented Oct 23, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Victor-Nyagudi commented Oct 24, 2023

Victor-Nyagudi commented Oct 24, 2023

Victor-Nyagudi commented Oct 24, 2023

Victor-Nyagudi commented Oct 24, 2023

Victor-Nyagudi commented Oct 24, 2023 • edited Loading

melvin-bot bot commented Oct 24, 2023

Victor-Nyagudi commented Oct 24, 2023 • edited Loading

jjcoffee commented Oct 25, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

jjcoffee commented Oct 25, 2023

Victor-Nyagudi commented Oct 25, 2023

jjcoffee commented Nov 2, 2023

Victor-Nyagudi commented Nov 2, 2023

jjcoffee commented Nov 2, 2023

Victor-Nyagudi commented Nov 2, 2023

Victor-Nyagudi commented Nov 2, 2023

Victor-Nyagudi commented Nov 3, 2023

jjcoffee commented Nov 3, 2023

Victor-Nyagudi commented Nov 3, 2023

jjcoffee commented Nov 3, 2023

Victor-Nyagudi commented Nov 3, 2023 • edited Loading

Victor-Nyagudi commented Nov 3, 2023

jjcoffee commented Nov 3, 2023

jjcoffee left a comment

Choose a reason for hiding this comment

Victor-Nyagudi commented Nov 3, 2023

lakchote commented Nov 6, 2023

OSBotify commented Nov 6, 2023

OSBotify commented Nov 6, 2023

OSBotify commented Nov 9, 2023

OSBotify commented Nov 10, 2023

Victor-Nyagudi commented Oct 23, 2023 •

edited

Loading

Victor-Nyagudi commented Oct 24, 2023 •

edited

Loading

Victor-Nyagudi commented Oct 24, 2023 •

edited

Loading

jjcoffee commented Oct 25, 2023 •

edited

Loading

Victor-Nyagudi commented Nov 3, 2023 •

edited

Loading