Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] iOS - App - The name of the app is truncated and it's missing a space #31108

Closed
1 of 6 tasks
izarutskaya opened this issue Nov 9, 2023 · 22 comments
Closed
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. DeployBlockerCash This issue or pull request should block deployment Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Hourly KSv2

Comments

@izarutskaya
Copy link

izarutskaya commented Nov 9, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.3.97.0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation: @

Action Performed:

  1. Look at the name of the app on your phone

Expected Result:

Tha name should be "New Expensify".

Actual Result:

The name of the app is truncated and it's missing a space.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6269756_1699524516794!NewExpen

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~014b4b8d3a4a4cdf8e
  • Upwork Job ID: 1722566283877715968
  • Last Price Increase: 2023-11-09
@izarutskaya izarutskaya added DeployBlockerCash This issue or pull request should block deployment External Added to denote the issue can be worked on by a contributor Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Nov 9, 2023
@melvin-bot melvin-bot bot changed the title iOS - App - The name of the app is truncated and it's missing a space [$500] iOS - App - The name of the app is truncated and it's missing a space Nov 9, 2023
Copy link

melvin-bot bot commented Nov 9, 2023

Job added to Upwork: https://www.upwork.com/jobs/~014b4b8d3a4a4cdf8e

Copy link

melvin-bot bot commented Nov 9, 2023

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Nov 9, 2023
Copy link

melvin-bot bot commented Nov 9, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Copy link

melvin-bot bot commented Nov 9, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

@izarutskaya
Copy link
Author

Not reproducible in production

IMG_0686

@OSBotify
Copy link
Contributor

OSBotify commented Nov 9, 2023

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Nov 9, 2023

Triggered auto assignment to @nkuoch (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@erquhart
Copy link
Contributor

erquhart commented Nov 9, 2023

Betting this is because of the yellow dot from TestFlight. It seems to take up space that the title would take up. Curious if the blue dot that shows up when the app was updated since last open would cause this in production, guessing so.

Won't be an issue when the app fully replaces OD, it'll just say Expensify.

Guessing no fix is needed here.

@fedirjh
Copy link
Contributor

fedirjh commented Nov 9, 2023

@erquhart It's repo on simulator as well :

Screenshot 2023-11-09 at 2 02 26 PM

However the name matches the NewExpensifyTests package :

Header Header
Screenshot 2023-11-09 at 2 03 40 PM Screenshot 2023-11-09 at 2 03 51 PM

@erquhart
Copy link
Contributor

erquhart commented Nov 9, 2023

@fedirjh but that's the dev app, it's name is "New Expensify Dev" - I'm guessing it's always truncated with that many characters.

@fedirjh
Copy link
Contributor

fedirjh commented Nov 9, 2023

but that's the dev app, it's name is "New Expensify Dev" - I'm guessing it's always truncated with that many characters.

My guess is that the screenshot is taken from dev app, check the name , there is not a space between New and Expensify , it's similar to the dev App

Screenshot 2023-11-09 at 4 21 11 PM

@erquhart
Copy link
Contributor

erquhart commented Nov 9, 2023

iOS removes spaces when it's truncating an app name that's too large. The dev app has a red "DEV" badge in the lower right, as seen in your earlier screenshot.

@fedirjh
Copy link
Contributor

fedirjh commented Nov 9, 2023

That makes sense, it seems like no fix is required in this case.

@benyboariu
Copy link

Running locally on simulator, I manually changed the Product Name for Debug Development, and I put the name like in production, and the name fits, so it's not because the name would be too large.
Screenshot 2023-11-09 at 5 43 34 PM

Copy link

melvin-bot bot commented Nov 9, 2023

📣 @benyboariu! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

  1. Make sure you've read and understood the contributing guidelines.
  2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
    Screen Shot 2022-11-16 at 4 42 54 PM
    Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

@erquhart
Copy link
Contributor

erquhart commented Nov 9, 2023

@benyboariu OP screenshot has a yellow dot from TestFlight - I believe that's inline with the app name and causes the truncation.

@benyboariu
Copy link

Yes, my guess also. I don't have the credentials to do a fresh install from TF, to see exactly, but they should try to reproduce again, after they opened the app, and the dot disappears, in my opinion.

@AndriiSenyourit
Copy link

Be honest, has anyone received money for solving the problem, or is it just a scam to get solutions for free?

This comment was marked as off-topic.

@erquhart
Copy link
Contributor

erquhart commented Nov 9, 2023

@AndriiSenyourit Expensify has spent over $8 million on Upwork. Not a scam.

@fedirjh
Copy link
Contributor

fedirjh commented Nov 9, 2023

has anyone received money for solving the problem

@AndriiSenyourit Simple answer Yes 😃

Screenshot 2023-11-09 at 7 52 53 PM

@puneetlath
Copy link
Contributor

I agree that it seems that it's getting truncated due to the yellow dot and this isn't a bug. Thanks for the discussion everyone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. DeployBlockerCash This issue or pull request should block deployment Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Hourly KSv2
Projects
None yet
Development

No branches or pull requests

9 participants