[CP Staging] fix regression copy to clipboard #30818

saranshbalyan-1234 · 2023-11-03T07:36:39Z

Details

Fixed Issues

$ #30796
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Launch New Expensify app
Go to workspace chat that has paid expense
Tap on the workspace expense
Long press on the system message for paid expense
Tap Copy to clipboard
Verify app does not crash

Offline tests

Same as QA steps

QA Steps

Verify that no errors appear in the JS console

Launch New Expensify app
Go to workspace chat that has paid expense
Tap on the workspace expense
Long press on the system message for paid expense
Tap Copy to clipboard
Verify app does not crash

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2023-11-03T07:37:12Z

@Gonals Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

cubuspl42 · 2023-11-03T08:05:21Z

src/libs/ReportUtils.js

@@ -4087,7 +4087,7 @@ function getIOUReportActionDisplayMessage(reportAction) {
    let displayMessage;
    if (originalMessage.type === CONST.IOU.REPORT_ACTION_TYPE.PAY) {
        const {IOUReportID} = originalMessage;
-        const {amount, currency} = originalMessage.IOUDetails;
+        const {amount, currency} = originalMessage.IOUDetails || originalMessage;


I don't understand this.

This at least requires an explanation comment. Where are {amount, currency} expected to reside? Why are there sometimes here, sometimes here?

Both of these values were expected to reside in the root level, but for only our original issue that we fixed, only in that case it is coming inside ioudetails key
It has to be similar behaviour across all the scenarios, if we don't go with this PR we have to revert the original pr which caused this regression and then handle it from backend

@Gonals @marcaaron I approved this as it's a deploy blocker, but I didn't really get the explanation above and I still believe something should be done here. I'm just not completely sure what.

@saranshbalyan-1234

Both of these values were expected to reside in the root level, but for only our original issue that we fixed, only in that case it is coming inside ioudetails key

I need help understanding this. Would you re-phrase this sentence?

the original pr which caused this regression

Do you have a specific PR in mind?

Original PR -> my last PR which caused this regression

Original PR -> my last PR which caused this regression

Oh, sure 👍

Still, we need to sketch a plan for removing this originalMessage.IOUDetails || originalMessage expression long-term. Do I understand correctly that you suggested that this inconsistency starts on the backend side?

Yes! I saw this inconsistency. I still have to take it to slack
Did not do due to being hospitalised from past few days.
Just replying to this chat so that I don't miss anything

Oh, I'm sorry about your situation 🙁 If your health situation makes it difficult or impossible to work on this, let us know. We might put this on hold for the time of your recovery or something like that.

When money is sent (using send money) we store there details in IOUDetails, when money request is paid, the amount and currency is in the originalMessage field

Huh? That seems weird 😄 Is there some way to explicitly tell whether it's one or the other? Maybe the code should have a comment about it if we are not going to improve this.

Beamanator · 2023-11-03T08:32:14Z

@saranshbalyan-1234 thanks for the PR, and @cubuspl42 thanks for approving - did you test on all platforms? 🙏

I agree - if this fixes the blocker, let's move forward - but let's not forget this convo about making this code better

cubuspl42 · 2023-11-03T08:54:40Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

fix-regression-copy-to-clipboard-web.mp4

Mobile Web - Chrome

fix-regression-copy-to-clipboard-android-web-compressed.mp4

Mobile Web - Safari

fix-regression-copy-to-clipboard-ios-web.mp4

Desktop

fix-regression-copy-to-clipboard-desktop.mp4

iOS

fix-regression-copy-to-clipboard-ios.mp4

Android

fix-regression-copy-to-clipboard-android-compressed.mp4

cubuspl42 · 2023-11-03T08:55:54Z

@saranshbalyan-1234 thanks for the PR, and @cubuspl42 thanks for approving - did you test on all platforms? 🙏

I agree - if this fixes the blocker, let's move forward - but let's not forget this convo about making this code better

I just filled the whole checklist, with videos

Beamanator · 2023-11-03T09:26:39Z

@saranshbalyan-1234 can you please start a thread in slack (in #expensify-open-source), tagging me & anyone else involved who knows why we need to look in both places for amount & currency so that we can hopefully clean this up before we forget about it? 🙏

OSBotify · 2023-11-03T09:28:52Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

…-to-clipboard fix regression copy to clipboard (cherry picked from commit f498830)

OSBotify · 2023-11-03T10:04:31Z

🚀 Cherry-picked to staging by https://github.com/Beamanator in version: 1.3.95-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2023-11-06T22:07:17Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.95-9 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-11-10T15:47:12Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.97-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

fix regression copy to clipboard

1981886

saranshbalyan-1234 requested a review from a team as a code owner November 3, 2023 07:36

melvin-bot bot requested review from Gonals and removed request for a team November 3, 2023 07:37

saranshbalyan-1234 mentioned this pull request Nov 3, 2023

fix clipboard in report utils #30640

Merged

59 tasks

cubuspl42 reviewed Nov 3, 2023

View reviewed changes

cubuspl42 approved these changes Nov 3, 2023

View reviewed changes

melvin-bot bot requested a review from marcaaron November 3, 2023 08:20

Beamanator approved these changes Nov 3, 2023

View reviewed changes

Beamanator merged commit f498830 into Expensify:main Nov 3, 2023
17 of 22 checks passed

Beamanator changed the title ~~fix regression copy to clipboard~~ [CP Staging] fix regression copy to clipboard Nov 3, 2023

OSBotify pushed a commit that referenced this pull request Nov 3, 2023

Merge pull request #30818 from saranshbalyan-1234/fix-regression-copy…

1e8a4b3

…-to-clipboard fix regression copy to clipboard (cherry picked from commit f498830)

OSBotify mentioned this pull request Nov 3, 2023

Deploy Checklist: New Expensify 2023-11-02 #30752

Closed

melvin-bot bot mentioned this pull request Nov 6, 2023

[HOLD for payment 2023-11-22] [HOLD for payment 2023-11-13] Expense - Copy to clipboard option for system message for paid expense crashes the app #30796

Closed

6 tasks

OSBotify mentioned this pull request Nov 8, 2023

Deploy Checklist: New Expensify 2023-11-08 #31077

Closed

saranshbalyan-1234 deleted the fix-regression-copy-to-clipboard branch November 26, 2023 07:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CP Staging] fix regression copy to clipboard #30818

[CP Staging] fix regression copy to clipboard #30818

saranshbalyan-1234 commented Nov 3, 2023 •

edited

Loading

melvin-bot bot commented Nov 3, 2023

cubuspl42 Nov 3, 2023

saranshbalyan-1234 Nov 3, 2023

cubuspl42 Nov 3, 2023

cubuspl42 Nov 6, 2023 •

edited

Loading

saranshbalyan-1234 Nov 6, 2023

cubuspl42 Nov 7, 2023

saranshbalyan-1234 Nov 7, 2023 •

edited

Loading

cubuspl42 Nov 7, 2023

mountiny Nov 9, 2023

marcaaron Nov 9, 2023

Beamanator commented Nov 3, 2023

cubuspl42 commented Nov 3, 2023 •

edited

Loading

cubuspl42 commented Nov 3, 2023

Beamanator commented Nov 3, 2023

OSBotify commented Nov 3, 2023

OSBotify commented Nov 3, 2023

OSBotify commented Nov 6, 2023

OSBotify commented Nov 10, 2023

[CP Staging] fix regression copy to clipboard #30818

[CP Staging] fix regression copy to clipboard #30818

Conversation

saranshbalyan-1234 commented Nov 3, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Nov 3, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cubuspl42 Nov 6, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

saranshbalyan-1234 Nov 7, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Beamanator commented Nov 3, 2023

cubuspl42 commented Nov 3, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

cubuspl42 commented Nov 3, 2023

Beamanator commented Nov 3, 2023

OSBotify commented Nov 3, 2023

OSBotify commented Nov 3, 2023

OSBotify commented Nov 6, 2023

OSBotify commented Nov 10, 2023

saranshbalyan-1234 commented Nov 3, 2023 •

edited

Loading

cubuspl42 Nov 6, 2023 •

edited

Loading

saranshbalyan-1234 Nov 7, 2023 •

edited

Loading

cubuspl42 commented Nov 3, 2023 •

edited

Loading