[HOLD for payment 2023-12-06] [$250] Workspace - Custom invitation message is still preserved after sending an invitation

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Found when executing PR : #30562

Version Number: v1.3.96-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation: @

Action Performed:

1. Navigate to staging.new.expensify.com.
2. Go to Settings > Workspaces > any workspace.
3. Go to Members > Invite.
4. Select any user and proceed to the next page.
5. Enter a custom invitation message.
6. Click invite.
7. Repeat Step 1-5 with another workspace.

Expected Result:

The invitation messages are saved per workspace basis. They are reset after signout out and sign back in but while user is signed in, we keep the welcome message saved per workspace

Actual Result:

The custom invitation message is preserved across policies

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6267203_1699356178822.20231107_110919.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~017cd1e2909d9808bd
• Upwork Job ID: 1721871527814250496
• Last Price Increase: 2023-11-14
• Automatic offers:
• akinwale | Contributor | 27756684
• DylanDylann | Contributor | 27785352

Issue Owner

Current Issue Owner: @mallenexpensify

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~017cd1e2909d9808bd

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @mountiny (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[GItGudRatio]

I'm available for a fix immediately.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Custom invitation message is still preserved after sending an invitation

What is the root cause of that problem?

After sending the message, the savedWelcomeMessage onyx key is not cleared.

What changes do you think we should make in order to solve the problem?

To fix this issue, we need to clear the onyx key in the sendInvitation method.

Onyx.set(`${ONYXKEYS.FORMS.WORKSPACE_INVITE_MESSAGE_FORM}Draft`, message);

What alternative solutions did you explore? (Optional)

Another logical issue in this implementation is that custom message is the same across all workspaces, even if we do not invite any user. We need to implement the Onyx Key using policy ID and then proceed accordingly.

[Pujan92]

Seems like a regression from #27902

[allroundexperts]

As per #27902 (comment), this is the expected behaviour.

[mountiny]

This seems to be intended behaviour now.

[GItGudRatio]

Just wondering about a feature request - What if I want to reset to the default welcome message? There is no way to do that with the current workflow I think

[mountiny]

We will discuss if we want to change anything about this flow or not.

[melvin-bot]

📣 @DylanDylann 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[DylanDylann]

@akinwale PR #31770 is ready to review

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.4-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix/30992: Workspace invitation message still preserved #31770

If no regressions arise, payment will be issued on 2023-12-06. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @akinwale requires payment offer (Contributor)
• @DylanDylann requires payment offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@akinwale] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@mallenexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[mallenexpensify]

Contributor: @DylanDylann paid $250 via Upwork
Contributor+: @akinwale paid $250 via Upwork

@akinwale can you please propose the regression test steps to add for the new feature? Thx

[melvin-bot]

@akinwale, @mallenexpensify, @mountiny, @DylanDylann Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[mountiny]

@akinwale bump please

[akinwale]

@akinwale bump please

Missed the initial notification. I'll get to it within an hour.

[akinwale]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@akinwale] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.

1. Launch Expensify
2. Navigate to Settings > Workspaces and create at least two workspaces if there are no workspaces, or create an additional one if there is only one workspace created.
3. Select a workspace and navigate to Members > Invite.
4. Select any user and navigate to the next step.
5. Enter a custom invitation message and click invite.
6. Navigate back and repeat steps 3 through 6 for a different workspace.
7. Verify that the invitation message is different for the other workspace.
8. Repeat steps 3 through 8 for different workspaces
9. Verify that the custom invitation message entered for each corresponding workspace does not change.
10. Verify that two or more workspaces do not have the same custom invitation message (assuming all the custom invitation messages entered are different).

Do we agree 👍 or 👎?

[mountiny]

@akinwale I would update this to make it clear that the custom message should stay same on the particular workspace, ie its different across workspaces but remains unchanged on the same workspace

[akinwale]

@mountiny Updated.

[mountiny]

Thanks, @mallenexpensify all yours!

[mallenexpensify]

Thanbks @akinwale !

• https://github.com/Expensify/Expensify/issues/348703