[HOLD for payment 2023-11-29] [$500] Personal details - App crashed when tap on Home address page

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.3.96.0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Launch App
2. Tap on Settings > Profile > Personal details
3. Tap on address

Expected Result:

Address page should be open.

Actual Result:

App crashed when tapping on Home address page.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6266745_1699322553840.RPReplay_Final1699320482.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~010ad9a28a992c9851
• Upwork Job ID: 1721813829199605760
• Last Price Increase: 2023-11-07
• Automatic offers:
• GItGudRatio | Contributor | 27554474

Issue Owner

Current Issue Owner: @alexpensify

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @thienlnam (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[thienlnam]

Found the PR that caused the regression: #29742

#29742 (comment)

[GItGudRatio]

I'm available to fix this issue immediately
cc @thienlnam

Proposal

Please re-state the problem that we are trying to solve in this issue.

App crashes when tapping on Home address page

What is the root cause of that problem?

The root cause lies in this line:

App/src/pages/settings/Profile/PersonalDetails/AddressPage.js

Line 215 in 040c8a7

accessibilityLabel={translate('common.addressLine')}

Since this does not have the parameters, undefined is used when trying to destructure parameters, causing the fatal crash.

What changes do you think we should make in order to solve the problem?

TO fix this, we can change the line to accessibilityLabel={translate('common.addressLine', {lineNumber: 2})}

What alternative solutions did you explore? (Optional)

remove accessibilityLabel

[thienlnam]

Sounds great - looks like that fixes it. Will assign ya

[GItGudRatio]

PR is up, please help review @thienlnam! Could you also please add the External tag so Melv can assign a C+?

[situchan]

Maybe @getusha can take this as C+ as it came from PR he reviewed.

[thienlnam]

This is pretty straightforward so going to review it myself - also I wouldn't say this is a regression actually - it's more a feature that was caught by typescript

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~010ad9a28a992c9851

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

[melvin-bot]

📣 @GItGudRatio 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[mountiny]

Fixed in staging

[melvin-bot]

@thienlnam, @GItGudRatio Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[thienlnam]

cc @dylanexpensify

This has been fixed and is ready to pay out- we just need to pay @GItGudRatio for fixing the issue (no C+ payment needed for this since I did the review myself)

[dylanexpensify]

Nice! Paying today! @GItGudRatio did you apply in Upwork?

[GItGudRatio]

@dylanexpensify Hi, yes, have already accepted the offer.

[melvin-bot]

@thienlnam, @GItGudRatio, @dylanexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[alexpensify]

Here is the payment summary:

• External issue reporter - N/A
• Contributor that fixed the issue - @GItGudRatio $500
• Contributor+ that helped on the issue and/or PR - N/A

Upwork Job: https://www.upwork.com/jobs/~010ad9a28a992c9851

*If applicable, the bonuses will be applied on the final payment

Extra Notes regarding payment: I'm going off the summary shared here #30949 (comment)

[alexpensify]

Done @GItGudRatio has been paid via Upwork and I closed the job. I'm going to close this GH now.