[HOLD for payment 2023-11-30] [$500] IOU-Description is shown in preview in manual request while receipt is uploading.

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.3.97-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation: @

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Tap fab
3. Tap request money--- Manual
4. Enter an amount and tap next
5. Select a user
6. Tap on 3 dots and "add receipt"
7. Enter description
8. Tap request amount
9. Tap on IOU

Expected Result:

In IOU report, the description must not be shown in preview while receipt is uploading.

Actual Result:

In IOU report, the description is shown in preview in manual request while receipt is uploading.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6269654_1699516685834.des.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0136e412ae57e89702
• Upwork Job ID: 1722554040572862464
• Last Price Increase: 2023-11-09
• Automatic offers:
• DylanDylann | Contributor | 27670888

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0136e412ae57e89702

[melvin-bot]

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

[DylanDylann]

Proposal

Please re-state the problem that we are trying to solve in this issue.

IOU-Description is shown in preview in manual request while receipt is uploading

What is the root cause of that problem?

This is the currently logic

    const shouldShowDescription = !_.isEmpty(description) && !shouldShowMerchant;

we don't have logic to check if receipt is canning

What changes do you think we should make in order to solve the problem?

Should add a logic to check if receipt is canning we will hide description like this

    const shouldShowDescription = !_.isEmpty(description) && !shouldShowMerchant && !isScanning

What alternative solutions did you explore? (Optional)

We also consider to add isScanning condition to definition of shouldShowMerchant too

[PiyushChandra17]

Proposal

Please re-state the problem that we are trying to solve in this issue.

IOU-Description is shown in preview in manual request while receipt is uploading

What is the root cause of that problem?

We are not checking for,

App/src/components/ReportActionItem/MoneyRequestPreview.js

Line 164 in 16e40c9

const isScanning = hasReceipt && TransactionUtils.isReceiptBeingScanned(props.transaction);

Here,

App/src/components/ReportActionItem/MoneyRequestPreview.js

Line 174 in 16e40c9

const shouldShowDescription = !_.isEmpty(description) && !shouldShowMerchant;

Perhaps this is the root cause

What changes do you think we should make in order to solve the problem?

First things first check for isScanning upfront,

const shouldShowDescription = !isScanning && !_.isEmpty(description) && !shouldShowMerchant;

What alternative solutions did you explore? (Optional)

NA

[allroundexperts]

Thanks for your proposal @PiyushChandra17. I wasn't able to find it very different from what @DylanDylann proposed earlier.

@DylanDylann's proposal looks good.

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @marcochavezf, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[MitchExpensify]

Are we good to assign @DylanDylann , @marcochavezf ?

[marcochavezf]

Yup, thanks for the review @allroundexperts, the solution lgtm as well, assigning @DylanDylann 🚀

[melvin-bot]

📣 @allroundexperts Please request via NewDot manual requests for the Reviewer role ($500)

[melvin-bot]

📣 @DylanDylann 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[DylanDylann]

@allroundexperts PR #31348 is ready to review

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.2-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix/31104: Description is shown in preview #31348

If no regressions arise, payment will be issued on 2023-11-30. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @allroundexperts does not require payment (Eligible for Manual Requests)
• @DylanDylann requires payment offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@allroundexperts] The PR that introduced the bug has been identified. Link to the PR:
• [@allroundexperts] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@allroundexperts] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@allroundexperts] Determine if we should create a regression test for this bug.
• [@allroundexperts] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@MitchExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[MitchExpensify]

Payment summary:

$500 - @allroundexperts, C+, NewDot
$500 - @DylanDylann, C, Upwork

[allroundexperts]

Checklist

1. Design clean-up and consistency across expense reports and requests #26603
2. https://github.com/Expensify/App/pull/26603/files#r1405482536
3. N/A
4. Regression test would be helpful. The steps given in the OP look good enough to me!

[MitchExpensify]

Paid and contract ended, @DylanDylann

Added request for new test here: https://github.com/Expensify/Expensify/issues/343038

Closing as payment for @allroundexperts will occur on NewDot

Thanks every one!

[JmillsExpensify]

$500 payment approved for @allroundexperts based on this comment.