[HOLD for payment 2023-12-15] [$500] mWeb/Safari - IOU - Next button in BNP in Request money and Send money is blocked by address bar

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v1.3.97-2
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation: @

Action Performed:

1. Navigate to staging.new.expensify.com
2. Tap + > Request money.
3. Go back to Home.
4. Tap + > Send money.

Expected Result:

The Next button in BNP in Request money and Send money page will not be blocked by browser address bar.

Actual Result:

The Next button in BNP in Request money and Send money page is blocked by browser address bar.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6270141_1699544225330.RPReplay_Final1699529808.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~019e7d88002f72cbd2
• Upwork Job ID: 1722641847224213504
• Last Price Increase: 2023-11-30

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~019e7d88002f72cbd2

[melvin-bot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @getusha (External)

[ishpaul777]

Proposal

Problem

mWeb/Safari - IOU - Next button in BNP in Request money and Send money is blocked by address bar

Root cause

We have applied initial minHeight in screenwrapper in #30065 for #17866, on Ios safari the banner is added to viewport after minHeight is applied to Screen causeing the button to be overlapped by searchbar

Changes

We should check if browser is mobile safari and add event listener for window resize (it fires when smart banner is renderred verified on staging physical device) though we can not test the solution in dev enviornment as the banner can only be shown in stag/prod enviornment as smart banner we use requires to have set up Universal Linking to show banner ref. here for more info.

Code changes

[greg-schroeder]

Awaiting proposal review

[fedirjh]

cc @sarious Could you please handle this regression ?

[sarious]

@fedirjh
Well, is it related only for Chrome browser?
Is this "Open in the app" banner created in app or by 3rd party service?

[getusha]

@sarious based on the bug report it's happening on iOS: mWeb Safari

[sarious]

@sarious based on the bug report it's happening on iOS: mWeb Safari

Oh, I see. Just want to reproduce it and understand the origin of this banner. It looks like not the component of app?
I don't see this banner (can not reproduce) on either the local version or the staging version on iOS mWeb Safari.

[sarious]

@ishpaul777 it looks like that banner is not displayed permanently.. I haven't figured out when and how yet.
Maybe it will be difficult to calculate banner height, it looks like managed by 3rd party service.

[sarious]

@izarutskaya could you provide, please, the complete steps to reproduce this issue?
I'm trying to reproduce in simulator iPhone 14 Simulator Version: 16.4. The link: https://staging.new.expensify.com
But I don't see a notification on top of the page about opening the app.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[greg-schroeder]

@ishpaul777 @izarutskaya any chance you could help answer @sarious's questions above?

[ishpaul777]

The smart app banner is exclusive to safari mobile only, I think we use a webpack plugin for production and staging builds only, so you might not able reproduce this on simulator, you can try playing with configuration for webpack dev file, it may work but it still requires a physical device to be able to reproduce as far as i can tell, i'll add more details soon (currently i am AFK)

[izarutskaya]

I can still reproduce it on iPhone 14 Pro Max/iOS16.6.1
Build v1.4.0-3
If I try to change text size on my device the button becomes more visible, but I'm not sure if this will help

Rpreplay.Final1700219381.mp4

[sarious]

The smart app banner is exclusive to safari mobile only, I think we use a webpack plugin for production and staging builds only, so you might not able reproduce this on simulator, you can try playing with configuration for webpack dev file, it may work but it still requires a physical device to be able to reproduce as far as i can tell, i'll add more details soon (currently i am AFK)

Well, thank you for answering! I've been checking on staging environment: staging.new.expensify.com. And it seems it doesn't matter is it physical device or emulator.

[getusha]

@sarious you can raise this to expensify-open-source channel, similar issue has been fixed before.

[greg-schroeder]

Yes let's start a discussion!

[melvin-bot]

@greg-schroeder @getusha this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ and will need to go internal. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@greg-schroeder @getusha this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ and will need to go internal. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

[melvin-bot]

@greg-schroeder @getusha this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ and will need to go internal. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

[greg-schroeder]

@sarious were you able to get that discussion rolling or do you need someone to step in?

[sarious]

@sarious were you able to get that discussion rolling or do you need someone to step in?

It seems @fedirjh has added some fix for Safari browser. It should work.

By the way, I think it would be good to implement a possibility to test "Install/open" banner to prevent future issues. How do I promote this idea so that someone will do it, if it possible at all?

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.9-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [Fix] - Disable ScreenWrapper minHeight for safari browser #32460

If no regressions arise, payment will be issued on 2023-12-15. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @getusha requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@getusha] The PR that introduced the bug has been identified. Link to the PR:
• [@getusha] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@getusha] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@getusha] Determine if we should create a regression test for this bug.
• [@getusha] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@greg-schroeder] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[greg-schroeder]

Okay so ... actually I think this one wasn't reviewed by @getusha after all, as it was handled alongside several others by @fedirjh and @c3024 here: #32460

Sorry, I withdrew the offer I made by mistake.