[$500] Scan - Error shows up when tapping on capture button

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.3.99.0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - internal Team
Slack conversation:

Action Performed:

1. Launch New Expensify app.
2. Tap + > Request money > Scan.
3. Tap Continue.
4. Allow camera access.
5. Tap capture button.

Expected Result:

User is able to take a photo.

Actual Result:

Error shows up when tapping on capture button

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6276705_1700008946890.Screen_Recording_20231115_082000_New_Expensify.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~016c56226964146dd4
• Upwork Job ID: 1724589749726212096
• Last Price Increase: 2023-11-29

Issue Owner

Current Issue Owner: @eVoloshchak

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~016c56226964146dd4

[melvin-bot]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

[tienifr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Error shows up when tapping on capture button

What is the root cause of that problem?

We're not forwarding ref properly inside withTabAnimation, so the ref of camera is undefined, causing the error to show. Particularly, we're just passing ref as a prop to WithTabAnimation and WrappedComponentWithTabAnimation without using React.forwardRef, which will not work.

What changes do you think we should make in order to solve the problem?

Forward ref properly inside withTabAnimation by using React.forwardRef. We need to use it for both WithTabAnimation and WrappedComponentWithTabAnimation as well, not just WithTabAnimationWithRef.

After we implement it properly for WithTabAnimation and WrappedComponentWithTabAnimation, we can potentially remove WithTabAnimationWithRef since it doesn't serve any purpose now.

The final code for withTabAnimation will look like:

const WrappedComponentWithTabAnimation = React.forwardRef((props, ref) => {
...
}

const WithTabAnimation = React.forwardRef((props, ref) => {
...
}

return WithTabAnimation;

What alternative solutions did you explore? (Optional)

NA

[strepanier03]

Able to repro on 1.3.99.0. Looks like we had a fix for this that produced a regression.

[strepanier03]

Gentle bump @eVoloshchak for the proposal here.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@eVoloshchak, @strepanier03 Whoops! This issue is 2 days overdue. Let's get this updated quick!

[eVoloshchak]

I cannot reproduce the issue on both iOS and Android, looks like this has been resolved
@tienifr, could you double-check if this is still reproducible for you?

[strepanier03]

I can no longer repro either. My guess is the fix that caused a regression is back in place now. I think we can likely close this one but I'll wait for @tienifr to weigh in before taking any action.

[melvin-bot]

@eVoloshchak @strepanier03 this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[strepanier03]

Going to close this out, we can reopen if needed.