[HOLD for payment 2023-12-07] [$500] Request money get $250 not formatted correctly

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.0-3
Reproducible in staging?: y
Reproducible in production?: seems new feature
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @allroundexperts
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1700345578210519

Action Performed:

1. Click on the + fab
2. Request money
3. Enter an amount and go to the participants selection step
4. Click on the Request money, get $250 bottom alert.

Expected Result:

Request money, get $250 text to be formatted correctly.

Actual Result:

Incorrect formatting (includes an extra space before the amount)

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Recording.246.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01f6c623a72781c0f8
• Upwork Job ID: 1726615300061036544
• Last Price Increase: 2023-11-27
• Automatic offers:
• fedirjh | Reviewer | 27852593

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01f6c623a72781c0f8

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

[m-natarajan]

Proposal from @allroundexperts

Proposal

Please re-state the problem that we are trying to solve in this issue.

Request money, get $250 not formatted correctly.

What is the root cause of that problem?

We have added an extra space here

What changes do you think we should make in order to solve the problem?

Just remove the extra space here.

What alternative solutions did you explore? (Optional)

None

[esh-g]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Request money, get $250 not formatted correctly.

Root cause

We have extra space here:

App/src/languages/en.ts

Line 1923 in aeced9a

body: `Request money from a new Expensify account. Get $${CONST.REFERRAL_PROGRAM.REVENUE} once they start an annual subscription with two or more active members and make the first two payments toward their Expensify bill.`,

Changes

We need to remove the space

App/src/languages/en.ts

Line 1923 in aeced9a

body: `Request money from a new Expensify account. Get $${CONST.REFERRAL_PROGRAM.REVENUE} once they start an annual subscription with two or more active members and make the first two payments toward their Expensify bill.`,

[situchan]

This should be handled as follow-up of #30372
cc: @waterim @cubuspl42 @puneetlath

[yatinj30]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Request money, get $250 is not formatted correctly.

What is the root cause of that problem?

There is an extra space before an amount.

What changes do you think we should make in order to solve the problem?

Remove that extra space before an amount.

What alternative solutions did you explore? (Optional)

None

[PiyushChandra17]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Request money get $250 not formatted correctly

What is the root cause of that problem?

We have an extra space here,

App/src/languages/en.ts

Line 1923 in 475d239

body: `Request money from a new Expensify account. Get $${CONST.REFERRAL_PROGRAM.REVENUE} once they start an annual subscription with two or more active members and make the first two payments toward their Expensify bill.`,

What changes do you think we should make in order to solve the problem?

We need to remove this extra space,

body: `Request money from a new Expensify account. Get $${CONST.REFERRAL_PROGRAM.REVENUE} once they start an annual subscription with two or more active members and make the first two payments toward their Expensify bill.`

What alternative solutions did you explore? (Optional)

NA

Result:

[mallenexpensify]

@fedirjh , please review the above, reckon it'll be a pretty quick fix. Let me know if you'd like me to loop in a designer to confirm anything. Thx

[fedirjh]

Please review the above, reckon it'll be a pretty quick fix.

@mallenexpensify BTW It's an easy simple fix, I would agree with @situchan #31554 (comment) as the offending PR is still in the regression period. In case we want to fix it separately, then @allroundexperts proposal looks good.

[melvin-bot]

@mallenexpensify, @fedirjh Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[fedirjh]

cc @mallenexpensify friendly bump for #31554 (comment).

[allroundexperts]

I think this is fixed somehow.

[fedirjh]

Hmm, I still see the code was not yet updated :

App/src/languages/en.ts

Line 1953 in 4efa2c0

body: `Request money from a new Expensify account. Get $${CONST.REFERRAL_PROGRAM.REVENUE} once they start an annual subscription with two or more active members and make the first two payments toward their Expensify bill.`,

[allroundexperts]

Oh, I guess I was mistaken then!

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[puneetlath]

@waterim can I assign this to you since it came from your PR?

[waterim]

@puneetlath sure, can update this typo

[puneetlath]

Thanks!

[melvin-bot]

📣 @fedirjh 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @allroundexperts Please request via NewDot manual requests for the Reporter role ($50)

[melvin-bot]

Triggered auto assignment to @amyevans, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.5-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix: An extra space in request money promote referral page #32108

If no regressions arise, payment will be issued on 2023-12-07. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @fedirjh requires payment offer (Reviewer)
• @waterim does not require payment (Contractor)
• @allroundexperts does not require payment (Eligible for Manual Requests)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@fedirjh] The PR that introduced the bug has been identified. Link to the PR:
• [@fedirjh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@fedirjh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@fedirjh] Determine if we should create a regression test for this bug.
• [@fedirjh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@mallenexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[mallenexpensify]

@fedirjh can you please accept the job and reply here once you have?
https://www.upwork.com/jobs/~01f6c623a72781c0f8

[melvin-bot]

@amyevans, @mallenexpensify, @fedirjh, @waterim Whoops! This issue is 2 days overdue. Let's get this updated quick!

[fedirjh]

can you please accept the job and reply here once you have?

@mallenexpensify Accepted. Thank you!

[mallenexpensify]

Contributor+: @fedirjh paid $500 via Upwork.

I don't think we need to add this to the design/edge case tests we occasionally run, checking with QA to see if anyone disagrees.
https://expensify.slack.com/archives/C9YU7BX5M/p1702426325644959