-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$500] [HOLD for payment 2023-11-30] Web - Referral - 'Got it' button does not take you back to the Previous page after a reload #31628
Comments
Triggered auto assignment to @grgia ( |
ProposalPlease re-state the problem that we are trying to solve in this issue.Web - Referral - 'Got it' button does not take you back to the Previous page after a reload What is the root cause of that problem?Currently, when clicking Got it button, we will call App/src/pages/ReferralDetailsPage.js Line 89 in 0cca90a
So if we reload page navigation history will be lost, It cause this bug. The same bug also happen when we click back button App/src/pages/ReferralDetailsPage.js Line 63 in 0cca90a
What changes do you think we should make in order to solve the problem?We should define new goBack function in the ReferralDetailsPage
What alternative solutions did you explore? (Optional)
|
@DylanDylann are you able to work on a PR within the next hour? |
@luacmartins I am available, only if dylan is away. Should I post a prospal? |
sure, go ahead |
@luacmartins It seems that I can't come up with a better proposal than Dylan's. If I do post a proposal, most likely it will be the same as Dylans. |
We got a fix merged and CPed |
@luacmartins It was 2:42 AM in my time, so I wasn't available to raise a quick PR. Thanks so much for your PR. Could you assign me to this issue for compensation? |
Triggered auto assignment to @conorpendergrast ( |
Bug0 Triage Checklist (Main S/O)
|
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.2-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2023-11-30. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
Job added to Upwork: https://www.upwork.com/jobs/~0114db822bdf934768 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws ( |
It looks like @DylanDylann is the only person to be compensated here. @luacmartins given you assigned @DylanDylann to the issue, I'm taking that as an endorsement of the solution and that partial compensation is needed here (as @DylanDylann didn't create the PR directly). I'm going to move ahead with 50% compensation (so that's 50% of $500 = $250) |
Payouts due:
Upwork job is here. |
Paid @DylanDylann! @luacmartins From the checklist, as you filled out the first three steps, do you think we need a regression test? Once we confirm that and complete the checklist, we'll be set to close this out |
No need for regression test since Applause already caught this issue during regression. |
Closing issue as per comment above. Thanks everyone! |
Damn, you stole the satisfying bit. And thanks! I am still not used to 90% of bugs coming directly from regression testing |
Sorry haha I'll let you close it next time :) |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.1.5
Reproducible in staging?: y
Reproducible in production?: new feature
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:
Expected Result:
Click on the 'Got it' Button takes you back to the Manual page
Actual Result:
Click on the 'Got it' Button takes you back to the main chat.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6285169_1700553479347.test1_Referral.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: