Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] [HOLD for payment 2023-11-30] Web - Referral - 'Got it' button does not take you back to the Previous page after a reload #31628

Closed
3 of 6 tasks
kbecciv opened this issue Nov 21, 2023 · 22 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor

Comments

@kbecciv
Copy link

kbecciv commented Nov 21, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.1.5
Reproducible in staging?: y
Reproducible in production?: new feature
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. Click on FAB > Request Money > switch to Manual
  2. Enter the amount and click on Next
  3. Click on 'Request money, get $250' to go to the referral page
  4. Reload the page
  5. Click on the 'Got it' Button

Expected Result:

Click on the 'Got it' Button takes you back to the Manual page

Actual Result:

Click on the 'Got it' Button takes you back to the main chat.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6285169_1700553479347.test1_Referral.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0114db822bdf934768
  • Upwork Job ID: 1730235291142729728
  • Last Price Increase: 2023-11-30
@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Nov 21, 2023
Copy link

melvin-bot bot commented Nov 21, 2023

Triggered auto assignment to @grgia (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@DylanDylann
Copy link
Contributor

DylanDylann commented Nov 21, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

Web - Referral - 'Got it' button does not take you back to the Previous page after a reload

What is the root cause of that problem?

Currently, when clicking Got it button, we will call Navigation.goBack().

onPress={() => Navigation.goBack()}

So if we reload page navigation history will be lost, It cause this bug. The same bug also happen when we click back button
onBackButtonPress={() => Navigation.goBack()}

What changes do you think we should make in order to solve the problem?

We should define new goBack function in the ReferralDetailsPage
We should use referralContentType in route to detect which is previous page and navigate to this page directly:

  • If contentType is startChat, goBack function will be navigating to StartChatPage
  • Similar to other page

What alternative solutions did you explore? (Optional)

  • NA

@luacmartins
Copy link
Contributor

@DylanDylann are you able to work on a PR within the next hour?

@Tony-MK
Copy link
Contributor

Tony-MK commented Nov 21, 2023

@luacmartins I am available, only if dylan is away. Should I post a prospal?

@luacmartins
Copy link
Contributor

sure, go ahead

@Tony-MK
Copy link
Contributor

Tony-MK commented Nov 21, 2023

@luacmartins It seems that I can't come up with a better proposal than Dylan's. If I do post a proposal, most likely it will be the same as Dylans.

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Hourly KSv2 labels Nov 21, 2023
@luacmartins luacmartins assigned luacmartins and unassigned grgia Nov 21, 2023
@luacmartins
Copy link
Contributor

We got a fix merged and CPed

@luacmartins luacmartins removed the DeployBlockerCash This issue or pull request should block deployment label Nov 21, 2023
@DylanDylann
Copy link
Contributor

@DylanDylann are you able to work on a PR within the next hour?

@luacmartins It was 2:42 AM in my time, so I wasn't available to raise a quick PR. Thanks so much for your PR. Could you assign me to this issue for compensation?

@luacmartins luacmartins added the Bug Something is broken. Auto assigns a BugZero manager. label Nov 22, 2023
Copy link

melvin-bot bot commented Nov 22, 2023

Triggered auto assignment to @conorpendergrast (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Nov 22, 2023
Copy link

melvin-bot bot commented Nov 22, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 labels Nov 23, 2023
@melvin-bot melvin-bot bot changed the title Web - Referral - 'Got it' button does not take you back to the Previous page after a reload [HOLD for payment 2023-11-30] Web - Referral - 'Got it' button does not take you back to the Previous page after a reload Nov 23, 2023
Copy link

melvin-bot bot commented Nov 23, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Nov 23, 2023
Copy link

melvin-bot bot commented Nov 23, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.2-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-11-30. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Nov 23, 2023

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Nov 30, 2023
@conorpendergrast conorpendergrast added the External Added to denote the issue can be worked on by a contributor label Nov 30, 2023
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2023-11-30] Web - Referral - 'Got it' button does not take you back to the Previous page after a reload [$500] [HOLD for payment 2023-11-30] Web - Referral - 'Got it' button does not take you back to the Previous page after a reload Nov 30, 2023
Copy link

melvin-bot bot commented Nov 30, 2023

Job added to Upwork: https://www.upwork.com/jobs/~0114db822bdf934768

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Nov 30, 2023
Copy link

melvin-bot bot commented Nov 30, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (External)

@conorpendergrast conorpendergrast removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Nov 30, 2023
@conorpendergrast
Copy link
Contributor

It looks like @DylanDylann is the only person to be compensated here. @luacmartins given you assigned @DylanDylann to the issue, I'm taking that as an endorsement of the solution and that partial compensation is needed here (as @DylanDylann didn't create the PR directly). I'm going to move ahead with 50% compensation (so that's 50% of $500 = $250)

@conorpendergrast
Copy link
Contributor

conorpendergrast commented Nov 30, 2023

Payouts due:

Upwork job is here.

@conorpendergrast
Copy link
Contributor

Paid @DylanDylann!

@luacmartins From the checklist, as you filled out the first three steps, do you think we need a regression test?

Once we confirm that and complete the checklist, we'll be set to close this out

@melvin-bot melvin-bot bot removed the Overdue label Dec 4, 2023
@luacmartins
Copy link
Contributor

No need for regression test since Applause already caught this issue during regression.

@luacmartins
Copy link
Contributor

Closing issue as per comment above. Thanks everyone!

@conorpendergrast
Copy link
Contributor

Damn, you stole the satisfying bit.

And thanks! I am still not used to 90% of bugs coming directly from regression testing

@luacmartins
Copy link
Contributor

Sorry haha I'll let you close it next time :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor
Projects
None yet
Development

No branches or pull requests

7 participants