Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Wave 6: Tags] Support Tag in Bill Split #31631

Closed
puneetlath opened this issue Nov 21, 2023 · 12 comments
Closed

[Wave 6: Tags] Support Tag in Bill Split #31631

puneetlath opened this issue Nov 21, 2023 · 12 comments
Assignees
@puneetlath @cubuspl42 @rezkiy37
Labels
NewFeature Something to build that is a new item. Reviewing Has a PR in review Weekly KSv2

Comments

@puneetlath
Copy link
Contributor

Just like we did in #27936 we should add Tag support for the bill split flow. Meaning:

  • tag can be selected
  • tag is optimistically set for the bill split and resulting expense
  • tag is sent to the API as part of the splitBill API call
@puneetlath puneetlath added Daily KSv2 NewFeature Something to build that is a new item. labels Nov 21, 2023
@puneetlath puneetlath self-assigned this Nov 21, 2023
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Nov 21, 2023

Current assignee @puneetlath is eligible for the NewFeature assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Nov 21, 2023
@rezkiy37
Copy link
Contributor

Hi, I’m Michael (Mykhailo) from Callstack and I would like to work on this issue.

@rezkiy37
Copy link
Contributor

@puneetlath, can I implement viewing/editing a tag in the scope of this issue? Like it was for categories here - #28628.

@puneetlath
Copy link
Contributor Author

Yes please. Let's use this issue to bring feature parity for tags on bill split to whatever we do for categories.

@rezkiy37 rezkiy37 mentioned this issue Nov 21, 2023
Merged
47 tasks
@puneetlath puneetlath changed the title Support Tag in Bill Splilt Support Tag in Bill Split Nov 21, 2023
@rezkiy37
Copy link
Contributor

The PR - #31647 - is being reviewed internally now. Opening soon 🙂

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 labels Nov 22, 2023
@greg-schroeder greg-schroeder changed the title Support Tag in Bill Split [Wave 6: Tags] Support Tag in Bill Split Nov 27, 2023
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Dec 6, 2023

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Dec 6, 2023
@yuwenmemon
Copy link
Contributor

I believe I have a fix for the aforementioned deploy blocker, please see: #32541

@puneetlath
Copy link
Contributor Author

Looks like we need to pay out @cubuspl42 for C+ on this. Is that right?

@cubuspl42
Copy link
Contributor

@puneetlath Yes, sounds right

@puneetlath
Copy link
Contributor Author

@cubuspl42 offer here: https://www.upwork.com/nx/wm/offer/100143026

Please ping me on this issue once you've accepted.

@cubuspl42
Copy link
Contributor

@puneetlath Thank you, done

@puneetlath
Copy link
Contributor Author

Paid. Thanks everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@puneetlath puneetlath

@cubuspl42 cubuspl42

@rezkiy37 rezkiy37

Labels
NewFeature Something to build that is a new item. Reviewing Has a PR in review Weekly KSv2
Projects
No open projects
[#whatsnext] Wave 06 - Collect Submitters
Status: Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@puneetlath @cubuspl42 @yuwenmemon @rezkiy37