Allow Adding/Viewing tag on a Split Bill #31647

rezkiy37 · 2023-11-21T17:01:41Z

Details

The PR introduces tags for split bills when a participant is a workspace. The app shows tags only for workspace participants with tags. All other cases users cannot add a tag to a split bill request. Also, we need to implement viewing a category on a newly created split bill.

Fixed Issues

$ #31631
PROPOSAL: N/A

Tests

Note: the backend is not ready yet to handle tags for split bills. So, we can check a newly added property in offline.

Note: "a workspace with some tags" means, that before testing, you should have a created workspace, which contains tags. For manipulating with tags, please use the OD. Also, the workspace's type should be "Collect" or "Control". If you cannot create your own, I can invite you to already prepared workspace.

1. Split bill with a tag

Click on "+" (FAB).
Click on "Request Money".
Click on "Split" on a participant that is a workspace with some tags.
Click on "Show more".
Verify that there is "Tag" (or another name, based on your configuration) field.
Click on the field.
Verify that you can select/deselect a tag.
Click on "Split".
Verify that the app redirects you to a chat page with a newly created split bill.
Verify that there is a tag field.
Verify that the field is disabled, you cannot interact with it.

2. Split bill without a tag

Click on "+" (FAB).
Click on "Request Money".
Click on "Split" on any participant that does not have tags like a regular user.
Click on "Show more".
Verify that there isn't "Tag" (or another name, based on your configuration) field.
Click on "Split".
Verify that the app redirects you to a chat page with a newly created split bill.
Verify that there is a tag field.
Verify that the field is disabled, you cannot interact with it.

3. Request money with a tag

Click on "+" (FAB).
Click on "Request Money".
Click on a participant that is a workspace with some tags.
Click on "Show more".
Verify that there is "Tag" field.
Click on "Request".
Verify that the app redirects you to a chat page with a newly created money request.
Verify that no errors happened.

4. Request money without a tag

Click on "+" (FAB).
Click on "Request Money".
Click on any participant that does not have tags like a regular user.
Click on "Show more".
Verify that there isn't "Tag" field.
Click on "Request".
Verify that the app redirects you to a chat page with a newly created money request.
Verify that no errors happened.

Verify that no errors appear in the JS console

Offline tests

Same as "Tests".

QA Steps

Same as "Tests".

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android.mp4

Android: mWeb Chrome

Android.Chrome.mp4

iOS: Native

IOS.mp4

iOS: mWeb Safari

IOS.Safari.mp4

MacOS: Chrome / Safari

Chrome.mp4

MacOS: Desktop

Desktop.mp4

…ture/31631-tags-in-split-bills

rezkiy37 · 2023-11-22T15:36:15Z

I've added one more case how to determine if a report is a policy expense chat - 5082a84. Because, a report can not have chatType.

melvin-bot · 2023-11-22T17:32:54Z

@cubuspl42 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

…ture/31631-tags-in-split-bills

src/libs/ReportUtils.js

src/libs/actions/IOU.js

src/libs/actions/Policy.js

cubuspl42 · 2023-11-27T13:29:11Z

The code looks good, I left minor comments 👍

…ture/31631-tags-in-split-bills

cubuspl42 · 2023-11-28T13:44:48Z

I'm testing

cubuspl42 · 2023-11-28T13:49:08Z

A silly question: what does it mean to have tags? I think that a setup of a test account that "has tags" could be a part of QA Steps / Tests

rezkiy37 · 2023-11-28T14:12:02Z

A silly question: what does it mean to have tags? I think that a setup of a test account that "has tags" could be a part of QA Steps / Tests

I means that a workspace should have tags for testing the new functionality.

cubuspl42 · 2023-11-28T14:23:20Z

I misread this, I thought that this is a property of a user. Still, I'm not sure how to add tags to a workspace. Is it obvious?

rezkiy37 · 2023-11-28T14:24:37Z

I misread this, I thought that this is a property of a user. Still, I'm not sure how to add tags to a workspace. Is it obvious?

I can add you to a workspace where there are some tags.

cubuspl42 · 2023-11-28T14:47:25Z

@rezkiy37 Thank you. Account: cubuspl42.1+4@gmail.com. Does it require some permissions to add a tag?

rezkiy37 · 2023-11-28T14:58:09Z

@cubuspl42, I've added you as an admin to a workspace called "Control Policy". No, it does not.

…ture/31631-tags-in-split-bills

cubuspl42 · 2023-11-29T12:28:06Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

tags-in-split-bills-web.mp4

Mobile Web - Chrome

tags-in-split-bills-android-web-compressed.mp4

Mobile Web - Safari

tags-in-split-bills-ios-web.mp4

Desktop

iOS

Android

tags-in-split-bills-android-compressed.mp4

cubuspl42

Will a QA person know how to find "participant that is a workspace and has tags."? I don't think this description is precise enough, as it is a new feature

I think we could provide steps for crafting such workspace for testing purposes

rezkiy37 · 2023-11-29T12:53:46Z

I agree, makes sense. I will clarify it 🙂

rezkiy37 · 2023-11-30T16:33:33Z

@cubuspl42, I've added this block. I hope it is clear now. WDYT?

cubuspl42 · 2023-12-01T10:30:49Z

@rezkiy37 I was missing the fact that you need to use OldDot! Maybe for QA people it would be obvious. Thanks for adding this!

…ture/31631-tags-in-split-bills

OSBotify · 2023-12-01T18:10:50Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-12-05T02:55:50Z

🚀 Cherry-picked to staging by https://github.com/yuwenmemon in version: 1.4.7-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2023-12-05T13:40:55Z

🚀 Deployed to staging by https://github.com/puneetlath in version: 1.4.8-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	cancelled 🔪
🕸 web 🕸	success ✅

OSBotify · 2023-12-06T20:31:00Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 1.4.8-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-12-06T20:40:32Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 1.4.8-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

eVoloshchak · 2024-02-08T16:07:04Z

src/libs/actions/IOU.js

@@ -1290,10 +1255,10 @@ function splitBill(participants, currentUserLogin, currentUserAccountID, amount,
 * @param {String} comment
 * @param {String} currency
 * @param {String} category
+ * @param {String} tag


Coming from #34988
When creating the optimistic split transaction, we needed to pass the category & tag to buildOptimisticTransaction

rezkiy37 added 3 commits November 21, 2023 17:55

create buildOptimisticPolicyRecentlyUsedTags

46c7ce2

prepare create split bill methods

a8350b9

add tags within components

13bad5b

rezkiy37 changed the title ~~Allow Adding/Viewinga tag on a Split Bill~~ Allow Adding/Viewing tag on a Split Bill Nov 21, 2023

rezkiy37 added 7 commits November 22, 2023 11:16

Merge branch 'main' of https://github.com/rezkiy37/Expensify into fea…

a231215

…ture/31631-tags-in-split-bills

Merge branch 'main' of https://github.com/rezkiy37/Expensify into fea…

4403cb8

…ture/31631-tags-in-split-bills

handle expense chat by one more property

5082a84

implement buildOptimisticPolicyRecentlyUsedTags properly

8c5f20b

integrate buildOptimisticPolicyRecentlyUsedTags

e8cc3ae

check isPolicyExpenseChat safely

d55f2ef

fix taking tag list name

ec204b5

rezkiy37 mentioned this pull request Nov 22, 2023

[Wave 6: Tags] Support Tag in Bill Split #31631

Closed

rezkiy37 marked this pull request as ready for review November 22, 2023 17:32

rezkiy37 requested a review from a team as a code owner November 22, 2023 17:32

melvin-bot bot requested review from cubuspl42 and removed request for a team November 22, 2023 17:32

Merge branch 'main' of https://github.com/rezkiy37/Expensify into fea…

54db582

…ture/31631-tags-in-split-bills

cubuspl42 reviewed Nov 27, 2023

View reviewed changes

src/libs/ReportUtils.js Outdated Show resolved Hide resolved

cubuspl42 reviewed Nov 27, 2023

View reviewed changes

src/libs/actions/IOU.js Outdated Show resolved Hide resolved

cubuspl42 reviewed Nov 27, 2023

View reviewed changes

src/libs/actions/Policy.js Show resolved Hide resolved

rezkiy37 added 3 commits November 27, 2023 15:20

Merge branch 'main' of https://github.com/rezkiy37/Expensify into fea…

07d79f4

…ture/31631-tags-in-split-bills

simplify optimistic tag syntax

3182e9b

simplify optimistic category syntax

26b7ba9

rezkiy37 requested a review from cubuspl42 November 27, 2023 14:36

Merge branch 'main' of https://github.com/rezkiy37/Expensify into fea…

6fb6c29

…ture/31631-tags-in-split-bills

Merge branch 'main' of https://github.com/rezkiy37/Expensify into fea…

d3033fe

…ture/31631-tags-in-split-bills

cubuspl42 suggested changes Nov 29, 2023

View reviewed changes

cubuspl42 approved these changes Dec 1, 2023

View reviewed changes

melvin-bot bot requested a review from puneetlath December 1, 2023 10:31

Merge branch 'main' of https://github.com/rezkiy37/Expensify into fea…

83451a8

…ture/31631-tags-in-split-bills

puneetlath approved these changes Dec 1, 2023

View reviewed changes

puneetlath merged commit fc86789 into Expensify:main Dec 1, 2023
15 checks passed

github-actions bot mentioned this pull request Dec 5, 2023

Deploy Checklist: New Expensify 2023-12-05 #32463

Closed

66 tasks

This was referenced Dec 6, 2023

[HOLD for payment 2023-12-15] Scan - Selected category and tag do not show up in the row in Split action menu #32517

Closed

[CP Staging] Make sure that split bills follow the correct routes for editing category/tag #32541

Merged

eVoloshchak reviewed Feb 8, 2024

View reviewed changes

eVoloshchak mentioned this pull request Feb 8, 2024

[HOLD for payment 2024-02-07] [$500] Split - Selected category and tag do not appear in split view when created offline #34988

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow Adding/Viewing tag on a Split Bill #31647

Allow Adding/Viewing tag on a Split Bill #31647

rezkiy37 commented Nov 21, 2023 •

edited

Loading

rezkiy37 commented Nov 22, 2023

melvin-bot bot commented Nov 22, 2023

cubuspl42 commented Nov 27, 2023

cubuspl42 commented Nov 28, 2023

cubuspl42 commented Nov 28, 2023

rezkiy37 commented Nov 28, 2023 •

edited

Loading

cubuspl42 commented Nov 28, 2023

rezkiy37 commented Nov 28, 2023

cubuspl42 commented Nov 28, 2023

rezkiy37 commented Nov 28, 2023 •

edited

Loading

cubuspl42 commented Nov 29, 2023

cubuspl42 left a comment

rezkiy37 commented Nov 29, 2023

rezkiy37 commented Nov 30, 2023

cubuspl42 commented Dec 1, 2023

OSBotify commented Dec 1, 2023

OSBotify commented Dec 5, 2023

OSBotify commented Dec 5, 2023

OSBotify commented Dec 6, 2023

OSBotify commented Dec 6, 2023

eVoloshchak Feb 8, 2024

Allow Adding/Viewing tag on a Split Bill #31647

Allow Adding/Viewing tag on a Split Bill #31647

Conversation

rezkiy37 commented Nov 21, 2023 • edited Loading

Details

Fixed Issues

Tests

1. Split bill with a tag

2. Split bill without a tag

3. Request money with a tag

4. Request money without a tag

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

rezkiy37 commented Nov 22, 2023

melvin-bot bot commented Nov 22, 2023

cubuspl42 commented Nov 27, 2023

cubuspl42 commented Nov 28, 2023

cubuspl42 commented Nov 28, 2023

rezkiy37 commented Nov 28, 2023 • edited Loading

cubuspl42 commented Nov 28, 2023

rezkiy37 commented Nov 28, 2023

cubuspl42 commented Nov 28, 2023

rezkiy37 commented Nov 28, 2023 • edited Loading

cubuspl42 commented Nov 29, 2023

Reviewer Checklist

Screenshots/Videos

cubuspl42 left a comment

Choose a reason for hiding this comment

rezkiy37 commented Nov 29, 2023

rezkiy37 commented Nov 30, 2023

cubuspl42 commented Dec 1, 2023

OSBotify commented Dec 1, 2023

OSBotify commented Dec 5, 2023

OSBotify commented Dec 5, 2023

OSBotify commented Dec 6, 2023

OSBotify commented Dec 6, 2023

eVoloshchak Feb 8, 2024

Choose a reason for hiding this comment

rezkiy37 commented Nov 21, 2023 •

edited

Loading

rezkiy37 commented Nov 28, 2023 •

edited

Loading

rezkiy37 commented Nov 28, 2023 •

edited

Loading